aboutsummaryrefslogtreecommitdiffstats
path: root/src/attributes.js
diff options
context:
space:
mode:
authorDavid Petersen <public@petersendidit.com>2009-12-08 07:43:36 +0800
committerJohn Resig <jeresig@gmail.com>2009-12-09 14:43:55 +0800
commit841f9ff7a1815b521044aeeb39ccbe70fa688201 (patch)
treeb4102f2867510421c08b93553a9b12a418a360a8 /src/attributes.js
parentd3dc2d1234af10cb856519a01a97358eb4103008 (diff)
downloadjquery-841f9ff7a1815b521044aeeb39ccbe70fa688201.tar.gz
jquery-841f9ff7a1815b521044aeeb39ccbe70fa688201.zip
Handle changing form attributes correctly when there is a child element with the same name. Fixes #4299
Diffstat (limited to 'src/attributes.js')
-rw-r--r--src/attributes.js8
1 files changed, 7 insertions, 1 deletions
diff --git a/src/attributes.js b/src/attributes.js
index b5a29e159..4405b431e 100644
--- a/src/attributes.js
+++ b/src/attributes.js
@@ -218,7 +218,13 @@ jQuery.extend({
if ( name == "type" && /(button|input)/i.test(elem.nodeName) && elem.parentNode ) {
throw "type property can't be changed";
}
- elem[ name ] = value;
+ // browsers index elements by id/name on forms, give priority to attributes.
+ if( jQuery.nodeName( elem, "form" ) ) {
+ // convert the value to a string (all browsers do this but IE) see #1070
+ elem.setAttribute( name, "" + value );
+ } else {
+ elem[ name ] = value;
+ }
}
// browsers index elements by id/name on forms, give priority to attributes.