aboutsummaryrefslogtreecommitdiffstats
path: root/src/attributes.js
diff options
context:
space:
mode:
authortimmywil <tim.willison@thisismedium.com>2011-04-03 16:49:48 -0400
committertimmywil <tim.willison@thisismedium.com>2011-04-03 19:13:41 -0400
commit2a8a2b61488e7857b116bedc9eb75bd971772c2f (patch)
tree20544db76a44856e433cf8295922b7f33261c36f /src/attributes.js
parentff7576755864193b4c1a00464bf0919bbbe96e8b (diff)
downloadjquery-2a8a2b61488e7857b116bedc9eb75bd971772c2f.tar.gz
jquery-2a8a2b61488e7857b116bedc9eb75bd971772c2f.zip
Move the if statement in jQuery.fn.removeAttr to jQuery.removeAttr
- Extra testing on removeAttr and IE form weirdness( all good )
Diffstat (limited to 'src/attributes.js')
-rw-r--r--src/attributes.js22
1 files changed, 11 insertions, 11 deletions
diff --git a/src/attributes.js b/src/attributes.js
index 7c03cddbe..b472e617c 100644
--- a/src/attributes.js
+++ b/src/attributes.js
@@ -16,9 +16,7 @@ jQuery.fn.extend({
removeAttr: function( name ) {
return this.each(function() {
- if ( this.nodeType === 1 ) {
- jQuery.removeAttr( this, name );
- }
+ jQuery.removeAttr( this, name );
});
},
@@ -335,15 +333,17 @@ jQuery.extend({
},
removeAttr: function( elem, name ) {
- name = jQuery.attrFix[ name ] || name;
+ if ( elem.nodeType === 1 ) {
+ name = jQuery.attrFix[ name ] || name;
- if ( jQuery.support.getSetAttribute ) {
- elem.removeAttribute( name );
- } else {
- // Set to default empty string
- elem.setAttribute( name, "" );
- // Attempt to remove completely with DOM level 1
- elem.removeAttributeNode( elem.getAttributeNode( name ) );
+ if ( jQuery.support.getSetAttribute ) {
+ elem.removeAttribute( name );
+ } else {
+ // Set to default empty string (No longer need to use attr for this)
+ elem.setAttribute( name, "" );
+ // Attempt to remove completely with DOM level 1
+ elem.removeAttributeNode( elem.getAttributeNode( name ) );
+ }
}
},