aboutsummaryrefslogtreecommitdiffstats
path: root/src/core.js
diff options
context:
space:
mode:
authorRichard Gibson <richard.gibson@gmail.com>2016-03-14 16:46:51 -0400
committerTimmy Willison <timmywillisn@gmail.com>2016-04-04 12:02:13 -0400
commite0d3bfa77073a245ca112736a1ed3db07d5adcf6 (patch)
tree4226878c88c40068e2eea1659339ada15965979c /src/core.js
parent10fc59007d717432ea126e49ce4142e6c4d5136e (diff)
downloadjquery-e0d3bfa77073a245ca112736a1ed3db07d5adcf6.tar.gz
jquery-e0d3bfa77073a245ca112736a1ed3db07d5adcf6.zip
Core: Simplify isPlainObject
Fixes gh-2986 Close gh-2998
Diffstat (limited to 'src/core.js')
-rw-r--r--src/core.js36
1 files changed, 18 insertions, 18 deletions
diff --git a/src/core.js b/src/core.js
index a9898e51d..7c2433529 100644
--- a/src/core.js
+++ b/src/core.js
@@ -1,6 +1,7 @@
define( [
"./var/arr",
"./var/document",
+ "./var/getProto",
"./var/slice",
"./var/concat",
"./var/push",
@@ -8,10 +9,13 @@ define( [
"./var/class2type",
"./var/toString",
"./var/hasOwn",
+ "./var/fnToString",
+ "./var/ObjectFunctionString",
"./var/support",
"./core/DOMEval"
-], function( arr, document, slice, concat,
- push, indexOf, class2type, toString, hasOwn, support, DOMEval ) {
+], function( arr, document, getProto, slice, concat, push, indexOf,
+ class2type, toString, hasOwn, fnToString, ObjectFunctionString,
+ support, DOMEval ) {
var
version = "@VERSION",
@@ -225,28 +229,24 @@ jQuery.extend( {
},
isPlainObject: function( obj ) {
- var key;
+ var proto, Ctor;
- // Not plain objects:
- // - Any object or value whose internal [[Class]] property is not "[object Object]"
- // - DOM nodes
- // - window
- if ( jQuery.type( obj ) !== "object" || obj.nodeType || jQuery.isWindow( obj ) ) {
+ // Detect obvious negatives
+ // Use toString instead of jQuery.type to catch host objects
+ if ( !obj || toString.call( obj ) !== "[object Object]" ) {
return false;
}
- // Not own constructor property must be Object
- if ( obj.constructor &&
- !hasOwn.call( obj, "constructor" ) &&
- !hasOwn.call( obj.constructor.prototype || {}, "isPrototypeOf" ) ) {
- return false;
- }
+ proto = getProto( obj );
- // Own properties are enumerated firstly, so to speed up,
- // if last one is own, then all properties are own
- for ( key in obj ) {}
+ // Objects with no prototype (e.g., `Object.create( null )`) are plain
+ if ( !proto ) {
+ return true;
+ }
- return key === undefined || hasOwn.call( obj, key );
+ // Objects with prototype are plain iff they were constructed by a global Object function
+ Ctor = hasOwn.call( proto, "constructor" ) && proto.constructor;
+ return typeof Ctor === "function" && fnToString.call( Ctor ) === ObjectFunctionString;
},
isEmptyObject: function( obj ) {