diff options
author | jeresig <jeresig@gmail.com> | 2010-01-28 14:12:44 -0500 |
---|---|---|
committer | jeresig <jeresig@gmail.com> | 2010-01-28 14:12:44 -0500 |
commit | eed69eccc54d010889b5d8495320538d7ceb4e51 (patch) | |
tree | 903a491509cd7799d8a9c0dd2ab697929bbd67b7 /src/data.js | |
parent | 942f8f7f75a55a36e6b9745030d3b3c983518aa8 (diff) | |
download | jquery-eed69eccc54d010889b5d8495320538d7ceb4e51.tar.gz jquery-eed69eccc54d010889b5d8495320538d7ceb4e51.zip |
Make sure that jQuery.data( elem ) always returns a data object, fixes #5971. Improve the performance of .bind() and .unbind(), fixes #5972.
Diffstat (limited to 'src/data.js')
-rw-r--r-- | src/data.js | 17 |
1 files changed, 7 insertions, 10 deletions
diff --git a/src/data.js b/src/data.js index e3dc1902a..0049a9f4e 100644 --- a/src/data.js +++ b/src/data.js @@ -1,5 +1,4 @@ var expando = "jQuery" + now(), uuid = 0, windowData = {}; -var emptyObject = {}; jQuery.extend({ cache: {}, @@ -25,8 +24,7 @@ jQuery.extend({ var id = elem[ expando ], cache = jQuery.cache, thisCache; - // Handle the case where there's no name immediately - if ( !name && !id ) { + if ( !id && typeof name === "string" && data === undefined ) { return null; } @@ -40,17 +38,16 @@ jQuery.extend({ if ( typeof name === "object" ) { elem[ expando ] = id; thisCache = cache[ id ] = jQuery.extend(true, {}, name); - } else if ( cache[ id ] ) { - thisCache = cache[ id ]; - } else if ( typeof data === "undefined" ) { - thisCache = emptyObject; - } else { - thisCache = cache[ id ] = {}; + + } else if ( !cache[ id ] ) { + elem[ expando ] = id; + cache[ id ] = {}; } + thisCache = cache[ id ]; + // Prevent overriding the named cache with undefined values if ( data !== undefined ) { - elem[ expando ] = id; thisCache[ name ] = data; } |