diff options
author | ruado1987 <ruado1987@gmail.com> | 2013-03-03 23:51:04 +0800 |
---|---|---|
committer | Richard Gibson <richard.gibson@gmail.com> | 2013-03-22 12:47:01 -0400 |
commit | c9ca9bf509edd1dc0a92564210f3f325cc7555b6 (patch) | |
tree | ec65a79d92178d9fbaf6706c9299727326a055d1 /src | |
parent | 8f4572406c8d885de9fb236ae3fb1c9d4833cbee (diff) | |
download | jquery-c9ca9bf509edd1dc0a92564210f3f325cc7555b6.tar.gz jquery-c9ca9bf509edd1dc0a92564210f3f325cc7555b6.zip |
Fix #13514: Set selectedIndex to -1 when non-matching value is set on a select. Close gh-1191.
(cherry picked from commit 48d71d0c3e53d1bb1688fc6c0593b008ced3403b)
Diffstat (limited to 'src')
-rw-r--r-- | src/attributes.js | 21 |
1 files changed, 14 insertions, 7 deletions
diff --git a/src/attributes.js b/src/attributes.js index c9e7dbc47..37addf4a2 100644 --- a/src/attributes.js +++ b/src/attributes.js @@ -272,13 +272,20 @@ jQuery.extend({ }, set: function( elem, value ) { - var values = jQuery.makeArray( value ); - - jQuery(elem).find("option").each(function() { - this.selected = jQuery.inArray( jQuery(this).val(), values ) >= 0; - }); - - if ( !values.length ) { + var optionSet, option, + options = elem.options, + values = jQuery.makeArray( value ), + i = options.length; + + while ( i-- ) { + option = options[ i ]; + if ( (option.selected = jQuery.inArray( jQuery(option).val(), values ) >= 0) ) { + optionSet = true; + } + } + + // force browsers to behave consistently when non-matching value is set + if ( !optionSet ) { elem.selectedIndex = -1; } return values; |