diff options
author | Michał Gołębiowski <m.goleb@gmail.com> | 2013-11-11 01:53:23 +0100 |
---|---|---|
committer | Michał Gołębiowski <m.goleb@gmail.com> | 2013-11-11 18:20:33 +0100 |
commit | 07c374745790bf9e05ca58ffe97f0b72ae930e66 (patch) | |
tree | 4380d1e62ac739c6ccb8ca49fae1d5e1cd88be0a /src | |
parent | 4b39a8289031bb7de25e9f018d9fd8235a35ec49 (diff) | |
download | jquery-07c374745790bf9e05ca58ffe97f0b72ae930e66.tar.gz jquery-07c374745790bf9e05ca58ffe97f0b72ae930e66.zip |
No ticket. Remove the unnecessary guard in addGetHookIf. Close gh-1426.
In 1.x if the support test executes before doc ready, it may not be able
to return a result yet. In such a case, we protect ourselves from future
breakages, allowing only for the ones before doc ready.
Since in 2.x lazy support tests attach test elements to docElem, not body,
such a guard is unnecessary.
Diffstat (limited to 'src')
-rw-r--r-- | src/css/addGetHookIf.js | 10 |
1 files changed, 1 insertions, 9 deletions
diff --git a/src/css/addGetHookIf.js b/src/css/addGetHookIf.js index 7efcbc860..81d694cb0 100644 --- a/src/css/addGetHookIf.js +++ b/src/css/addGetHookIf.js @@ -4,15 +4,7 @@ function addGetHookIf( conditionFn, hookFn ) { // Define the hook, we'll check on the first run if it's really needed. return { get: function() { - var condition = conditionFn(); - - if ( condition == null ) { - // The test was not ready at this point; screw the hook this time - // but check again when needed next time. - return; - } - - if ( condition ) { + if ( conditionFn() ) { // Hook not needed (or it's not possible to use it due to missing dependency), // remove it. // Since there are no other hooks for marginRight, remove the whole object. |