diff options
| author | Colin Snover <github.com@zetafleet.com> | 2010-10-08 20:29:41 -0500 |
|---|---|---|
| committer | Colin Snover <github.com@zetafleet.com> | 2010-10-08 20:29:41 -0500 |
| commit | 543db64412b37b5fa1f3d7fea19f62d6db993fb0 (patch) | |
| tree | 3d2e1ef8144d926fb17bf03f2a3536662b64f10f /test/unit/effects.js | |
| parent | 91028794d5029365eca0c3d40cfdae016403cbe6 (diff) | |
| download | jquery-543db64412b37b5fa1f3d7fea19f62d6db993fb0.tar.gz jquery-543db64412b37b5fa1f3d7fea19f62d6db993fb0.zip | |
Fixed code convention issues. Reduced size of overflow reset code. Fixed broken show() test cases.
Diffstat (limited to 'test/unit/effects.js')
| -rw-r--r-- | test/unit/effects.js | 17 |
1 files changed, 8 insertions, 9 deletions
diff --git a/test/unit/effects.js b/test/unit/effects.js index dd95d1ba6..3c4015aff 100644 --- a/test/unit/effects.js +++ b/test/unit/effects.js @@ -38,9 +38,10 @@ test("show()", function() { }); // #show-tests * is set display: none in CSS - jQuery("#main").append('<div id="show-tests"><div><p><a href="#"></a></p><code></code><pre></pre><span></span></div><table><thead><tr><th></th></tr></thead><tbody><tr><td></td></tr></tbody></table><ul><li></li></ul></div>'); - - var old = jQuery("#show-tests table").show().css("display") !== "table"; + jQuery("#main").append('<div id="show-tests"><div><p><a href="#"></a></p><code></code><pre></pre><span></span></div><table><thead><tr><th></th></tr></thead><tbody><tr><td></td></tr></tbody></table><ul><li></li></ul></div><table id="test-table"></table>'); + + var old = jQuery("#test-table").show().css("display") !== "table"; + jQuery("#test-table").remove(); var test = { "div" : "block", @@ -71,10 +72,11 @@ test("show(Number) - other displays", function() { stop(); // #show-tests * is set display: none in CSS - jQuery("#main").append('<div id="show-tests"><div><p><a href="#"></a></p><code></code><pre></pre><span></span></div><table><thead><tr><th></th></tr></thead><tbody><tr><td></td></tr></tbody></table><ul><li></li></ul></div>'); + jQuery("#main").append('<div id="show-tests"><div><p><a href="#"></a></p><code></code><pre></pre><span></span></div><table><thead><tr><th></th></tr></thead><tbody><tr><td></td></tr></tbody></table><ul><li></li></ul></div><table id="test-table"></table>'); - var old = jQuery("#show-tests table").show().css("display") !== "table", + var old = jQuery("#test-table").show().css("display") !== "table", num = 0; + jQuery("#test-table").remove(); var test = { "div" : "block", @@ -94,10 +96,7 @@ test("show(Number) - other displays", function() { }; jQuery.each(test, function(selector, expected) { - // IE sometimes has issues with chained functions referencing - // assignments from outside the closure - var elem = jQuery(selector, "#show-tests"); - elem.show(1, function() { + var elem = jQuery(selector, "#show-tests").show(1, function() { equals( elem.css("display"), expected, "Show using correct display type for " + selector ); if ( ++num === 15 ) { start(); |