diff options
| author | Timmy Willison <timmywillisn@gmail.com> | 2015-06-15 11:02:08 -0400 |
|---|---|---|
| committer | Timmy Willison <timmywillisn@gmail.com> | 2015-06-16 10:55:51 -0400 |
| commit | 63f19a95b9bfffdc7b8800f89a9def768cc3aebd (patch) | |
| tree | bcd8a40dc5f158dbf0acb8cd734f5ed9f15127a6 /test/unit | |
| parent | ee69e9c8b8a5b832f2feaf1751ecd804df2d240a (diff) | |
| download | jquery-63f19a95b9bfffdc7b8800f89a9def768cc3aebd.tar.gz jquery-63f19a95b9bfffdc7b8800f89a9def768cc3aebd.zip | |
Offset: return zeros for disconnected/hidden elements
Fixes gh-2310
Close gh-2396
Diffstat (limited to 'test/unit')
| -rw-r--r-- | test/unit/offset.js | 22 |
1 files changed, 8 insertions, 14 deletions
diff --git a/test/unit/offset.js b/test/unit/offset.js index b6ec93de6..d549f35b1 100644 --- a/test/unit/offset.js +++ b/test/unit/offset.js @@ -49,30 +49,24 @@ test("empty set", function() { }); test("disconnected element", function() { - expect(1); - - var result; + expect( 2 ); - try { - result = jQuery( document.createElement("div") ).offset(); - } catch ( e ) {} + var result = jQuery( document.createElement( "div" ) ).offset(); - ok( !result, "no position for disconnected element" ); + equal( result.top, 0, "Retrieving offset on disconnected elements returns zeros (gh-2310)" ); + equal( result.left, 0, "Retrieving offset on disconnected elements returns zeros (gh-2310)" ); }); test("hidden (display: none) element", function() { - expect(1); - - var result, - node = jQuery("<div style='display: none' />").appendTo("#qunit-fixture"); + expect( 2 ); - try { + var node = jQuery("<div style='display: none' />").appendTo("#qunit-fixture"), result = node.offset(); - } catch ( e ) {} node.remove(); - ok( !result, "no position for hidden (display: none) element" ); + equal( result.top, 0, "Retrieving offset on hidden elements returns zeros (gh-2310)" ); + equal( result.left, 0, "Retrieving offset on hidden elements returns zeros (gh-2310)" ); }); testIframe("offset/absolute", "absolute", function($, iframe) { |