aboutsummaryrefslogtreecommitdiffstats
path: root/src/effects.js
diff options
context:
space:
mode:
Diffstat (limited to 'src/effects.js')
-rw-r--r--src/effects.js39
1 files changed, 27 insertions, 12 deletions
diff --git a/src/effects.js b/src/effects.js
index 4823659c2..8fa2e56e6 100644
--- a/src/effects.js
+++ b/src/effects.js
@@ -315,12 +315,19 @@ function Animation( elem, properties, options ) {
deferred.notifyWith( elem, [ animation, percent, remaining ] );
+ // If there's more to do, yield
if ( percent < 1 && length ) {
return remaining;
- } else {
- deferred.resolveWith( elem, [ animation ] );
- return false;
}
+
+ // If this was an empty animation, synthesize a final progress notification
+ if ( !length ) {
+ deferred.notifyWith( elem, [ animation, 1, 0 ] );
+ }
+
+ // Resolve the animation and report its conclusion
+ deferred.resolveWith( elem, [ animation ] );
+ return false;
},
animation = deferred.promise( {
elem: elem,
@@ -385,6 +392,13 @@ function Animation( elem, properties, options ) {
animation.opts.start.call( elem, animation );
}
+ // Attach callbacks from options
+ animation
+ .progress( animation.opts.progress )
+ .done( animation.opts.done, animation.opts.complete )
+ .fail( animation.opts.fail )
+ .always( animation.opts.always );
+
jQuery.fx.timer(
jQuery.extend( tick, {
elem: elem,
@@ -393,11 +407,7 @@ function Animation( elem, properties, options ) {
} )
);
- // attach callbacks from options
- return animation.progress( animation.opts.progress )
- .done( animation.opts.done, animation.opts.complete )
- .fail( animation.opts.fail )
- .always( animation.opts.always );
+ return animation;
}
jQuery.Animation = jQuery.extend( Animation, {
@@ -641,7 +651,7 @@ jQuery.fx.tick = function() {
for ( ; i < timers.length; i++ ) {
timer = timers[ i ];
- // Checks the timer has not already been removed
+ // Run the timer and safely remove it when done (allowing for external removal)
if ( !timer() && timers[ i ] === timer ) {
timers.splice( i--, 1 );
}
@@ -654,11 +664,16 @@ jQuery.fx.tick = function() {
};
jQuery.fx.timer = function( timer ) {
- jQuery.timers.push( timer );
+ var i = jQuery.timers.push( timer ) - 1,
+ timers = jQuery.timers;
+
if ( timer() ) {
jQuery.fx.start();
- } else {
- jQuery.timers.pop();
+
+ // If the timer finished immediately, safely remove it (allowing for external removal)
+ // Use a superfluous post-decrement for better compressibility w.r.t. jQuery.fx.tick above
+ } else if ( timers[ i ] === timer ) {
+ timers.splice( i--, 1 );
}
};