aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Release: migrate release process to release-itTimmy Willison2024-07-2935-650/+4715
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | *Authors* - Checking and updating authors has been migrated to a custom script in the repo *Changelog* - changelogplease is no longer maintained - generate changelog in markdown for GitHub releases - generate changelog in HTML for blog posts - generate contributors list in HTML for blog posts *dist* - clone dist repo, copy files, and commit/push - commit tag with dist files on main branch; remove dist files from main branch after release *cdn* - clone cdn repo, copy files, and commit/push - create versioned and unversioned copies in cdn/ - generate md5 sums and archives for Google and MSFT *build* - implement reproducible builds and verify release builds * uses the last modified date for the latest commit * See https://reproducible-builds.org/ - the verify workflow also ensures all files were properly published to the CDN and npm *docs* - the new release workflow is documented at build/release/README.md *verify* - use the last modified date of the commit before the tag - use versioned filenames when checking map files on the CDN - skip factory and package.json files when verifying CDN *misc* - now that we don't need the jquery-release script and now that we no longer need to build on Node 10, we can use ESM in all files in the build folder - limit certain workflows to the main repo (not forks) - version has been set to the previously released version 3.7.1, as release-it expects - release-it added the `preReleaseBase` option and we now always set it to `1` in the npm script. This is a noop for stable releases. - include post-release script to be run manually after a release, with further steps that should be verified manually Ref jquery/jquery-release#114 Closes gh-5522
* Build: Bump the github-actions group with 1 updatedependabot[bot]2024-07-054-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | Bumps the github-actions group with 1 update: [actions/checkout](https://github.com/actions/checkout). Updates `actions/checkout` from 4.1.6 to 4.1.7 - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](https://github.com/actions/checkout/compare/a5ac7e51b41094c92402da3b24376905380afc29...692973e3d937129bcbf40652eb9f2f61becf3332) Closes gh-5515 --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-patch dependency-group: github-actions ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (cherry picked from commit 3a98ef91dfa0b4897df7562f40bfd1715f5fc30e)
* Build: upgrade dependencies, including eslint 9.4.0 and uglify 3.7.7Timmy Willison2024-06-1520-632/+503
| | | | | | | | | | | | | - Sinon is already at the latest version that supports IE9. - Upgraded uglify to 3.7.7, which is the latest that worked with IE9. I tried 3.9.4, which we are using in jquery-migrate, and 3.8.1, but there were failures in traversing ("Permission denied" errors). - Upgraded eslint to version 9, which required some changes. Mainly, unused arguments in catch expressions error by default in 9+. The config now makes use of `caughtErrorsIgnorePattern`, which is set to `"^_"`, the same as unused function params. - Ignored main branch dist files when switching branches. Closes gh-5508
* Tests: fix supportsScroll feature test in offsetTimmy Willison2024-06-101-9/+10
| | | | | | | | | | | - iOS 12 and below do not support scrollTop/Left on the window or document. Before 82169df, window.supportsScroll was always undefined. There were 2 issues: (1) iOS <=12 do support scroll props on the body, so the support test wasn't helpful. (2) one test checked the wrong window and the value was always undefined, which meant those tests never ran in any browser. Closes gh-5506
* Build: improve specificity of eslint config; add ecma versionsTimmy Willison2024-06-1015-117/+125
| | | | | | - also added no-implicit-globals rule outside of tests, but including dist Close gh-5504
* Build: Bump the github-actions group with 2 updatesdependabot[bot]2024-06-064-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bumps the github-actions group with 2 updates: [actions/checkout](https://github.com/actions/checkout) and [github/codeql-action](https://github.com/github/codeql-action). Updates `actions/checkout` from 4.1.2 to 4.1.6 - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](https://github.com/actions/checkout/compare/9bb56186c3b09b4f86b1c65136769dd318469633...a5ac7e51b41094c92402da3b24376905380afc29) Updates `github/codeql-action` from 3.24.9 to 3.25.8 - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](https://github.com/github/codeql-action/compare/1b1aada464948af03b950897e5eb522f92603cc2...2e230e8fe0ad3a14a340ad0815ddb96d599d2aff) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-patch dependency-group: github-actions - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-minor dependency-group: github-actions ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Closes gh-5505 (cherry picked from commit 46b9e4803ec3506e830ea6b49541ea29717ed460)
* Build: Group dependabot PRs updating GitHub ActionsMichał Gołębiowski-Owczarek2024-06-061-0/+7
| | | | | | | | | | | | | | We have monthly automatic dependabot PRs for GitHub Actions. Unfortunately, as of now we get a separate PR for every dependency which is a bit spammy compared to regular commits updating source. Thankfully, there's now a way to tell dependabot to submit a single PR per a defined group. This change defines a single group to have a single dependabot PR for all action updates. Closes gh-5503 (cherry picked from commit 3cac1465b4b5539bb679a517fbb52e5419c1866e)
* CSS:Tests: Fix tests & support tests under CSS Zoom (3.x version)Michał Gołębiowski-Owczarek2024-06-034-5/+61
| | | | | | | | | | | | | | | | Firefox 126+ implements CSS zoom in a way it affects width computed style very slightly (`100.008px` instead of `100px`); accept that difference. Also, skip the width setter under zoom test in Firefox 126 completely - that version has CSS zoom affecting `offsetWidth` values. This has been fixed in Firefox 127 so it's not worth working around it. Add a test for support tests resolving the same under CSS zoom & without one. That test uncovered Chrome failing the `reliableTrDimensions` support test under zoom; the test has been fixed. Fixes gh-5489 Closes gh-5496 Ref gh-5495
* Tests: Make `:has` selector tests not vulnerable to unrelated failuresMichał Gołębiowski-Owczarek2024-05-291-6/+6
| | | | | | | Use `assert.selectInFixture` consistently in `:has` tests. Previously, any test failure that happened before this test run made it fail due to an additional paragraph with id `qunit-testresult` injected by QUnit. Closes gh-5497
* Tests: revert concurrency group changeTimmy Willison2024-05-291-1/+1
| | | | | | | | | - It's common for us to merge to main and cherry pick to 3.x-stable, so it's best if concurrency is shared between branches, which is effectively what we had already as it matches on workflow name and browser. Ideally, it could also match on the corresponding commit, but it seems the commit message is not available in the github context. Close gh-5493
* Event: Increase robustness of an inner native event in leverageNativeMichał Gołębiowski-Owczarek2024-05-202-18/+97
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In Firefox, alert displayed just before blurring an element dispatches the native blur event twice which tripped the jQuery logic if a jQuery blur handler was not attached before the trigger call. This was because the `leverageNative` logic part for triggering first checked if setup was done before (which, for example, is done if a jQuery handler was registered before for this element+event pair) and - if it was not - added a dummy handler that just returned `true`. The `leverageNative` logic made that `true` then saved into private data, replacing the previous `saved` array. Since `true` passed the truthy check, the second native inner handler treated `true` as an array, crashing on the `slice` call. The same issue could happen if a handler returning `true` is attached before triggering. A bare `length` check would not be enough as the user handler may return an array-like as well. To remove this potential data shape clash, capture the inner result in an object with a `value` property instead of saving it directly. Since it's impossible to call `alert()` in unit tests, simulate the issue by replacing the `addEventListener` method on a test button with a version that calls attached blur handlers twice. Fixes gh-5459 Closes gh-5466 Ref gh-5236 (cherry picked from commit 527fb3dcf0dcde69302a741dfc61cbfa58e99eb0)
* Tests: include github ref in concurrency groupTimmy Willison2024-04-251-1/+1
| | | | | | - fixes cancelled workflows when multiple PRs are merged in quick succession to both the main and 3.x-stable branches Close gh-5482
* Tests: Make the beforeunload event tests work regardless of extensionsMichał Gołębiowski-Owczarek2024-04-252-10/+20
| | | | | | | | | | | | | | Some browser extensions, like React DevTools, send messages to the content area. Since our beforeunload event test listens for all messages, it used to catch those as well, failing the test. Add a `source` field to the payload JSON and check for it before treating the message as coming from our own test to make sure the test passes even with such browser extensions installed. Closes gh-5478 (cherry picked from commit 399a78ee9fc5802509df462a2851aef1b60b7fbc)
* Docs: Update remaining HTTP URLs to HTTPSMichał Gołębiowski-Owczarek2024-04-252-2/+2
| | | | | | | | | Update a few remaining HTTP URLs to HTTPS. The only ones left are XMLNS-like URLs or ones to localhost - those need to stay as-is. Closes gh-5479 (cherry picked from commit 7cdd8374234b77a3c70dd511a1b06066afb146bb)
* Build: Bump actions/cache & actions/checkoutdependabot[bot]2024-04-024-9/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1. Bump actions/cache from 4.0.1 to 4.0.2 Bumps [actions/cache](https://github.com/actions/cache) from 4.0.1 to 4.0.2. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](https://github.com/actions/cache/compare/ab5e6d0c87105b4c9c2047343972218f562e4319...0c45773b623bea8c8e75f6c82b208c3cf94ea4f9) --- updated-dependencies: - dependency-name: actions/cache dependency-type: direct:production update-type: version-update:semver-patch ... 2. Bump actions/checkout from 4.1.1 to 4.1.2 Bumps [actions/checkout](https://github.com/actions/checkout) from 4.1.1 to 4.1.2. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](https://github.com/actions/checkout/compare/b4ffde65f46336ab88eb53be808477a3936bae11...9bb56186c3b09b4f86b1c65136769dd318469633) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-patch ... Closes gh-5462 Signed-off-by: dependabot[bot] <support@github.com> (partially cherry picked from commit df1df9503afad78bec3ba5217f9a9efce49fe634)
* Tests: share queue/browser handling for all worker typesTimmy Willison2024-04-0113-446/+336
| | | | | | | - one queue to rule them all: browserstack, selenium, and jsdom - retries and hard retries are now supported in selenium - selenium tests now re-use browsers in the same way as browserstack Close gh-5465
* Tests: improve diffing for values of different typesTimmy Willison2024-03-272-26/+58
| | | | | Close gh-5455 Co-authored-by: Richard Gibson <richard.gibson@gmail.com>
* Build: Bump actions/cache from 4.0.0 to 4.0.1dependabot[bot]2024-03-203-4/+4
| | | | | | | | | | | | | | | | | | | | | Bumps [actions/cache](https://github.com/actions/cache) from 4.0.0 to 4.0.1. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](https://github.com/actions/cache/compare/13aacd865c20de90d75de3b17ebe84f7a17d57d2...ab5e6d0c87105b4c9c2047343972218f562e4319) --- updated-dependencies: - dependency-name: actions/cache dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Close gh-5424 (cherry picked from commit 68f772e003ee0f39cf0f755070fb4e9ec9e90973)
* Tests: show any and all actual/expected valuesTimmy Willison2024-03-151-2/+11
| | | Close gh-5449
* Tests: add diffing to test reporterTimmy Willison2024-03-143-5/+63
| | | Close gh-5446
* Tests: add actual and expected messages to test reporterTimmy Willison2024-03-141-12/+12
| | | Close gh-5444
* Tests: fix worker restarts for failed browser acknowledgementsTimmy Willison2024-03-111-1/+1
| | | | Close gh-5441
* Build: make compare size cache readable for manual editsTimmy Willison2024-03-111-1/+3
| | | | Ref gh-5441
* Build: fix size comparison for slim files when the branch is dirtyTimmy Willison2024-03-111-1/+1
| | | | Ref gh-5441
* Build: migrate more uses of fs.promises; use node: protocolTimmy Willison2024-03-1112-58/+76
| | | | Ref gh-5441
* Tests: add --hard-retries option to test runnerTimmy Willison2024-03-116-38/+94
| | | | | | | | - Add the ability to retry by restarting the worker and getting a different browser instance, after all normal retries have been exhausted. This can sometimes be successful when a refresh is not. Close gh-5439
* Tests: fix cleanup in cases where server doesn't stopTimmy Willison2024-03-091-4/+4
|
* Build: drop support for Node 10Timmy Willison2024-03-096-263/+140
| | | | Close gh-5437
* Build: add GitHub Actions workflow to update FilestashTimmy Willison2024-03-081-0/+56
| | | Close gh-5435
* Tests: fix flakey message logs; ignore delete worker failuresTimmy Willison2024-03-053-20/+29
| | | Close gh-5431
* Tests: migrate testing infrastructure to minimal dependenciesTimmy Willison2024-03-0553-14831/+14376
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a complete rework of our testing infrastructure. The main goal is to modernize and drop deprecated or undermaintained dependencies (specifically, grunt, karma, and testswarm). We've achieved that by limiting our dependency list to ones that are unlikely to drop support any time soon. The new dependency list includes: - `qunit` (our trusty unit testing library) - `selenium-webdriver` (for spinning up local browsers) - `express` (for starting a test server and adding middleware) - express middleware includes uses of `body-parser` and `raw-body` - `yargs` (for constructing a CLI with pretty help text) - BrowserStack (for running each of our QUnit modules separately in all of our supported browsers) - `browserstack-local` (for opening a local tunnel. This is the same package still currently used in the new Browserstack SDK) - We are not using any other BrowserStack library. The newest BrowserStack SDK does not fit our needs (and isn't open source). Existing libraries, such as `node-browserstack` or `browserstack-runner`, either do not quite fit our needs, are under-maintained and out-of-date, or are not robust enough to meet all of our requirements. We instead call the [BrowserStack REST API](https://github.com/browserstack/api) directly. **BrowserStack** - automatically retries individual modules in case of test failure(s) - automatically attempts to re-establish broken tunnels - automatically refreshes the page in case a test run has stalled - Browser workers are reused when running isolated modules in the same browser - runs all browsers concurrently and uses as many sessions as are available under the BrowserStack plan. It will wait for available sessions if there are none. - supports filtering the available list of browsers by browser name, browser version, device, OS, and OS version (see `npm run test:unit -- --list-browsers` for more info). It will retrieve the latest matching browser available if any of those parameters are not specified. Supports latest and latest-\d+ in place of browser version. - cleans up after itself (closes the local tunnel, stops the test server, etc.) - Requires `BROWSERSTACK_USERNAME` and `BROWSERSTACK_ACCESS_KEY` environment variables. **Selenium** - supports running any local browser as long as the driver is installed, including support for headless mode in Chrome, FF, and Edge - supports running `basic` tests on the latest [jsdom](https://github.com/jsdom/jsdom#readme), which can be seen in action in this PR (see `test:browserless`) - Node tests will run as before in PRs and all non-dependabot branches, but now includes tests on real Safari in a GH actions macos image instead of playwright-webkit. - can run multiple browsers and multiple modules concurrently Other notes: - Stale dependencies have been removed and all remaining dependencies have been upgraded with a few exceptions: - `sinon`: stopped supporting IE in version 10. But, `sinon` has been updated to 9.x. - `husky`: latest does not support Node 10 and runs on `npm install`. Needed for now until git builds are migrated to GitHub Actions. - `rollup`: latest does not support Node 10. Needed for now until git builds are migrated to GitHub Actions. - BrowserStack tests are set to run on each `main` branch commit - `debug` mode leaves Selenium browsers open whether they pass or fail and leaves browsers with test failures open on BrowserStack. The latter is to avoid leaving open too many sessions. - This PR includes a workflow to dispatch BrowserStack runs on-demand - The Node version used for most workflow tests has been upgraded to 20.x - updated supportjQuery to 3.7.1 Run `npm run test:unit -- --help` for CLI documentation Close gh-5427
* Build: Bump actions/cache from 3.3.2 to 4.0.0dependabot[bot]2024-02-111-1/+1
| | | | | | | | | | | | | | | | | | | | Bumps [actions/cache](https://github.com/actions/cache) from 3.3.2 to 4.0.0. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](https://github.com/actions/cache/compare/704facf57e6136b1bc63b828d79edcd491f0ee84...13aacd865c20de90d75de3b17ebe84f7a17d57d2) --- updated-dependencies: - dependency-name: actions/cache dependency-type: direct:production update-type: version-update:semver-major ... Closes gh-5402 Signed-off-by: dependabot[bot] <support@github.com> (cherry picked from commit bf11739f6c6926bc9bc1b5a1460505d3b7ef8b01)
* Tests: Align `middleware-mockerver.js` with the `main` branchMichał Gołębiowski-Owczarek2024-02-091-7/+1
| | | | | | | Remove a redundant Express-targeted `resp.set` call from the `script` handler in `middleware-mockserver.js` as was done on the `main` branch. Closes gh-5413 Ref gh-5397
* Release: use buildDefaultFiles directly and pass version (#5409)Timmy Willison2024-02-064-4/+8
| | | | | | | - also add the ability to pass VERSION in env to test final builds - adjust sha regex to account for lack of shas - set the version on the dist package.json Close gh-5408
* Release: remove scripts and dev deps from dist package.jsonTimmy Willison2024-02-051-2/+14
| | | | | | - this became necessary due to the addition of the prepare script - scripts aren't needed and don't work in the dist repo Close gh-5405
* Release: update build command in Release.generateArtifactsTimmy Willison2024-01-311-1/+1
| | | Close gh-5400
* Build: migrate grunt authors to a custom scriptTimmy Willison2024-01-225-26/+130
| | | | | | - the new script pulls all authors from the Sizzle repo - added temporary grunt task for releases Close gh-5396
* Manipulation: Generalize a test to support IERichard Gibson2024-01-131-3/+17
| | | | | | | Ref gh-5378 Closes gh-5391 (cherry picked from commit 88690ebfc8b5ef8b1e444326c664b590ecc0b888)
* Build: Bump follow-redirects from 1.15.1 to 1.15.4dependabot[bot]2024-01-121-3/+3
| | | | | | | | | | | | | | | | | | Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.1 to 1.15.4. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.15.1...v1.15.4) Closes gh-5389 --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (cherry picked from commit 56139394705022e4f6756440030ad6f3bf35f5a6)
* Manipulation: Support $el.html(selfRemovingScript)Richard Gibson2024-01-082-1/+18
| | | | | | | | | Don't try to remove a script element that has already removed itself. Fixes gh-5377 Closes gh-5378 (cherry-picked from commit 937923d9ee8dfd19008447b5059cbd13ee5a23ac)
* Build: Bump @babel/traverse & multiple actionsMichał Gołębiowski-Owczarek2023-11-132-635/+1229
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1: Bump actions/cache from 3.3.1 to 3.3.2 Bumps [actions/cache](https://github.com/actions/cache) from 3.3.1 to 3.3.2. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](https://github.com/actions/cache/compare/88522ab9f39a2ea568f7027eddc7d8d8bc9d59c8...704facf57e6136b1bc63b828d79edcd491f0ee84) --- updated-dependencies: - dependency-name: actions/cache dependency-type: direct:production update-type: version-update:semver-patch ... 2: Bump actions/checkout from 3.6.0 to 4.1.1 Bumps [actions/checkout](https://github.com/actions/checkout) from 3.6.0 to 4.1.1. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](https://github.com/actions/checkout/compare/f43a0e5ff2bd294095638e18286ca9a3d1956744...b4ffde65f46336ab88eb53be808477a3936bae11) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... 3: Bump actions/setup-node from 3.8.1 to 4.0.0 Bumps [actions/setup-node](https://github.com/actions/setup-node) from 3.8.1 to 4.0.0. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](https://github.com/actions/setup-node/compare/5e21ff4d9bc1a8cf6de233a3057d20ec6b3fb69d...8f152de45cc393bb48ce5d89d36b731f54556e65) --- updated-dependencies: - dependency-name: actions/setup-node dependency-type: direct:production update-type: version-update:semver-major ... 5: Bump @babel/traverse from 7.22.5 to 7.23.2 Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.22.5 to 7.23.2. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.23.2/packages/babel-traverse) --- updated-dependencies: - dependency-name: "@babel/traverse" dependency-type: indirect ... Closes gh-5341 Closes gh-5349 Closes gh-5354 Closes gh-5356 Closes gh-5363 Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Build: Don't run CI push workflows for dependabot branchesMichał Gołębiowski-Owczarek2023-11-131-1/+4
| | | | | | | | | Without this change, dependabot PRs run double checks - one set for the `push` part and one for the `pull_request` part. Closes gh-5353 (cherry picked from commit 635cb152e7daac658223455aaab2f81204b5b215)
* Tests: Workaround a tr width test issue in old iOSMichał Gołębiowski-Owczarek2023-11-131-3/+7
| | | | | | | Old iOS (<10) always rounds widths down, account for this in tests. Closes gh-5361 Ref gh-5317 Ref gh-5359
* CSS: Fix reliableTrDimensions test for initially hidden iframes (3.x)Michał Gołębiowski-Owczarek2023-11-074-16/+63
| | | | | | | | Also, account for the fact old Firefox (<61) has `null` computed style for elements in such iframes. Closes gh-5359 Ref gh-5317 Ref gh-5358
* CSS: Fix support test results for initially hidden iframesStephen Sigwart2023-11-024-1/+52
| | | | | | | | | | If the iframe is not initially visible, the `scrollboxSize` support test is failing. jQuery then cached this value and and applied the wrong result undefinitely. This breaks jQuery UI's Dialogs inside initially invisible iframes. Closes gh-5317 Ref jquery/jquery-ui#2176
* Build: Update ESLint-related packages, fix linting errors (3.x version)Michał Gołębiowski-Owczarek2023-11-029-34/+36
| | | | | | | | The main change is the new rule in `eslint-config-jquery`: `template-curly-spacing`. Closes gh-5348 Ref jquery/eslint-config-jquery#21 Ref gh-5347
* Build: Run pretest before test:* npm scriptsMichał Gołębiowski-Owczarek2023-10-162-11/+8
| | | | | | | | | | | | | | | | Build was already happening in scripts like `test:browser` but those scripts were missing `pretest`, meaning that running `npm install && npm test:browser` may have failed if `pretest` wasn't run before or if its results were out of date. Even worse, with such stale data some tests may erroneously succeed. This also removes a separate `pretest` step from GitHub Actions as it's no longer needed. Closes gh-5338 (cherry picked from commit 1ad66aeb6d7d94f8e4c8e2286569722ca41f9868)
* Build: sort branches in compare_size; last run lastTimmy Willison2023-09-211-3/+20
| | | Close gh-5334
* Build: migrate most grunt tasks off of grunt (3.x)Timmy Willison2023-09-2073-34994/+9307
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Close gh-5330 - lint - npmcopy - build, minify, and process for distribution. - new custom build command using yargs - compare size of minified/gzip built files - pretest scripts, including qunit-fixture, babel transpilation, and npmcopy - node smoke tests - promises aplus tests - new watch task using nodemon, which runs `npm run build:all` on `src` changes. Also: - upgraded husky and added the new lint command - updated lint config to use new "flat" config format. See https://eslint.org/docs/latest/use/configure/configuration-files-new - Temporarily disabled one lint rule until flat config is supported by eslint-plugin-import. See https://github.com/import-js/eslint-plugin-import/issues/2556 - committed package-lock.json - updated all test scripts to use the new build - added an express test server that uses middleware-mockserver this can be used to run tests without karma - build-all-variants is now build:all - run pretest script in jenkins --------- Co-authored-by: Michał Gołębiowski-Owczarek <m.goleb@gmail.com>
* Core: Simplify code post browser support reductionMichał Gołębiowski-Owczarek2023-09-2010-159/+100
| | | | | | | | | | | | | | | | | | | Summary of the changes: * Tests: Remove legacy jQuery.cache & oldIE leftovers * Tests: Reformat JavaScript in delegatetest.html * Docs: "jQuery Foundation Projects" -> "jQuery Projects" * Tests: Drop an unused localfile.html file (modern browsers don't support the `file:` protocol this way, there's no point in keeping the file around) * Effects: Remove a redundant `!fn` check (`fn || !fn && easing` is equivalent to `fn || easing`; simplify the code) * CSS: Explain the fallback to direct object access in curCSS better * Tests: Deduplicate `jQuery.parseHTML` test titles * Dimensions: Add a test for fractional values * Tests: Fix a buggy WebKit regex Closes gh-5296 (cherry picked from commit 93ca49e6d1ac23fee33b3bc3b7f4d93dd1a25cb7)