From 6d761984ebed761b1dca7d95330f990fb3f3ced3 Mon Sep 17 00:00:00 2001 From: "S. Andrew Sheppard" Date: Thu, 9 Jan 2014 15:27:18 -0600 Subject: AMD: Note on AMD best practices Fixes #14687 Closes gh-1478 (cherry picked from commit 19220c0f29fa60d80a2beb76f048ffc8b972ba35) Conflicts: AUTHORS.txt --- AUTHORS.txt | 1 + src/exports/amd.js | 6 ++++++ 2 files changed, 7 insertions(+) diff --git a/AUTHORS.txt b/AUTHORS.txt index 0cee820c5..07fb5710d 100644 --- a/AUTHORS.txt +++ b/AUTHORS.txt @@ -206,3 +206,4 @@ Jakob Stoeck cjqed Forbes Lindesay John Paul +S. Andrew Sheppard diff --git a/src/exports/amd.js b/src/exports/amd.js index 815b5d88a..9a9846f9f 100644 --- a/src/exports/amd.js +++ b/src/exports/amd.js @@ -9,6 +9,12 @@ define([ // derived from file names, and jQuery is normally delivered in a lowercase // file name. Do this after creating the global so that if an AMD module wants // to call noConflict to hide this version of jQuery, it will work. + +// Note that for maximum portability, libraries that are not jQuery should +// declare themselves as anonymous modules, and avoid setting a global if an +// AMD loader is present. jQuery is a special case. For more information, see +// https://github.com/jrburke/requirejs/wiki/Updating-existing-libraries#wiki-anon + if ( typeof define === "function" && define.amd ) { define( "jquery", [], function() { return jQuery; -- cgit v1.2.3