From 438b1a3e8a52d3e4efd8aba45498477038849c97 Mon Sep 17 00:00:00 2001 From: Michał Gołębiowski-Owczarek Date: Mon, 13 May 2019 22:25:11 +0200 Subject: Build: ESLint: forbid unused function parameters This commit requires all function parameters to be used, not just the last one. In cases where that's not possible as we need to match an external API, there's an escape hatch of prefixing an unused argument with `_`. This change makes it easier to catch unused AMD dependencies and unused parameters in internal functions the API of which we may change at will, among other things. Unused AMD dependencies have been removed as part of this commit. Closes gh-4381 --- build/tasks/build.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'build/tasks/build.js') diff --git a/build/tasks/build.js b/build/tasks/build.js index b59ef816e..73dfd581d 100644 --- a/build/tasks/build.js +++ b/build/tasks/build.js @@ -372,7 +372,7 @@ module.exports = function( grunt ) { // Ask for permission the first time if ( insight.optOut === undefined ) { - insight.askPermission( null, function( error, result ) { + insight.askPermission( null, function( _error, result ) { exec( result ); } ); } else { -- cgit v1.2.3