From 56426261f0ee97d6d2f903d08b137a6f5f2c0916 Mon Sep 17 00:00:00 2001 From: Dave Methvin Date: Thu, 1 Mar 2012 22:31:17 -0500 Subject: Fix #11415: Stop non-negative prop undershoot on animation. This doesn't fix *all* of them (see the ticket for a supposedly complete list) but these were already handy so it was relatively cheap to fix them. If you need others fixed, add a custom step function as was done here. Thanks @scott_gonzalez! --- src/effects.js | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) (limited to 'src') diff --git a/src/effects.js b/src/effects.js index 1536d2d8e..790a63c8e 100644 --- a/src/effects.js +++ b/src/effects.js @@ -634,9 +634,8 @@ jQuery.extend( jQuery.fx, { } }); -// Adds width/height step functions -// Do not set anything below 0 -jQuery.each([ "width", "height" ], function( i, prop ) { +// Ensure props that can't be negative don't go there on undershoot easing +jQuery.each( fxAttrs.concat.apply( [], fxAttrs ), function( i, prop ) { jQuery.fx.step[ prop ] = function( fx ) { jQuery.style( fx.elem, prop, Math.max(0, fx.now) + fx.unit ); }; -- cgit v1.2.3