From 74978b7e892537559850cda7332bdab8106e6354 Mon Sep 17 00:00:00 2001 From: Michał Gołębiowski-Owczarek Date: Mon, 17 Oct 2022 18:54:28 +0200 Subject: Ajax: Support `null` as success functions in `jQuery.get` According to the docs, one can use `null` as a success function in `jQuery.get` of `jQuery.post` so the following: ```js await jQuery.get( "https://httpbin.org/json", null, "text" ) ``` should get the text result. However, this shortcut hasn't been working so far. Fixes gh-4989 Closes gh-5139 --- src/ajax.js | 5 +++-- src/ajax/xhr.js | 1 - 2 files changed, 3 insertions(+), 3 deletions(-) (limited to 'src') diff --git a/src/ajax.js b/src/ajax.js index dc9fb242b..36a9c9b57 100644 --- a/src/ajax.js +++ b/src/ajax.js @@ -846,8 +846,9 @@ jQuery.extend( { jQuery.each( [ "get", "post" ], function( _i, method ) { jQuery[ method ] = function( url, data, callback, type ) { - // Shift arguments if data argument was omitted - if ( typeof data === "function" ) { + // Shift arguments if data argument was omitted. + // Handle the null callback placeholder. + if ( typeof data === "function" || data === null ) { type = type || callback; callback = data; data = undefined; diff --git a/src/ajax/xhr.js b/src/ajax/xhr.js index a024bb236..528a5c748 100644 --- a/src/ajax/xhr.js +++ b/src/ajax/xhr.js @@ -15,7 +15,6 @@ var xhrSuccessStatus = { jQuery.ajaxTransport( function( options ) { var callback; - // Cross domain only allowed if supported through XMLHttpRequest return { send: function( headers, complete ) { var i, -- cgit v1.2.3