Browse Source

Moving from Plexus Utils IOUtil to Commons IO IOUtils. close(..) becomes closeQuietly(..). copy(..) stays the same. In 1.3 (we're on 1.2 currently) copy(..) will throw an exception if more than MAXINT bytes are copied, but this is just a test case so I think we're safe.

git-svn-id: https://svn.apache.org/repos/asf/maven/archiva/trunk@481460 13f79535-47bb-0310-9956-ffa450edef68
tags/archiva-0.9-alpha-1
Henri Yandell 17 years ago
parent
commit
5484a75333

+ 4
- 0
archiva-configuration/pom.xml View File

<groupId>commons-lang</groupId> <groupId>commons-lang</groupId>
<artifactId>commons-lang</artifactId> <artifactId>commons-lang</artifactId>
</dependency> </dependency>
<dependency>
<groupId>commons-io</groupId>
<artifactId>commons-io</artifactId>
</dependency>
</dependencies> </dependencies>
<build> <build>
<plugins> <plugins>

+ 3
- 3
archiva-configuration/src/main/java/org/apache/maven/archiva/configuration/DefaultConfigurationStore.java View File

import org.apache.maven.archiva.configuration.io.xpp3.ConfigurationXpp3Reader; import org.apache.maven.archiva.configuration.io.xpp3.ConfigurationXpp3Reader;
import org.apache.maven.archiva.configuration.io.xpp3.ConfigurationXpp3Writer; import org.apache.maven.archiva.configuration.io.xpp3.ConfigurationXpp3Writer;
import org.codehaus.plexus.logging.AbstractLogEnabled; import org.codehaus.plexus.logging.AbstractLogEnabled;
import org.codehaus.plexus.util.IOUtil;
import org.apache.commons.io.IOUtils;
import org.apache.commons.lang.StringUtils; import org.apache.commons.lang.StringUtils;
import org.codehaus.plexus.util.xml.pull.XmlPullParserException; import org.codehaus.plexus.util.xml.pull.XmlPullParserException;


} }
finally finally
{ {
IOUtil.close( fileReader );
IOUtils.closeQuietly( fileReader );
} }
} }
return configuration; return configuration;
} }
finally finally
{ {
IOUtil.close( fileWriter );
IOUtils.closeQuietly( fileWriter );
} }
} }



+ 4
- 0
archiva-converter/pom.xml View File

<artifactId>plexus-i18n</artifactId> <artifactId>plexus-i18n</artifactId>
<version>1.0-beta-6</version> <version>1.0-beta-6</version>
</dependency> </dependency>
<dependency>
<groupId>commons-io</groupId>
<artifactId>commons-io</artifactId>
</dependency>
</dependencies> </dependencies>
</project> </project>

+ 4
- 4
archiva-converter/src/main/java/org/apache/maven/archiva/converter/DefaultRepositoryConverter.java View File

import org.codehaus.plexus.digest.DigesterException; import org.codehaus.plexus.digest.DigesterException;
import org.codehaus.plexus.i18n.I18N; import org.codehaus.plexus.i18n.I18N;
import org.codehaus.plexus.util.FileUtils; import org.codehaus.plexus.util.FileUtils;
import org.codehaus.plexus.util.IOUtil;
import org.apache.commons.io.IOUtils;
import org.codehaus.plexus.util.xml.pull.XmlPullParserException; import org.codehaus.plexus.util.xml.pull.XmlPullParserException;


import java.io.File; import java.io.File;
} }
finally finally
{ {
IOUtil.close( writer );
IOUtils.closeQuietly( writer );
} }
} }
} }
} }
finally finally
{ {
IOUtil.close( fileReader );
IOUtils.closeQuietly( fileReader );
} }
return metadata; return metadata;
} }
} }
finally finally
{ {
IOUtil.close( writer );
IOUtils.closeQuietly( writer );
} }
} }
} }

+ 4
- 0
archiva-proxy/pom.xml View File

<version>1.2_Java1.3</version> <version>1.2_Java1.3</version>
<scope>test</scope> <scope>test</scope>
</dependency> </dependency>
<dependency>
<groupId>commons-io</groupId>
<artifactId>commons-io</artifactId>
</dependency>
</dependencies> </dependencies>
</project> </project>

+ 4
- 4
archiva-proxy/src/main/java/org/apache/maven/archiva/proxy/DefaultProxyRequestHandler.java View File

import org.codehaus.plexus.digest.DigesterException; import org.codehaus.plexus.digest.DigesterException;
import org.codehaus.plexus.logging.AbstractLogEnabled; import org.codehaus.plexus.logging.AbstractLogEnabled;
import org.codehaus.plexus.util.FileUtils; import org.codehaus.plexus.util.FileUtils;
import org.codehaus.plexus.util.IOUtil;
import org.apache.commons.io.IOUtils;
import org.codehaus.plexus.util.xml.pull.XmlPullParserException; import org.codehaus.plexus.util.xml.pull.XmlPullParserException;


import java.io.File; import java.io.File;
} }
finally finally
{ {
IOUtil.close( fileReader );
IOUtils.closeQuietly( fileReader );
} }
} }


} }
finally finally
{ {
IOUtil.close( fileReader );
IOUtils.closeQuietly( fileReader );
} }


if ( changed ) if ( changed )
} }
finally finally
{ {
IOUtil.close( fileWriter );
IOUtils.closeQuietly( fileWriter );
} }
} }
} }

+ 4
- 0
archiva-reports-standard/pom.xml View File

<groupId>commons-lang</groupId> <groupId>commons-lang</groupId>
<artifactId>commons-lang</artifactId> <artifactId>commons-lang</artifactId>
</dependency> </dependency>
<dependency>
<groupId>commons-io</groupId>
<artifactId>commons-io</artifactId>
</dependency>
</dependencies> </dependencies>
<build> <build>
<plugins> <plugins>

+ 2
- 2
archiva-reports-standard/src/main/java/org/apache/maven/archiva/reporting/processor/InvalidPomArtifactReportProcessor.java View File

import org.apache.maven.model.io.xpp3.MavenXpp3Reader; import org.apache.maven.model.io.xpp3.MavenXpp3Reader;
import org.apache.maven.archiva.reporting.processor.ArtifactReportProcessor; import org.apache.maven.archiva.reporting.processor.ArtifactReportProcessor;
import org.apache.maven.archiva.reporting.database.ReportingDatabase; import org.apache.maven.archiva.reporting.database.ReportingDatabase;
import org.codehaus.plexus.util.IOUtil;
import org.apache.commons.io.IOUtils;
import org.codehaus.plexus.util.xml.pull.XmlPullParserException; import org.codehaus.plexus.util.xml.pull.XmlPullParserException;


import java.io.File; import java.io.File;
} }
finally finally
{ {
IOUtil.close( reader );
IOUtils.closeQuietly( reader );
} }
} }
} }

+ 2
- 2
archiva-reports-standard/src/main/java/org/apache/maven/archiva/reporting/processor/LocationArtifactReportProcessor.java View File

import org.apache.maven.project.MavenProjectBuilder; import org.apache.maven.project.MavenProjectBuilder;
import org.apache.maven.archiva.reporting.processor.ArtifactReportProcessor; import org.apache.maven.archiva.reporting.processor.ArtifactReportProcessor;
import org.apache.maven.archiva.reporting.database.ReportingDatabase; import org.apache.maven.archiva.reporting.database.ReportingDatabase;
import org.codehaus.plexus.util.IOUtil;
import org.apache.commons.io.IOUtils;
import org.codehaus.plexus.util.xml.pull.XmlPullParserException; import org.codehaus.plexus.util.xml.pull.XmlPullParserException;


import java.io.File; import java.io.File;
} }
finally finally
{ {
IOUtil.close( isReader );
IOUtils.closeQuietly( isReader );
} }
return model; return model;
} }

+ 3
- 3
archiva-reports-standard/src/main/java/org/apache/maven/archiva/reporting/store/DefaultReportingStore.java View File

import org.apache.maven.archiva.reporting.database.ReportingDatabase; import org.apache.maven.archiva.reporting.database.ReportingDatabase;
import org.apache.maven.artifact.repository.ArtifactRepository; import org.apache.maven.artifact.repository.ArtifactRepository;
import org.codehaus.plexus.logging.AbstractLogEnabled; import org.codehaus.plexus.logging.AbstractLogEnabled;
import org.codehaus.plexus.util.IOUtil;
import org.apache.commons.io.IOUtils;
import org.codehaus.plexus.util.xml.pull.XmlPullParserException; import org.codehaus.plexus.util.xml.pull.XmlPullParserException;


import java.io.File; import java.io.File;
} }
finally finally
{ {
IOUtil.close( fileReader );
IOUtils.closeQuietly( fileReader );
} }
} }


} }
finally finally
{ {
IOUtil.close( fileWriter );
IOUtils.closeQuietly( fileWriter );
} }
} }
} }

+ 2
- 2
archiva-reports-standard/src/test/java/org/apache/maven/archiva/reporting/reporter/AbstractChecksumArtifactReporterTestCase.java View File

import org.codehaus.plexus.digest.Digester; import org.codehaus.plexus.digest.Digester;
import org.codehaus.plexus.digest.DigesterException; import org.codehaus.plexus.digest.DigesterException;
import org.codehaus.plexus.util.FileUtils; import org.codehaus.plexus.util.FileUtils;
import org.codehaus.plexus.util.IOUtil;
import org.apache.commons.io.IOUtils;
import org.apache.maven.archiva.reporting.AbstractRepositoryReportsTestCase; import org.apache.maven.archiva.reporting.AbstractRepositoryReportsTestCase;


import java.io.BufferedOutputStream; import java.io.BufferedOutputStream;


BufferedReader in = new BufferedReader( new FileReader( filename1 ) ); BufferedReader in = new BufferedReader( new FileReader( filename1 ) );
out.putNextEntry( new JarEntry( filename1 ) ); out.putNextEntry( new JarEntry( filename1 ) );
IOUtil.copy( in, out );
IOUtils.copy( in, out );
in.close(); in.close();
out.close(); out.close();



+ 4
- 0
archiva-sandbox/archiva-repository-assembler/pom.xml View File

<groupId>org.codehaus.plexus</groupId> <groupId>org.codehaus.plexus</groupId>
<artifactId>plexus-container-default</artifactId> <artifactId>plexus-container-default</artifactId>
</dependency> </dependency>
<dependency>
<groupId>commons-io</groupId>
<artifactId>commons-io</artifactId>
</dependency>
</dependencies> </dependencies>
</project> </project>

+ 2
- 2
archiva-sandbox/archiva-repository-assembler/src/main/java/org/apache/maven/archiva/repository/assembly/DefaultRepositoryAssembler.java View File

import org.apache.maven.artifact.resolver.filter.ScopeArtifactFilter; import org.apache.maven.artifact.resolver.filter.ScopeArtifactFilter;
import org.codehaus.plexus.logging.AbstractLogEnabled; import org.codehaus.plexus.logging.AbstractLogEnabled;
import org.codehaus.plexus.util.FileUtils; import org.codehaus.plexus.util.FileUtils;
import org.codehaus.plexus.util.IOUtil;
import org.apache.commons.io.IOUtils;


import java.io.File; import java.io.File;
import java.io.FileWriter; import java.io.FileWriter;
} }
finally finally
{ {
IOUtil.close( writer );
IOUtils.closeQuietly( writer );
} }


try try

+ 5
- 0
pom.xml View File

<artifactId>commons-lang</artifactId> <artifactId>commons-lang</artifactId>
<version>2.2</version> <version>2.2</version>
</dependency> </dependency>
<dependency>
<groupId>commons-io</groupId>
<artifactId>commons-io</artifactId>
<version>1.2</version>
</dependency>
</dependencies> </dependencies>
</dependencyManagement> </dependencyManagement>
<reporting> <reporting>

Loading…
Cancel
Save