Remove admin permission setting from Redmine auth provider (issue-368)

This feature depended on an undocumented behavior of Redmine.  If/when
Redmine groups are mapped to Gitblit teams, we can reconsider setting
the admin permission (issue-321).

releases.moxie

@@ -21,6 +21,7 @@ r20: {
 	- Fixed NPE when attempting to add a permission without a registrant (issue-344)
 	- Invalidate all cached repository data on "clear cache" (issue-346)
 	- Fix chart failures when an apostrophe is in a user display name (issue-350, pr-128)
+	- Stop setting admin permission based on undocumented Redmine REST API behavior (issue-368)
 	- Fix support url decoding with non-ascii characters (pr-136)
 	- Fix potential NPE on removing uncached repository from cache
 	- Ignore the default contents of .git/description file

src/main/java/com/gitblit/auth/RedmineAuthProvider.java

@@ -134,11 +134,6 @@ public class RedmineAuthProvider extends UsernamePasswordAuthenticationProvider
         user.displayName = current.user.firstname + " " + current.user.lastname;
         user.emailAddress = current.user.mail;
         user.password = Constants.EXTERNAL_ACCOUNT;
-        if (!StringUtils.isEmpty(current.user.login)) {
-        	// only admin users can get login name
-        	// evidently this is an undocumented behavior of Redmine
-        	user.canAdmin = true;
-        }
 
         // TODO consider Redmine group mapping for team membership
         // http://www.redmine.org/projects/redmine/wiki/Rest_Users