Browse Source

Whitelist the "target" link attribute in the XSS filter

tags/v1.7.0
James Moger 9 years ago
parent
commit
b5010f9f54
2 changed files with 3 additions and 1 deletions
  1. 2
    0
      releases.moxie
  2. 1
    1
      src/main/java/com/gitblit/utils/JSoupXssFilter.java

+ 2
- 0
releases.moxie View File

@@ -18,6 +18,7 @@ r27: {
- Fix exception when viewing a ticket with a patchset where the integration branch does not exist (issue-521, ticket-212)
- Fix exception when deleting a repository using the FileTicketService (issue-522, ticket-213)
- Do not inject team repository permissions as explicit user permissoins when editing a user (issue-462, ticket-214)
- Whitelist the target link attribute in the XSS filter (ticket-216)
changes:
- Replaced Dagger with Guice (ticket-80)
- Use release name as root directory in Gitblit GO artifacts (ticket-109)
@@ -41,6 +42,7 @@ r27: {
- Florian Zschocke
- Paul Martin
- razzard
- Alexander Zabluda
}

#

+ 1
- 1
src/main/java/com/gitblit/utils/JSoupXssFilter.java View File

@@ -73,7 +73,7 @@ public class JSoupXssFilter implements XssFilter {
"sub", "sup", "table", "tbody", "td", "tfoot", "th", "thead", "tr", "tt", "u",
"ul", "var")

.addAttributes("a", "class", "href", "style", "title")
.addAttributes("a", "class", "href", "style", "target", "title")
.addAttributes("blockquote", "cite")
.addAttributes("col", "span", "width")
.addAttributes("colgroup", "span", "width")

Loading…
Cancel
Save