You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

issue_milestone.go 11KB

Shows total tracked time in issue and milestone list (#3341) * Show total tracked time in issue and milestone list Show total tracked time at issue page Signed-off-by: Jonas Franz <info@jonasfranz.software> * Optimizing TotalTimes by using SumInt Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fixing wrong total times for milestones caused by a missing JOIN Adding unit tests for total times Signed-off-by: Jonas Franz <info@jonasfranz.software> * Logging error instead of ignoring it Signed-off-by: Jonas Franz <info@jonasfranz.software> * Correcting spelling mistakes Signed-off-by: Jonas Franz <info@jonasfranz.software> * Change error message to a short version Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add error handling to TotalTimes Add variable for totalTimes Signed-off-by: Jonas Franz <info@jonasfranz.de> * Introduce TotalTrackedTimes as variable of issue Load TotalTrackedTimes by loading attributes of IssueList Load TotalTrackedTimes by loading attributes of single issue Add Sec2Time as helper to use it in templates Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fixed test + gofmt Signed-off-by: Jonas Franz <info@jonasfranz.software> * Load TotalTrackedTimes via MilestoneList instead of single requests Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add documentation for MilestoneList Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add documentation for MilestoneList Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix test Signed-off-by: Jonas Franz <info@jonasfranz.software> * Change comment from SQL query to description Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix unit test by using int64 instead of int Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix unit test by using int64 instead of int Signed-off-by: Jonas Franz <info@jonasfranz.software> * Check if timetracker is enabled Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix test by enabling timetracking Signed-off-by: Jonas Franz <info@jonasfranz.de>
6 years ago
Shows total tracked time in issue and milestone list (#3341) * Show total tracked time in issue and milestone list Show total tracked time at issue page Signed-off-by: Jonas Franz <info@jonasfranz.software> * Optimizing TotalTimes by using SumInt Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fixing wrong total times for milestones caused by a missing JOIN Adding unit tests for total times Signed-off-by: Jonas Franz <info@jonasfranz.software> * Logging error instead of ignoring it Signed-off-by: Jonas Franz <info@jonasfranz.software> * Correcting spelling mistakes Signed-off-by: Jonas Franz <info@jonasfranz.software> * Change error message to a short version Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add error handling to TotalTimes Add variable for totalTimes Signed-off-by: Jonas Franz <info@jonasfranz.de> * Introduce TotalTrackedTimes as variable of issue Load TotalTrackedTimes by loading attributes of IssueList Load TotalTrackedTimes by loading attributes of single issue Add Sec2Time as helper to use it in templates Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fixed test + gofmt Signed-off-by: Jonas Franz <info@jonasfranz.software> * Load TotalTrackedTimes via MilestoneList instead of single requests Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add documentation for MilestoneList Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add documentation for MilestoneList Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix test Signed-off-by: Jonas Franz <info@jonasfranz.software> * Change comment from SQL query to description Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix unit test by using int64 instead of int Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix unit test by using int64 instead of int Signed-off-by: Jonas Franz <info@jonasfranz.software> * Check if timetracker is enabled Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix test by enabling timetracking Signed-off-by: Jonas Franz <info@jonasfranz.de>
6 years ago
Shows total tracked time in issue and milestone list (#3341) * Show total tracked time in issue and milestone list Show total tracked time at issue page Signed-off-by: Jonas Franz <info@jonasfranz.software> * Optimizing TotalTimes by using SumInt Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fixing wrong total times for milestones caused by a missing JOIN Adding unit tests for total times Signed-off-by: Jonas Franz <info@jonasfranz.software> * Logging error instead of ignoring it Signed-off-by: Jonas Franz <info@jonasfranz.software> * Correcting spelling mistakes Signed-off-by: Jonas Franz <info@jonasfranz.software> * Change error message to a short version Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add error handling to TotalTimes Add variable for totalTimes Signed-off-by: Jonas Franz <info@jonasfranz.de> * Introduce TotalTrackedTimes as variable of issue Load TotalTrackedTimes by loading attributes of IssueList Load TotalTrackedTimes by loading attributes of single issue Add Sec2Time as helper to use it in templates Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fixed test + gofmt Signed-off-by: Jonas Franz <info@jonasfranz.software> * Load TotalTrackedTimes via MilestoneList instead of single requests Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add documentation for MilestoneList Signed-off-by: Jonas Franz <info@jonasfranz.software> * Add documentation for MilestoneList Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix test Signed-off-by: Jonas Franz <info@jonasfranz.software> * Change comment from SQL query to description Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix unit test by using int64 instead of int Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix unit test by using int64 instead of int Signed-off-by: Jonas Franz <info@jonasfranz.software> * Check if timetracker is enabled Signed-off-by: Jonas Franz <info@jonasfranz.software> * Fix test by enabling timetracking Signed-off-by: Jonas Franz <info@jonasfranz.de>
6 years ago
123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455
  1. // Copyright 2017 The Gitea Authors. All rights reserved.
  2. // Use of this source code is governed by a MIT-style
  3. // license that can be found in the LICENSE file.
  4. package models
  5. import (
  6. "fmt"
  7. "code.gitea.io/gitea/modules/setting"
  8. api "code.gitea.io/gitea/modules/structs"
  9. "code.gitea.io/gitea/modules/timeutil"
  10. "xorm.io/builder"
  11. "xorm.io/xorm"
  12. )
  13. // Milestone represents a milestone of repository.
  14. type Milestone struct {
  15. ID int64 `xorm:"pk autoincr"`
  16. RepoID int64 `xorm:"INDEX"`
  17. Name string
  18. Content string `xorm:"TEXT"`
  19. RenderedContent string `xorm:"-"`
  20. IsClosed bool
  21. NumIssues int
  22. NumClosedIssues int
  23. NumOpenIssues int `xorm:"-"`
  24. Completeness int // Percentage(1-100).
  25. IsOverdue bool `xorm:"-"`
  26. DeadlineString string `xorm:"-"`
  27. DeadlineUnix timeutil.TimeStamp
  28. ClosedDateUnix timeutil.TimeStamp
  29. TotalTrackedTime int64 `xorm:"-"`
  30. }
  31. // BeforeUpdate is invoked from XORM before updating this object.
  32. func (m *Milestone) BeforeUpdate() {
  33. if m.NumIssues > 0 {
  34. m.Completeness = m.NumClosedIssues * 100 / m.NumIssues
  35. } else {
  36. m.Completeness = 0
  37. }
  38. }
  39. // AfterLoad is invoked from XORM after setting the value of a field of
  40. // this object.
  41. func (m *Milestone) AfterLoad() {
  42. m.NumOpenIssues = m.NumIssues - m.NumClosedIssues
  43. if m.DeadlineUnix.Year() == 9999 {
  44. return
  45. }
  46. m.DeadlineString = m.DeadlineUnix.Format("2006-01-02")
  47. if timeutil.TimeStampNow() >= m.DeadlineUnix {
  48. m.IsOverdue = true
  49. }
  50. }
  51. // State returns string representation of milestone status.
  52. func (m *Milestone) State() api.StateType {
  53. if m.IsClosed {
  54. return api.StateClosed
  55. }
  56. return api.StateOpen
  57. }
  58. // APIFormat returns this Milestone in API format.
  59. func (m *Milestone) APIFormat() *api.Milestone {
  60. apiMilestone := &api.Milestone{
  61. ID: m.ID,
  62. State: m.State(),
  63. Title: m.Name,
  64. Description: m.Content,
  65. OpenIssues: m.NumOpenIssues,
  66. ClosedIssues: m.NumClosedIssues,
  67. }
  68. if m.IsClosed {
  69. apiMilestone.Closed = m.ClosedDateUnix.AsTimePtr()
  70. }
  71. if m.DeadlineUnix.Year() < 9999 {
  72. apiMilestone.Deadline = m.DeadlineUnix.AsTimePtr()
  73. }
  74. return apiMilestone
  75. }
  76. // NewMilestone creates new milestone of repository.
  77. func NewMilestone(m *Milestone) (err error) {
  78. sess := x.NewSession()
  79. defer sess.Close()
  80. if err = sess.Begin(); err != nil {
  81. return err
  82. }
  83. if _, err = sess.Insert(m); err != nil {
  84. return err
  85. }
  86. if _, err = sess.Exec("UPDATE `repository` SET num_milestones = num_milestones + 1 WHERE id = ?", m.RepoID); err != nil {
  87. return err
  88. }
  89. return sess.Commit()
  90. }
  91. func getMilestoneByRepoID(e Engine, repoID, id int64) (*Milestone, error) {
  92. m := &Milestone{
  93. ID: id,
  94. RepoID: repoID,
  95. }
  96. has, err := e.Get(m)
  97. if err != nil {
  98. return nil, err
  99. } else if !has {
  100. return nil, ErrMilestoneNotExist{id, repoID}
  101. }
  102. return m, nil
  103. }
  104. // GetMilestoneByRepoID returns the milestone in a repository.
  105. func GetMilestoneByRepoID(repoID, id int64) (*Milestone, error) {
  106. return getMilestoneByRepoID(x, repoID, id)
  107. }
  108. // GetMilestoneByID returns the milestone via id .
  109. func GetMilestoneByID(id int64) (*Milestone, error) {
  110. var m Milestone
  111. has, err := x.ID(id).Get(&m)
  112. if err != nil {
  113. return nil, err
  114. } else if !has {
  115. return nil, ErrMilestoneNotExist{id, 0}
  116. }
  117. return &m, nil
  118. }
  119. // MilestoneList is a list of milestones offering additional functionality
  120. type MilestoneList []*Milestone
  121. func (milestones MilestoneList) loadTotalTrackedTimes(e Engine) error {
  122. type totalTimesByMilestone struct {
  123. MilestoneID int64
  124. Time int64
  125. }
  126. if len(milestones) == 0 {
  127. return nil
  128. }
  129. var trackedTimes = make(map[int64]int64, len(milestones))
  130. // Get total tracked time by milestone_id
  131. rows, err := e.Table("issue").
  132. Join("INNER", "milestone", "issue.milestone_id = milestone.id").
  133. Join("LEFT", "tracked_time", "tracked_time.issue_id = issue.id").
  134. Select("milestone_id, sum(time) as time").
  135. In("milestone_id", milestones.getMilestoneIDs()).
  136. GroupBy("milestone_id").
  137. Rows(new(totalTimesByMilestone))
  138. if err != nil {
  139. return err
  140. }
  141. defer rows.Close()
  142. for rows.Next() {
  143. var totalTime totalTimesByMilestone
  144. err = rows.Scan(&totalTime)
  145. if err != nil {
  146. return err
  147. }
  148. trackedTimes[totalTime.MilestoneID] = totalTime.Time
  149. }
  150. for _, milestone := range milestones {
  151. milestone.TotalTrackedTime = trackedTimes[milestone.ID]
  152. }
  153. return nil
  154. }
  155. // LoadTotalTrackedTimes loads for every milestone in the list the TotalTrackedTime by a batch request
  156. func (milestones MilestoneList) LoadTotalTrackedTimes() error {
  157. return milestones.loadTotalTrackedTimes(x)
  158. }
  159. func (milestones MilestoneList) getMilestoneIDs() []int64 {
  160. var ids = make([]int64, 0, len(milestones))
  161. for _, ms := range milestones {
  162. ids = append(ids, ms.ID)
  163. }
  164. return ids
  165. }
  166. // GetMilestonesByRepoID returns all opened milestones of a repository.
  167. func GetMilestonesByRepoID(repoID int64, state api.StateType) (MilestoneList, error) {
  168. sess := x.Where("repo_id = ?", repoID)
  169. switch state {
  170. case api.StateClosed:
  171. sess = sess.And("is_closed = ?", true)
  172. case api.StateAll:
  173. break
  174. case api.StateOpen:
  175. fallthrough
  176. default:
  177. sess = sess.And("is_closed = ?", false)
  178. }
  179. miles := make([]*Milestone, 0, 10)
  180. return miles, sess.Asc("deadline_unix").Asc("id").Find(&miles)
  181. }
  182. // GetMilestones returns a list of milestones of given repository and status.
  183. func GetMilestones(repoID int64, page int, isClosed bool, sortType string) (MilestoneList, error) {
  184. miles := make([]*Milestone, 0, setting.UI.IssuePagingNum)
  185. sess := x.Where("repo_id = ? AND is_closed = ?", repoID, isClosed)
  186. if page > 0 {
  187. sess = sess.Limit(setting.UI.IssuePagingNum, (page-1)*setting.UI.IssuePagingNum)
  188. }
  189. switch sortType {
  190. case "furthestduedate":
  191. sess.Desc("deadline_unix")
  192. case "leastcomplete":
  193. sess.Asc("completeness")
  194. case "mostcomplete":
  195. sess.Desc("completeness")
  196. case "leastissues":
  197. sess.Asc("num_issues")
  198. case "mostissues":
  199. sess.Desc("num_issues")
  200. default:
  201. sess.Asc("deadline_unix")
  202. }
  203. return miles, sess.Find(&miles)
  204. }
  205. func updateMilestone(e Engine, m *Milestone) error {
  206. _, err := e.ID(m.ID).AllCols().
  207. SetExpr("num_issues", builder.Select("count(*)").From("issue").Where(
  208. builder.Eq{"milestone_id": m.ID},
  209. )).
  210. SetExpr("num_closed_issues", builder.Select("count(*)").From("issue").Where(
  211. builder.Eq{
  212. "milestone_id": m.ID,
  213. "is_closed": true,
  214. },
  215. )).
  216. Update(m)
  217. return err
  218. }
  219. // UpdateMilestone updates information of given milestone.
  220. func UpdateMilestone(m *Milestone) error {
  221. if err := updateMilestone(x, m); err != nil {
  222. return err
  223. }
  224. return updateMilestoneCompleteness(x, m.ID)
  225. }
  226. func updateMilestoneCompleteness(e Engine, milestoneID int64) error {
  227. _, err := e.Exec("UPDATE `milestone` SET completeness=100*num_closed_issues/(CASE WHEN num_issues > 0 THEN num_issues ELSE 1 END) WHERE id=?",
  228. milestoneID,
  229. )
  230. return err
  231. }
  232. func countRepoMilestones(e Engine, repoID int64) (int64, error) {
  233. return e.
  234. Where("repo_id=?", repoID).
  235. Count(new(Milestone))
  236. }
  237. func countRepoClosedMilestones(e Engine, repoID int64) (int64, error) {
  238. return e.
  239. Where("repo_id=? AND is_closed=?", repoID, true).
  240. Count(new(Milestone))
  241. }
  242. // CountRepoClosedMilestones returns number of closed milestones in given repository.
  243. func CountRepoClosedMilestones(repoID int64) (int64, error) {
  244. return countRepoClosedMilestones(x, repoID)
  245. }
  246. // MilestoneStats returns number of open and closed milestones of given repository.
  247. func MilestoneStats(repoID int64) (open int64, closed int64, err error) {
  248. open, err = x.
  249. Where("repo_id=? AND is_closed=?", repoID, false).
  250. Count(new(Milestone))
  251. if err != nil {
  252. return 0, 0, nil
  253. }
  254. closed, err = CountRepoClosedMilestones(repoID)
  255. return open, closed, err
  256. }
  257. // ChangeMilestoneStatus changes the milestone open/closed status.
  258. func ChangeMilestoneStatus(m *Milestone, isClosed bool) (err error) {
  259. sess := x.NewSession()
  260. defer sess.Close()
  261. if err = sess.Begin(); err != nil {
  262. return err
  263. }
  264. m.IsClosed = isClosed
  265. if _, err := sess.ID(m.ID).Cols("is_closed").Update(m); err != nil {
  266. return err
  267. }
  268. if err := updateRepoMilestoneNum(sess, m.RepoID); err != nil {
  269. return err
  270. }
  271. return sess.Commit()
  272. }
  273. func updateRepoMilestoneNum(e Engine, repoID int64) error {
  274. _, err := e.Exec("UPDATE `repository` SET num_milestones=(SELECT count(*) FROM milestone WHERE repo_id=?),num_closed_milestones=(SELECT count(*) FROM milestone WHERE repo_id=? AND is_closed=?) WHERE id=?",
  275. repoID,
  276. repoID,
  277. true,
  278. repoID,
  279. )
  280. return err
  281. }
  282. func updateMilestoneTotalNum(e Engine, milestoneID int64) (err error) {
  283. if _, err = e.Exec("UPDATE `milestone` SET num_issues=(SELECT count(*) FROM issue WHERE milestone_id=?) WHERE id=?",
  284. milestoneID,
  285. milestoneID,
  286. ); err != nil {
  287. return
  288. }
  289. return updateMilestoneCompleteness(e, milestoneID)
  290. }
  291. func updateMilestoneClosedNum(e Engine, milestoneID int64) (err error) {
  292. if _, err = e.Exec("UPDATE `milestone` SET num_closed_issues=(SELECT count(*) FROM issue WHERE milestone_id=? AND is_closed=?) WHERE id=?",
  293. milestoneID,
  294. true,
  295. milestoneID,
  296. ); err != nil {
  297. return
  298. }
  299. return updateMilestoneCompleteness(e, milestoneID)
  300. }
  301. func changeMilestoneAssign(e *xorm.Session, doer *User, issue *Issue, oldMilestoneID int64) error {
  302. if err := updateIssueCols(e, issue, "milestone_id"); err != nil {
  303. return err
  304. }
  305. if oldMilestoneID > 0 {
  306. if err := updateMilestoneTotalNum(e, oldMilestoneID); err != nil {
  307. return err
  308. }
  309. if issue.IsClosed {
  310. if err := updateMilestoneClosedNum(e, oldMilestoneID); err != nil {
  311. return err
  312. }
  313. }
  314. }
  315. if issue.MilestoneID > 0 {
  316. if err := updateMilestoneTotalNum(e, issue.MilestoneID); err != nil {
  317. return err
  318. }
  319. if issue.IsClosed {
  320. if err := updateMilestoneClosedNum(e, issue.MilestoneID); err != nil {
  321. return err
  322. }
  323. }
  324. }
  325. if oldMilestoneID > 0 || issue.MilestoneID > 0 {
  326. if err := issue.loadRepo(e); err != nil {
  327. return err
  328. }
  329. if _, err := createMilestoneComment(e, doer, issue.Repo, issue, oldMilestoneID, issue.MilestoneID); err != nil {
  330. return err
  331. }
  332. }
  333. return nil
  334. }
  335. // ChangeMilestoneAssign changes assignment of milestone for issue.
  336. func ChangeMilestoneAssign(issue *Issue, doer *User, oldMilestoneID int64) (err error) {
  337. sess := x.NewSession()
  338. defer sess.Close()
  339. if err = sess.Begin(); err != nil {
  340. return err
  341. }
  342. if err = changeMilestoneAssign(sess, doer, issue, oldMilestoneID); err != nil {
  343. return err
  344. }
  345. if err = sess.Commit(); err != nil {
  346. return fmt.Errorf("Commit: %v", err)
  347. }
  348. return nil
  349. }
  350. // DeleteMilestoneByRepoID deletes a milestone from a repository.
  351. func DeleteMilestoneByRepoID(repoID, id int64) error {
  352. m, err := GetMilestoneByRepoID(repoID, id)
  353. if err != nil {
  354. if IsErrMilestoneNotExist(err) {
  355. return nil
  356. }
  357. return err
  358. }
  359. repo, err := GetRepositoryByID(m.RepoID)
  360. if err != nil {
  361. return err
  362. }
  363. sess := x.NewSession()
  364. defer sess.Close()
  365. if err = sess.Begin(); err != nil {
  366. return err
  367. }
  368. if _, err = sess.ID(m.ID).Delete(new(Milestone)); err != nil {
  369. return err
  370. }
  371. numMilestones, err := countRepoMilestones(sess, repo.ID)
  372. if err != nil {
  373. return err
  374. }
  375. numClosedMilestones, err := countRepoClosedMilestones(sess, repo.ID)
  376. if err != nil {
  377. return err
  378. }
  379. repo.NumMilestones = int(numMilestones)
  380. repo.NumClosedMilestones = int(numClosedMilestones)
  381. if _, err = sess.ID(repo.ID).Cols("num_milestones, num_closed_milestones").Update(repo); err != nil {
  382. return err
  383. }
  384. if _, err = sess.Exec("UPDATE `issue` SET milestone_id = 0 WHERE milestone_id = ?", m.ID); err != nil {
  385. return err
  386. }
  387. return sess.Commit()
  388. }