浏览代码

Add default CommitID for create pull review api (#11334)

If user create pull review through api but not set CommitID,
I think it's necessary to use last headCommitID as default seting,
or this review will be considered as stale review which is wrong

Signed-off-by: a101211279 <1012112796@qq.com>
tags/v1.13.0-dev
赵智超 4 年前
父节点
当前提交
119173130a
没有帐户链接到提交者的电子邮件
共有 1 个文件被更改,包括 19 次插入0 次删除
  1. 19
    0
      routers/api/v1/repo/pull_review.go

+ 19
- 0
routers/api/v1/repo/pull_review.go 查看文件

@@ -12,6 +12,7 @@ import (
"code.gitea.io/gitea/models"
"code.gitea.io/gitea/modules/context"
"code.gitea.io/gitea/modules/convert"
"code.gitea.io/gitea/modules/git"
api "code.gitea.io/gitea/modules/structs"
"code.gitea.io/gitea/routers/api/v1/utils"
pull_service "code.gitea.io/gitea/services/pull"
@@ -313,6 +314,24 @@ func CreatePullReview(ctx *context.APIContext, opts api.CreatePullReviewOptions)
return
}

// if CommitID is empty, set it as lastCommitID
if opts.CommitID == "" {
gitRepo, err := git.OpenRepository(pr.Issue.Repo.RepoPath())
if err != nil {
ctx.ServerError("git.OpenRepository", err)
return
}
defer gitRepo.Close()

headCommitID, err := gitRepo.GetRefCommitID(pr.GetGitRefName())
if err != nil {
ctx.ServerError("GetRefCommitID", err)
return
}

opts.CommitID = headCommitID
}

// create review comments
for _, c := range opts.Comments {
line := c.NewLineNum

正在加载...
取消
保存