Browse Source

Do not call nil handler for a dummy queue (#24880)

A dummy queue doesn't really have a handler (see line 211), so the
`safeHandler` can safely drop all items
tags/v1.20.0-rc0
wxiaoguang 1 year ago
parent
commit
16a766cba1
No account linked to committer's email address
1 changed files with 4 additions and 1 deletions
  1. 4
    1
      modules/queue/workerqueue.go

+ 4
- 1
modules/queue/workerqueue.go View File

@@ -239,7 +239,10 @@ func NewWorkerPoolQueueBySetting[T any](name string, queueSetting setting.QueueS
log.Error("Recovered from panic in queue %q handler: %v\n%s", name, err, log.Stack(2))
}
}()
return w.origHandler(t...)
if w.origHandler != nil {
return w.origHandler(t...)
}
return nil
}

return &w, nil

Loading…
Cancel
Save