* Migration failure during reaction migration from gitea (#13344) * Migrating reactions is just not that important A failure during migrating reactions should not cause failure of migration. Signed-off-by: Andrew Thornton <art27@cantab.net> * When checking issue reactions check the correct permission Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: techknowlogick <techknowlogick@gitea.io> * Delete gitea_downloader.go * Backport #13349 Unfortunately my final push to #13344 didn't register - or I failed to push it properly. GetIssueCommentReactions in routers/api/v1/repo/issue_reaction.go also makes the same mistake. Co-authored-by: zeripath <art27@cantab.net>tags/v1.12.6
@@ -84,7 +84,7 @@ func MigrateRepository(ctx context.Context, doer *models.User, ownerName string, | |||
} | |||
if err2 := models.CreateRepositoryNotice(fmt.Sprintf("Migrate repository from %s failed: %v", opts.OriginalURL, err)); err2 != nil { | |||
log.Error("create respotiry notice failed: ", err2) | |||
log.Error("create repository notice failed: ", err2) | |||
} | |||
return nil, err | |||
} |
@@ -56,7 +56,11 @@ func GetIssueCommentReactions(ctx *context.APIContext) { | |||
return | |||
} | |||
if !ctx.Repo.CanRead(models.UnitTypeIssues) { | |||
if err := comment.LoadIssue(); err != nil { | |||
ctx.Error(http.StatusInternalServerError, "comment.LoadIssue", err) | |||
} | |||
if !ctx.Repo.CanReadIssuesOrPulls(comment.Issue.IsPull) { | |||
ctx.Error(http.StatusForbidden, "GetIssueCommentReactions", errors.New("no permission to get reactions")) | |||
return | |||
} | |||
@@ -270,7 +274,7 @@ func GetIssueReactions(ctx *context.APIContext) { | |||
return | |||
} | |||
if !ctx.Repo.CanRead(models.UnitTypeIssues) { | |||
if !ctx.Repo.CanReadIssuesOrPulls(issue.IsPull) { | |||
ctx.Error(http.StatusForbidden, "GetIssueReactions", errors.New("no permission to get reactions")) | |||
return | |||
} |