Browse Source

Prevent duplicate labels when importing more than 99 (#22591)

Importing labels (via `gitea restore-repo`) did not split them up into
batches properly. The first "batch" would create all labels, the second
"batch" would create all labels except those in the first "batch", etc.
This meant that when importing more than 99 labels (the batch size)
there would always be duplicate ones.

This is solved by actually passing `labels[:lbBatchSize]` to the
`CreateLabels()` function, instead of the entire list `labels`.
tags/v1.19.0-rc0
Sybren 1 year ago
parent
commit
25f4b7d7cd
No account linked to committer's email address
1 changed files with 1 additions and 1 deletions
  1. 1
    1
      services/migrations/migrate.go

+ 1
- 1
services/migrations/migrate.go View File

@@ -281,7 +281,7 @@ func migrateRepository(doer *user_model.User, downloader base.Downloader, upload
lbBatchSize = len(labels)
}

if err := uploader.CreateLabels(labels...); err != nil {
if err := uploader.CreateLabels(labels[:lbBatchSize]...); err != nil {
return err
}
labels = labels[lbBatchSize:]

Loading…
Cancel
Save