Browse Source
Close the temp file when dumping database to make the temp file can be deleted on Windows (#23249)
There was no `dbDump.Close()` before, Windows doesn't like to delete
opened files.
tags/v1.20.0-rc0
wxiaoguang
1 year ago
No account linked to committer's email address
1 changed files with
1 additions and
0 deletions
-
cmd/dump.go
|
|
@@ -272,6 +272,7 @@ func runDump(ctx *cli.Context) error { |
|
|
|
fatal("Failed to create tmp file: %v", err) |
|
|
|
} |
|
|
|
defer func() { |
|
|
|
_ = dbDump.Close() |
|
|
|
if err := util.Remove(dbDump.Name()); err != nil { |
|
|
|
log.Warn("Unable to remove temporary file: %s: Error: %v", dbDump.Name(), err) |
|
|
|
} |