Close #17443 Maybe we do not need to backport this PR, the bug doesn't break daily usage. After the fix, the commit statuses popup can show a lot of lines with scroll bars: ![image](https://user-images.githubusercontent.com/2114189/139026160-f01b484c-6207-494a-a190-a6dd184ceb2b.png)tags/v1.16.0-rc1
@@ -267,10 +267,13 @@ export async function initRepository() { | |||
// Commit statuses | |||
$('.commit-statuses-trigger').each(function () { | |||
const positionRight = $('.repository.file.list').length > 0 || $('.repository.diff').length > 0; | |||
const popupPosition = positionRight ? 'right center' : 'left center'; | |||
$(this) | |||
.popup({ | |||
on: 'click', | |||
position: ($('.repository.file.list').length > 0 ? 'right center' : 'left center'), | |||
lastResort: popupPosition, // prevent error message "Popup does not fit within the boundaries of the viewport" | |||
position: popupPosition, | |||
}); | |||
}); | |||
@@ -1,6 +1,19 @@ | |||
.repository { | |||
.commit-statuses .list > .item { | |||
line-height: 2; | |||
.popup.commit-statuses { | |||
// we had better limit the max size of the popup, and add scroll bars if the content size is too large. | |||
// otherwise some part of the popup will be hidden by viewport boundary | |||
max-height: 45vh; | |||
max-width: 60vw; | |||
overflow: auto; | |||
padding: 0; | |||
.list { | |||
padding: .8em; // to make the scrollbar align to the border, we move the padding from outer `.popup` to this inside `.list` | |||
> .item { | |||
line-height: 2; | |||
} | |||
} | |||
} | |||
.repo-header { |