Backport #27175 by @wxiaoguang According to https://fomantic-ui.com/modules/dropdown.html and our "devtest" page, many dropdown elements has incorrect "icon" position. This PR fixes all of them. Fix #27173 Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>tags/v1.21.0-rc1
@@ -9,8 +9,8 @@ | |||
<div class="ui dropdown type jump item gt-mr-0"> | |||
<span class="text"> | |||
{{.locale.Tr "repo.issues.filter_sort"}} | |||
{{svg "octicon-triangle-down" 14 "dropdown icon"}} | |||
</span> | |||
{{svg "octicon-triangle-down" 14 "dropdown icon"}} | |||
<div class="menu"> | |||
<a class="{{if or (eq .SortType "oldest") (not .SortType)}}active {{end}}item" href="{{$.Link}}?sort=oldest&q={{$.Keyword}}">{{.locale.Tr "repo.issues.filter_sort.oldest"}}</a> | |||
<a class="{{if eq .SortType "newest"}}active {{end}}item" href="{{$.Link}}?sort=newest&q={{$.Keyword}}">{{.locale.Tr "repo.issues.filter_sort.latest"}}</a> |
@@ -15,8 +15,8 @@ | |||
<div class="ui dropdown type jump item gt-mr-0"> | |||
<span class="text"> | |||
{{.locale.Tr "repo.issues.filter_sort"}} | |||
{{svg "octicon-triangle-down" 14 "dropdown icon"}} | |||
</span> | |||
{{svg "octicon-triangle-down" 14 "dropdown icon"}} | |||
<div class="menu"> | |||
<a class="{{if or (eq .SortType "email") (not .SortType)}}active {{end}}item" href="{{$.Link}}?sort=email&q={{$.Keyword}}">{{.locale.Tr "admin.emails.filter_sort.email"}}</a> | |||
<a class="{{if eq .SortType "reverseemail"}}active {{end}}item" href="{{$.Link}}?sort=reverseemail&q={{$.Keyword}}">{{.locale.Tr "admin.emails.filter_sort.email_reverse"}}</a> |
@@ -9,8 +9,8 @@ | |||
<div class="ui dropdown type jump item gt-mr-0"> | |||
<span class="text"> | |||
{{.locale.Tr "repo.issues.filter_sort"}} | |||
{{svg "octicon-triangle-down" 14 "dropdown icon"}} | |||
</span> | |||
{{svg "octicon-triangle-down" 14 "dropdown icon"}} | |||
<div class="menu"> | |||
<a class="{{if or (eq .SortType "oldest") (not .SortType)}}active {{end}}item" href="{{$.Link}}?sort=oldest&q={{$.Keyword}}">{{.locale.Tr "repo.issues.filter_sort.oldest"}}</a> | |||
<a class="{{if eq .SortType "newest"}}active {{end}}item" href="{{$.Link}}?sort=newest&q={{$.Keyword}}">{{.locale.Tr "repo.issues.filter_sort.latest"}}</a> |
@@ -13,7 +13,8 @@ | |||
<div class="ui right floated secondary filter menu"> | |||
<!-- Status Filter Menu Item --> | |||
<div class="ui dropdown type jump item"> | |||
<span class="text">{{.locale.Tr "admin.users.list_status_filter.menu_text"}} {{svg "octicon-triangle-down" 14 "dropdown icon"}}</span> | |||
<span class="text">{{.locale.Tr "admin.users.list_status_filter.menu_text"}}</span> | |||
{{svg "octicon-triangle-down" 14 "dropdown icon"}} | |||
<div class="menu"> | |||
<a class="item j-reset-status-filter">{{.locale.Tr "admin.users.list_status_filter.reset"}}</a> | |||
<div class="divider"></div> | |||
@@ -37,8 +38,9 @@ | |||
<!-- Sort Menu Item --> | |||
<div class="ui dropdown type jump item"> | |||
<span class="text"> | |||
{{.locale.Tr "repo.issues.filter_sort"}} {{svg "octicon-triangle-down" 14 "dropdown icon"}} | |||
{{.locale.Tr "repo.issues.filter_sort"}} | |||
</span> | |||
{{svg "octicon-triangle-down" 14 "dropdown icon"}} | |||
<div class="menu"> | |||
<button class="item" name="sort" value="oldest">{{.locale.Tr "repo.issues.filter_sort.oldest"}}</button> | |||
<button class="item" name="sort" value="newest">{{.locale.Tr "repo.issues.filter_sort.latest"}}</button> |
@@ -16,8 +16,8 @@ | |||
<div class="ui dropdown type jump item gt-mr-0"> | |||
<span class="text"> | |||
{{.locale.Tr "repo.issues.filter_sort"}} | |||
{{svg "octicon-triangle-down" 14 "dropdown icon"}} | |||
</span> | |||
{{svg "octicon-triangle-down" 14 "dropdown icon"}} | |||
<div class="menu"> | |||
<a class="{{if eq .SortType "newest"}}active {{end}}item" href="{{$.Link}}?tab={{$.TabName}}&sort=newest&q={{$.Keyword}}&language={{$.Language}}">{{.locale.Tr "repo.issues.filter_sort.latest"}}</a> | |||
<a class="{{if eq .SortType "oldest"}}active {{end}}item" href="{{$.Link}}?tab={{$.TabName}}&sort=oldest&q={{$.Keyword}}&language={{$.Language}}">{{.locale.Tr "repo.issues.filter_sort.oldest"}}</a> |
@@ -9,8 +9,8 @@ | |||
<div class="ui dropdown type jump item gt-mr-0"> | |||
<span class="text"> | |||
{{.locale.Tr "repo.issues.filter_sort"}} | |||
{{svg "octicon-triangle-down" 14 "dropdown icon"}} | |||
</span> | |||
{{svg "octicon-triangle-down" 14 "dropdown icon"}} | |||
<div class="menu"> | |||
<a class="{{if eq .SortType "newest"}}active {{end}}item" href="{{$.Link}}?sort=newest&q={{$.Keyword}}">{{.locale.Tr "repo.issues.filter_sort.latest"}}</a> | |||
<a class="{{if eq .SortType "oldest"}}active {{end}}item" href="{{$.Link}}?sort=oldest&q={{$.Keyword}}">{{.locale.Tr "repo.issues.filter_sort.oldest"}}</a> |
@@ -33,8 +33,8 @@ | |||
<div class="list-header-sort ui small dropdown type jump item"> | |||
<span class="text"> | |||
{{.locale.Tr "repo.issues.filter_sort"}} | |||
{{svg "octicon-triangle-down" 14 "dropdown icon"}} | |||
</span> | |||
{{svg "octicon-triangle-down" 14 "dropdown icon"}} | |||
<div class="menu"> | |||
<a class="{{if eq .SortType "oldest"}}active {{end}}item" href="{{$.Link}}?q={{$.Keyword}}&sort=oldest&state={{$.State}}">{{.locale.Tr "repo.issues.filter_sort.oldest"}}</a> | |||
<a class="{{if eq .SortType "recentupdate"}}active {{end}}item" href="{{$.Link}}?q={{$.Keyword}}&sort=recentupdate&state={{$.State}}">{{.locale.Tr "repo.issues.filter_sort.recentupdate"}}</a> |
@@ -7,10 +7,8 @@ | |||
<!-- Period --> | |||
<div class="ui floating dropdown jump filter"> | |||
<div class="ui basic compact button"> | |||
<span class="text"> | |||
{{.locale.Tr "repo.activity.period.filter_label"}} <strong>{{.PeriodText}}</strong> | |||
{{svg "octicon-triangle-down" 14 "dropdown icon"}} | |||
</span> | |||
{{.locale.Tr "repo.activity.period.filter_label"}} <strong>{{.PeriodText}}</strong> | |||
{{svg "octicon-triangle-down" 14 "dropdown icon"}} | |||
</div> | |||
<div class="menu"> | |||
<a class="{{if eq .Period "daily"}}active {{end}}item" href="{{$.RepoLink}}/activity/daily">{{.locale.Tr "repo.activity.period.daily"}}</a> |
@@ -7,9 +7,7 @@ | |||
<div class="gt-df gt-ac"> | |||
{{template "repo/branch_dropdown" dict "root" . "ContainerClasses" "gt-mr-2"}} | |||
<a href="{{.RepoLink}}/graph" class="ui basic small compact button"> | |||
<span class="text"> | |||
{{svg "octicon-git-branch"}} | |||
</span> | |||
{{svg "octicon-git-branch"}} | |||
{{.locale.Tr "repo.commit_graph"}} | |||
</a> | |||
</div> |
@@ -11,8 +11,8 @@ | |||
<div class="ui {{if not .Labels}}disabled{{end}} dropdown jump item label-filter"> | |||
<span class="text"> | |||
{{.locale.Tr "repo.issues.filter_label"}} | |||
{{svg "octicon-triangle-down" 14 "dropdown icon"}} | |||
</span> | |||
{{svg "octicon-triangle-down" 14 "dropdown icon"}} | |||
<div class="menu"> | |||
<div class="ui icon search input"> | |||
<i class="icon">{{svg "octicon-search" 16}}</i> | |||
@@ -42,8 +42,8 @@ | |||
<div class="ui {{if not (or .OpenMilestones .ClosedMilestones)}}disabled{{end}} dropdown jump item"> | |||
<span class="text"> | |||
{{.locale.Tr "repo.issues.filter_milestone"}} | |||
{{svg "octicon-triangle-down" 14 "dropdown icon"}} | |||
</span> | |||
{{svg "octicon-triangle-down" 14 "dropdown icon"}} | |||
<div class="menu"> | |||
<div class="ui icon search input"> | |||
<i class="icon">{{svg "octicon-search" 16}}</i> | |||
@@ -80,8 +80,8 @@ | |||
<div class="ui{{if not (or .OpenProjects .ClosedProjects)}} disabled{{end}} dropdown jump item"> | |||
<span class="text"> | |||
{{.locale.Tr "repo.issues.filter_project"}} | |||
{{svg "octicon-triangle-down" 14 "dropdown icon"}} | |||
</span> | |||
{{svg "octicon-triangle-down" 14 "dropdown icon"}} | |||
<div class="menu"> | |||
<div class="ui icon search input"> | |||
<i class="icon">{{svg "octicon-search" 16}}</i> | |||
@@ -122,8 +122,8 @@ | |||
> | |||
<span class="text"> | |||
{{.locale.Tr "repo.issues.filter_poster"}} | |||
{{svg "octicon-triangle-down" 14 "dropdown icon"}} | |||
</span> | |||
{{svg "octicon-triangle-down" 14 "dropdown icon"}} | |||
<div class="menu"> | |||
<div class="ui icon search input"> | |||
<i class="icon">{{svg "octicon-search" 16}}</i> | |||
@@ -137,8 +137,8 @@ | |||
<div class="ui {{if not .Assignees}}disabled{{end}} dropdown jump item"> | |||
<span class="text"> | |||
{{.locale.Tr "repo.issues.filter_assignee"}} | |||
{{svg "octicon-triangle-down" 14 "dropdown icon"}} | |||
</span> | |||
{{svg "octicon-triangle-down" 14 "dropdown icon"}} | |||
<div class="menu"> | |||
<div class="ui icon search input"> | |||
<i class="icon">{{svg "octicon-search" 16}}</i> | |||
@@ -160,8 +160,8 @@ | |||
<div class="ui dropdown type jump item"> | |||
<span class="text"> | |||
{{.locale.Tr "repo.issues.filter_type"}} | |||
{{svg "octicon-triangle-down" 14 "dropdown icon"}} | |||
</span> | |||
{{svg "octicon-triangle-down" 14 "dropdown icon"}} | |||
<div class="menu"> | |||
<a class="{{if eq .ViewType "all"}}active {{end}}item" href="{{$.Link}}?q={{$.Keyword}}&type=all&sort={{$.SortType}}&state={{$.State}}&labels={{.SelectLabels}}&milestone={{$.MilestoneID}}&project={{$.ProjectID}}&assignee={{$.AssigneeID}}&poster={{$.PosterID}}">{{.locale.Tr "repo.issues.filter_type.all_issues"}}</a> | |||
<a class="{{if eq .ViewType "assigned"}}active {{end}}item" href="{{$.Link}}?q={{$.Keyword}}&type=assigned&sort={{$.SortType}}&state={{$.State}}&labels={{.SelectLabels}}&milestone={{$.MilestoneID}}&project={{$.ProjectID}}&assignee={{$.AssigneeID}}&poster={{$.PosterID}}">{{.locale.Tr "repo.issues.filter_type.assigned_to_you"}}</a> | |||
@@ -179,8 +179,8 @@ | |||
<div class="list-header-sort ui small dropdown downward type jump item"> | |||
<span class="text"> | |||
{{.locale.Tr "repo.issues.filter_sort"}} | |||
{{svg "octicon-triangle-down" 14 "dropdown icon"}} | |||
</span> | |||
{{svg "octicon-triangle-down" 14 "dropdown icon"}} | |||
<div class="menu"> | |||
<a class="{{if or (eq .SortType "latest") (not .SortType)}}active {{end}}item" href="{{$.Link}}?q={{$.Keyword}}&type={{$.ViewType}}&sort=latest&state={{$.State}}&labels={{.SelectLabels}}&milestone={{$.MilestoneID}}&project={{$.ProjectID}}&assignee={{$.AssigneeID}}&poster={{$.PosterID}}">{{.locale.Tr "repo.issues.filter_sort.latest"}}</a> | |||
<a class="{{if eq .SortType "oldest"}}active {{end}}item" href="{{$.Link}}?q={{$.Keyword}}&type={{$.ViewType}}&sort=oldest&state={{$.State}}&labels={{.SelectLabels}}&milestone={{$.MilestoneID}}&project={{$.ProjectID}}&assignee={{$.AssigneeID}}&poster={{$.PosterID}}">{{.locale.Tr "repo.issues.filter_sort.oldest"}}</a> |
@@ -1,14 +1,14 @@ | |||
<h4 class="ui top attached header"> | |||
{{.locale.Tr "repo.issues.label_count" .NumLabels}} | |||
<div class="ui right"> | |||
<div class="ui right floated secondary filter menu"> | |||
<div class="ui secondary menu"> | |||
<!-- Sort --> | |||
<div class="ui dropdown type jump item"> | |||
<div class="item ui jump dropdown gt-py-3"> | |||
<span class="text"> | |||
{{.locale.Tr "repo.issues.filter_sort"}} | |||
{{svg "octicon-triangle-down" 14 "dropdown icon"}} | |||
</span> | |||
<div class="menu"> | |||
{{svg "octicon-triangle-down" 14 "dropdown icon"}} | |||
<div class="left menu"> | |||
<a class="{{if or (eq .SortType "alphabetically") (not .SortType)}}active {{end}}item" href="{{$.Link}}?sort=alphabetically&state={{$.State}}">{{.locale.Tr "repo.issues.label.filter_sort.alphabetically"}}</a> | |||
<a class="{{if eq .SortType "reversealphabetically"}}active {{end}}item" href="{{$.Link}}?sort=reversealphabetically&state={{$.State}}">{{.locale.Tr "repo.issues.label.filter_sort.reverse_alphabetically"}}</a> | |||
<a class="{{if eq .SortType "leastissues"}}active {{end}}item" href="{{$.Link}}?sort=leastissues&state={{$.State}}">{{.locale.Tr "repo.milestones.filter_sort.least_issues"}}</a> |
@@ -54,8 +54,8 @@ | |||
<div class="ui {{if not .Labels}}disabled{{end}} dropdown jump item"> | |||
<span class="text"> | |||
{{.locale.Tr "repo.issues.action_label"}} | |||
{{svg "octicon-triangle-down" 14 "dropdown icon"}} | |||
</span> | |||
{{svg "octicon-triangle-down" 14 "dropdown icon"}} | |||
<div class="menu"> | |||
<div class="item issue-action" data-action="clear" data-url="{{$.RepoLink}}/issues/labels"> | |||
{{.locale.Tr "repo.issues.new.clear_labels"}} | |||
@@ -78,8 +78,8 @@ | |||
<div class="ui {{if not (or .OpenMilestones .ClosedMilestones)}}disabled{{end}} dropdown jump item"> | |||
<span class="text"> | |||
{{.locale.Tr "repo.issues.action_milestone"}} | |||
{{svg "octicon-triangle-down" 14 "dropdown icon"}} | |||
</span> | |||
{{svg "octicon-triangle-down" 14 "dropdown icon"}} | |||
<div class="menu"> | |||
<div class="item issue-action" data-element-id="0" data-url="{{$.Link}}/milestone"> | |||
{{.locale.Tr "repo.issues.action_milestone_no_select"}} | |||
@@ -109,8 +109,8 @@ | |||
<div class="ui{{if not (or .OpenProjects .ClosedProjects)}} disabled{{end}} dropdown jump item"> | |||
<span class="text"> | |||
{{.locale.Tr "repo.project_board"}} | |||
{{svg "octicon-triangle-down" 14 "dropdown icon"}} | |||
</span> | |||
{{svg "octicon-triangle-down" 14 "dropdown icon"}} | |||
<div class="menu"> | |||
<div class="item issue-action" data-element-id="0" data-url="{{$.Link}}/projects"> | |||
{{.locale.Tr "repo.issues.new.clear_projects"}} | |||
@@ -144,8 +144,8 @@ | |||
<div class="ui {{if not .Assignees}}disabled{{end}} dropdown jump item"> | |||
<span class="text"> | |||
{{.locale.Tr "repo.issues.action_assignee"}} | |||
{{svg "octicon-triangle-down" 14 "dropdown icon"}} | |||
</span> | |||
{{svg "octicon-triangle-down" 14 "dropdown icon"}} | |||
<div class="menu"> | |||
<div class="item issue-action" data-action="clear" data-url="{{$.Link}}/assignee"> | |||
{{.locale.Tr "repo.issues.new.clear_assignees"}} |
@@ -37,8 +37,8 @@ | |||
<div class="list-header-sort ui small dropdown type jump item"> | |||
<span class="text"> | |||
{{.locale.Tr "repo.issues.filter_sort"}} | |||
{{svg "octicon-triangle-down" 14 "dropdown icon"}} | |||
</span> | |||
{{svg "octicon-triangle-down" 14 "dropdown icon"}} | |||
<div class="menu"> | |||
<a class="{{if or (eq .SortType "closestduedate") (not .SortType)}}active {{end}}item" href="{{$.Link}}?sort=closestduedate&state={{$.State}}&q={{$.Keyword}}">{{.locale.Tr "repo.milestones.filter_sort.earliest_due_data"}}</a> | |||
<a class="{{if eq .SortType "furthestduedate"}}active {{end}}item" href="{{$.Link}}?sort=furthestduedate&state={{$.State}}&q={{$.Keyword}}">{{.locale.Tr "repo.milestones.filter_sort.latest_due_date"}}</a> |
@@ -59,8 +59,8 @@ | |||
<div class="list-header-sort ui dropdown type jump item"> | |||
<span class="text"> | |||
{{.locale.Tr "repo.issues.filter_sort"}} | |||
{{svg "octicon-triangle-down" 14 "dropdown icon"}} | |||
</span> | |||
{{svg "octicon-triangle-down" 14 "dropdown icon"}} | |||
<div class="menu"> | |||
<a class="{{if or (eq .SortType "closestduedate") (not .SortType)}}active {{end}}item" href="{{$.Link}}?repos=[{{range $.RepoIDs}}{{.}}%2C{{end}}]&sort=closestduedate&state={{$.State}}&q={{$.Keyword}}">{{.locale.Tr "repo.milestones.filter_sort.closest_due_date"}}</a> | |||
<a class="{{if eq .SortType "furthestduedate"}}active {{end}}item" href="{{$.Link}}?repos=[{{range $.RepoIDs}}{{.}}%2C{{end}}]&sort=furthestduedate&state={{$.State}}&q={{$.Keyword}}">{{.locale.Tr "repo.milestones.filter_sort.furthest_due_date"}}</a> |
@@ -53,8 +53,8 @@ | |||
{{else}} | |||
{{.locale.Tr "org.teams"}} | |||
{{end}} | |||
{{svg "octicon-triangle-down" 14 "dropdown icon"}} | |||
</span> | |||
{{svg "octicon-triangle-down" 14 "dropdown icon"}} | |||
<div class="context user overflow menu"> | |||
<div class="ui header"> | |||
{{.locale.Tr "home.filter_by_team_repositories"}} |
@@ -33,8 +33,8 @@ | |||
<div class="ui dropdown type jump item"> | |||
<span class="text"> | |||
{{.locale.Tr "repo.issues.filter_type"}} | |||
{{svg "octicon-triangle-down" 14 "dropdown icon"}} | |||
</span> | |||
{{svg "octicon-triangle-down" 14 "dropdown icon"}} | |||
<div class="menu"> | |||
<a class="{{if or (eq .IssueType "all") (not .IssueType)}}active {{end}}item" href="{{$.Link}}?sort={{$.SortType}}&state={{$.State}}&issueType=all&labels={{$.Labels}}">{{.locale.Tr "all"}}</a> | |||
<a class="{{if eq .IssueType "issues"}}active {{end}}item" href="{{$.Link}}?sort={{$.SortType}}&state={{$.State}}&issueType=issues&labels={{$.Labels}}">{{.locale.Tr "issues"}}</a> | |||
@@ -46,8 +46,8 @@ | |||
<div class="ui dropdown type jump item"> | |||
<span class="text"> | |||
{{.locale.Tr "repo.issues.filter_sort"}} | |||
{{svg "octicon-triangle-down" 14 "dropdown icon"}} | |||
</span> | |||
{{svg "octicon-triangle-down" 14 "dropdown icon"}} | |||
<div class="menu"> | |||
<a class="{{if or (eq .SortType "latest") (not .SortType)}}active {{end}}item" href="{{$.Link}}?sort=latest&state={{$.State}}&issueType={{$.IssueType}}&labels={{$.Labels}}">{{.locale.Tr "repo.issues.filter_sort.latest"}}</a> | |||
<a class="{{if eq .SortType "oldest"}}active {{end}}item" href="{{$.Link}}?sort=oldest&state={{$.State}}&issueType={{$.IssueType}}&labels={{$.Labels}}">{{.locale.Tr "repo.issues.filter_sort.oldest"}}</a> |