Browse Source

Convert xorm literal queries to method calls (#2253)

tags/v1.2.0-rc1
G 6 years ago
parent
commit
34df9deff1
2 changed files with 2 additions and 4 deletions
  1. 1
    2
      models/migrations/migrations.go
  2. 1
    2
      models/migrations/v28.go

+ 1
- 2
models/migrations/migrations.go View File

offset := 0 offset := 0
for { for {
beans := make([]*Bean, 0, 100) beans := make([]*Bean, 0, 100)
if err = x.SQL(fmt.Sprintf("SELECT * FROM `%s` ORDER BY id ASC LIMIT 100 OFFSET %d",
table.name, offset)).Find(&beans); err != nil {
if err = x.Table(table.name).Asc("id").Limit(100, offset).Find(&beans); err != nil {
return fmt.Errorf("select beans [table: %s, offset: %d]: %v", table.name, offset, err) return fmt.Errorf("select beans [table: %s, offset: %d]: %v", table.name, offset, err)
} }
log.Trace("Table [%s]: offset: %d, beans: %d", table.name, offset, len(beans)) log.Trace("Table [%s]: offset: %d, beans: %d", table.name, offset, len(beans))

+ 1
- 2
models/migrations/v28.go View File

offset := 0 offset := 0
for { for {
repos := make([]*Repository, 0, 10) repos := make([]*Repository, 0, 10)
if err = x.Sql(fmt.Sprintf("SELECT * FROM `repository` ORDER BY id ASC LIMIT 10 OFFSET %d", offset)).
Find(&repos); err != nil {
if err = x.Table("repository").Asc("id").Limit(10, offset).Find(&repos); err != nil {
return fmt.Errorf("select repos [offset: %d]: %v", offset, err) return fmt.Errorf("select repos [offset: %d]: %v", offset, err)
} }
log.Trace("Select [offset: %d, repos: %d]", offset, len(repos)) log.Trace("Select [offset: %d, repos: %d]", offset, len(repos))

Loading…
Cancel
Save