Browse Source

Solving the issue of UI disruption when the review is deleted without refreshing (#29951) (#29968)

backport #29951
tags/v1.21.9
HEREYUA 1 month ago
parent
commit
3ff3c5ba78
No account linked to committer's email address
1 changed files with 7 additions and 1 deletions
  1. 7
    1
      web_src/js/features/repo-issue.js

+ 7
- 1
web_src/js/features/repo-issue.js View File

@@ -162,7 +162,8 @@ export function initRepoIssueCommentDelete() {
_csrf: csrfToken,
}).done(() => {
const $conversationHolder = $this.closest('.conversation-holder');

const $parentTimelineItem = $this.closest('.timeline-item');
const $parentTimelineGroup = $this.closest('.timeline-item-group');
// Check if this was a pending comment.
if ($conversationHolder.find('.pending-label').length) {
const $counter = $('#review-box .review-comments-counter');
@@ -185,6 +186,11 @@ export function initRepoIssueCommentDelete() {
}
$conversationHolder.remove();
}
// Check if there is no review content, move the time avatar upward to avoid overlapping the content below.
if (!$parentTimelineGroup.find('.timeline-item.comment').length && !$parentTimelineItem.find('.conversation-holder').length) {
const $timelineAvatar = $parentTimelineGroup.find('.timeline-avatar');
$timelineAvatar.removeClass('timeline-avatar-offset');
}
});
}
return false;

Loading…
Cancel
Save