* Fix input field max length for release, label and milestone forms * Add max length for isseu and PR titletags/v1.10.1
@@ -499,9 +499,9 @@ func (f SubmitReviewForm) HasEmptyContent() bool { | |||
// NewReleaseForm form for creating release | |||
type NewReleaseForm struct { | |||
TagName string `binding:"Required;GitRefName"` | |||
Target string `form:"tag_target" binding:"Required"` | |||
Title string `binding:"Required"` | |||
TagName string `binding:"Required;GitRefName;MaxSize(255)"` | |||
Target string `form:"tag_target" binding:"Required;MaxSize(255)"` | |||
Title string `binding:"Required;MaxSize(255)"` | |||
Content string | |||
Draft string | |||
Prerelease bool | |||
@@ -515,7 +515,7 @@ func (f *NewReleaseForm) Validate(ctx *macaron.Context, errs binding.Errors) bin | |||
// EditReleaseForm form for changing release | |||
type EditReleaseForm struct { | |||
Title string `form:"title" binding:"Required"` | |||
Title string `form:"title" binding:"Required;MaxSize(255)"` | |||
Content string `form:"content"` | |||
Draft string `form:"draft"` | |||
Prerelease bool `form:"prerelease"` |
@@ -17,16 +17,16 @@ | |||
<div class="ui grid"> | |||
<div class="three wide column"> | |||
<div class="ui small input"> | |||
<input class="new-label-input emoji-input" name="title" placeholder="{{.i18n.Tr "repo.issues.new_label_placeholder"}}" autofocus required> | |||
<input class="new-label-input emoji-input" name="title" placeholder="{{.i18n.Tr "repo.issues.new_label_placeholder"}}" autofocus required maxlength="50"> | |||
</div> | |||
</div> | |||
<div class="five wide column"> | |||
<div class="ui small fluid input"> | |||
<input class="new-label-desc-input" name="description" placeholder="{{.i18n.Tr "repo.issues.new_label_desc_placeholder"}}"> | |||
<input class="new-label-desc-input" name="description" placeholder="{{.i18n.Tr "repo.issues.new_label_desc_placeholder"}}" maxlength="200"> | |||
</div> | |||
</div> | |||
<div class="color picker column"> | |||
<input class="color-picker" name="color" value="#70c24a" required> | |||
<input class="color-picker" name="color" value="#70c24a" required maxlength="7"> | |||
</div> | |||
<div class="column precolors"> | |||
{{template "repo/issue/label_precolors"}} | |||
@@ -151,16 +151,16 @@ | |||
<div class="ui grid"> | |||
<div class="three wide column"> | |||
<div class="ui small input"> | |||
<input class="new-label-input emoji-input" name="title" placeholder="{{.i18n.Tr "repo.issues.new_label_placeholder"}}" autofocus required> | |||
<input class="new-label-input emoji-input" name="title" placeholder="{{.i18n.Tr "repo.issues.new_label_placeholder"}}" autofocus required maxlength="50"> | |||
</div> | |||
</div> | |||
<div class="five wide column"> | |||
<div class="ui small fluid input"> | |||
<input class="new-label-desc-input" name="description" placeholder="{{.i18n.Tr "repo.issues.new_label_desc_placeholder"}}"> | |||
<input class="new-label-desc-input" name="description" placeholder="{{.i18n.Tr "repo.issues.new_label_desc_placeholder"}}" maxlength="200"> | |||
</div> | |||
</div> | |||
<div class="color picker column"> | |||
<input class="color-picker" name="color" value="#70c24a" required> | |||
<input class="color-picker" name="color" value="#70c24a" required maxlength="7"> | |||
</div> | |||
<div class="column precolors"> | |||
{{template "repo/issue/label_precolors"}} |
@@ -26,7 +26,7 @@ | |||
<div class="eleven wide column"> | |||
<div class="field {{if .Err_Title}}error{{end}}"> | |||
<label>{{.i18n.Tr "repo.milestones.title"}}</label> | |||
<input name="title" placeholder="{{.i18n.Tr "repo.milestones.title"}}" value="{{.title}}" autofocus required> | |||
<input name="title" placeholder="{{.i18n.Tr "repo.milestones.title"}}" value="{{.title}}" autofocus required maxlength="50"> | |||
</div> | |||
<div class="field"> | |||
<label>{{.i18n.Tr "repo.milestones.desc"}}</label> |
@@ -13,7 +13,7 @@ | |||
</a> | |||
<div class="ui segment content"> | |||
<div class="field"> | |||
<input name="title" id="issue_title" placeholder="{{.i18n.Tr "repo.milestones.title"}}" value="{{.title}}" tabindex="3" autofocus required> | |||
<input name="title" id="issue_title" placeholder="{{.i18n.Tr "repo.milestones.title"}}" value="{{.title}}" tabindex="3" autofocus required maxlength="255"> | |||
{{if .PageIsComparePull}} | |||
<span class="title_wip_desc">{{.i18n.Tr "repo.pulls.title_wip_desc" (index .PullRequestWorkInProgressPrefixes 0| Escape) | Safe}}</span> | |||
{{end}} |
@@ -3,7 +3,7 @@ | |||
<h1 class="twelve wide column"> | |||
<span class="index">#{{.Issue.Index}}</span> <span id="issue-title" class="has-emoji">{{.Issue.Title}}</span> | |||
<div id="edit-title-input" class="ui input" style="display: none"> | |||
<input value="{{.Issue.Title}}"> | |||
<input value="{{.Issue.Title}}" maxlength="255"> | |||
</div> | |||
</h1> | |||
{{if and (or .IsIssueWriter .IsIssuePoster) (not .Repository.IsArchived)}} |
@@ -19,7 +19,7 @@ | |||
{{if .PageIsEditRelease}} | |||
<b>{{.tag_name}}</b><span class="at">@</span><strong>{{.tag_target}}</strong> | |||
{{else}} | |||
<input id="tag-name" name="tag_name" value="{{.tag_name}}" placeholder="{{.i18n.Tr "repo.release.tag_name"}}" autofocus required> | |||
<input id="tag-name" name="tag_name" value="{{.tag_name}}" placeholder="{{.i18n.Tr "repo.release.tag_name"}}" autofocus required maxlength="255"> | |||
<span class="at">@</span> | |||
<div class="ui selection dropdown"> | |||
<input type="hidden" name="tag_target" value="{{.tag_target}}"/> | |||
@@ -42,7 +42,7 @@ | |||
<div class="eleven wide column"> | |||
<div class="field {{if .Err_Title}}error{{end}}"> | |||
<label>{{.i18n.Tr "repo.release.title"}}</label> | |||
<input name="title" placeholder="{{.i18n.Tr "repo.release.title"}}" value="{{.title}}" autofocus required> | |||
<input name="title" placeholder="{{.i18n.Tr "repo.release.title"}}" value="{{.title}}" autofocus required maxlength="255"> | |||
</div> | |||
<div class="field"> | |||
<label>{{.i18n.Tr "repo.release.content"}}</label> |