瀏覽代碼

Remove unused parameter for some functions in `services/mirror` (#30724)

Suggested by gopls `unusedparams`
tags/v1.22.0-rc1
Chongyi Zheng 2 月之前
父節點
當前提交
4ae6b1a553
沒有連結到貢獻者的電子郵件帳戶。
共有 2 個檔案被更改,包括 5 行新增5 行删除
  1. 3
    3
      services/mirror/mirror.go
  2. 2
    2
      services/mirror/mirror_pull.go

+ 3
- 3
services/mirror/mirror.go 查看文件

} }
log.Trace("Doing: Update") log.Trace("Doing: Update")


handler := func(idx int, bean any) error {
handler := func(bean any) error {
var repo *repo_model.Repository var repo *repo_model.Repository
var mirrorType SyncType var mirrorType SyncType
var referenceID int64 var referenceID int64
pullMirrorsRequested := 0 pullMirrorsRequested := 0
if pullLimit != 0 { if pullLimit != 0 {
if err := repo_model.MirrorsIterate(ctx, pullLimit, func(idx int, bean any) error { if err := repo_model.MirrorsIterate(ctx, pullLimit, func(idx int, bean any) error {
if err := handler(idx, bean); err != nil {
if err := handler(bean); err != nil {
return err return err
} }
pullMirrorsRequested++ pullMirrorsRequested++
pushMirrorsRequested := 0 pushMirrorsRequested := 0
if pushLimit != 0 { if pushLimit != 0 {
if err := repo_model.PushMirrorsIterate(ctx, pushLimit, func(idx int, bean any) error { if err := repo_model.PushMirrorsIterate(ctx, pushLimit, func(idx int, bean any) error {
if err := handler(idx, bean); err != nil {
if err := handler(bean); err != nil {
return err return err
} }
pushMirrorsRequested++ pushMirrorsRequested++

+ 2
- 2
services/mirror/mirror_pull.go 查看文件



log.Trace("SyncMirrors [repo: %-v]: %d branches updated", m.Repo, len(results)) log.Trace("SyncMirrors [repo: %-v]: %d branches updated", m.Repo, len(results))
if len(results) > 0 { if len(results) > 0 {
if ok := checkAndUpdateEmptyRepository(ctx, m, gitRepo, results); !ok {
if ok := checkAndUpdateEmptyRepository(ctx, m, results); !ok {
log.Error("SyncMirrors [repo: %-v]: checkAndUpdateEmptyRepository: %v", m.Repo, err) log.Error("SyncMirrors [repo: %-v]: checkAndUpdateEmptyRepository: %v", m.Repo, err)
return false return false
} }
return true return true
} }


func checkAndUpdateEmptyRepository(ctx context.Context, m *repo_model.Mirror, gitRepo *git.Repository, results []*mirrorSyncResult) bool {
func checkAndUpdateEmptyRepository(ctx context.Context, m *repo_model.Mirror, results []*mirrorSyncResult) bool {
if !m.Repo.IsEmpty { if !m.Repo.IsEmpty {
return true return true
} }

Loading…
取消
儲存