Fix #26731 Almost all "tabindex" in code are incorrect. 1. All "input/button" by default are focusable, so no need to use "tabindex=0" 2. All "div/span" by default are not focusable, so no need to use "tabindex=-1" 3. All "dropdown" are focusable by framework, so no need to use "tabindex" 4. Some tabindex values are incorrect (eg: `new_form.tmpl`), so remove them Co-authored-by: Giteabot <teabot@gitea.io>tags/v1.21.0-rc0
@@ -19,15 +19,15 @@ | |||
<span class="inline required field"><label for="visibility">{{.locale.Tr "org.settings.visibility"}}</label></span> | |||
<div class="inline-grouped-list"> | |||
<div class="ui radio checkbox"> | |||
<input class="enable-system-radio" tabindex="0" name="visibility" type="radio" value="0" {{if .DefaultOrgVisibilityMode.IsPublic}}checked{{end}}> | |||
<input class="enable-system-radio" name="visibility" type="radio" value="0" {{if .DefaultOrgVisibilityMode.IsPublic}}checked{{end}}> | |||
<label>{{.locale.Tr "org.settings.visibility.public"}}</label> | |||
</div> | |||
<div class="ui radio checkbox"> | |||
<input class="enable-system-radio" tabindex="0" name="visibility" type="radio" value="1" {{if .DefaultOrgVisibilityMode.IsLimited}}checked{{end}}> | |||
<input class="enable-system-radio" name="visibility" type="radio" value="1" {{if .DefaultOrgVisibilityMode.IsLimited}}checked{{end}}> | |||
<label>{{.locale.Tr "org.settings.visibility.limited"}}</label> | |||
</div> | |||
<div class="ui radio checkbox"> | |||
<input class="enable-system-radio" tabindex="0" name="visibility" type="radio" value="2" {{if .DefaultOrgVisibilityMode.IsPrivate}}checked{{end}}> | |||
<input class="enable-system-radio" name="visibility" type="radio" value="2" {{if .DefaultOrgVisibilityMode.IsPrivate}}checked{{end}}> | |||
<label>{{.locale.Tr "org.settings.visibility.private"}}</label> | |||
</div> | |||
</div> |
@@ -40,19 +40,19 @@ | |||
<label for="visibility">{{.locale.Tr "org.settings.visibility"}}</label> | |||
<div class="field"> | |||
<div class="ui radio checkbox"> | |||
<input class="enable-system-radio" tabindex="0" name="visibility" type="radio" value="0" {{if eq .CurrentVisibility 0}}checked{{end}}> | |||
<input class="enable-system-radio" name="visibility" type="radio" value="0" {{if eq .CurrentVisibility 0}}checked{{end}}> | |||
<label>{{.locale.Tr "org.settings.visibility.public"}}</label> | |||
</div> | |||
</div> | |||
<div class="field"> | |||
<div class="ui radio checkbox"> | |||
<input class="enable-system-radio" tabindex="0" name="visibility" type="radio" value="1" {{if eq .CurrentVisibility 1}}checked{{end}}> | |||
<input class="enable-system-radio" name="visibility" type="radio" value="1" {{if eq .CurrentVisibility 1}}checked{{end}}> | |||
<label>{{.locale.Tr "org.settings.visibility.limited"}}</label> | |||
</div> | |||
</div> | |||
<div class="field"> | |||
<div class="ui radio checkbox"> | |||
<input class="enable-system-radio" tabindex="0" name="visibility" type="radio" value="2" {{if eq .CurrentVisibility 2}}checked{{end}}> | |||
<input class="enable-system-radio" name="visibility" type="radio" value="2" {{if eq .CurrentVisibility 2}}checked{{end}}> | |||
<label>{{.locale.Tr "org.settings.visibility.private"}}</label> | |||
</div> | |||
</div> |
@@ -76,10 +76,10 @@ | |||
</div> | |||
{{if and $canWriteProject (ne .ID 0)}} | |||
<div class="ui dropdown jump item"> | |||
<div class="gt-px-3" tabindex="-1"> | |||
<div class="gt-px-3"> | |||
{{svg "octicon-kebab-horizontal"}} | |||
</div> | |||
<div class="menu user-menu" tabindex="-1"> | |||
<div class="menu user-menu"> | |||
<a class="item show-modal button" data-modal="#edit-project-column-modal-{{.ID}}"> | |||
{{svg "octicon-pencil"}} | |||
{{ctx.Locale.Tr "repo.projects.column.edit"}} |
@@ -77,40 +77,40 @@ | |||
<div class="inline field"> | |||
<label>{{.locale.Tr "repo.template.items"}}</label> | |||
<div class="ui checkbox"> | |||
<input name="git_content" type="checkbox" tabindex="0" {{if .git_content}}checked{{end}}> | |||
<input name="git_content" type="checkbox" {{if .git_content}}checked{{end}}> | |||
<label>{{.locale.Tr "repo.template.git_content"}}</label> | |||
</div> | |||
<div class="ui checkbox" {{if not .SignedUser.CanEditGitHook}}data-tooltip-content="{{.locale.Tr "repo.template.git_hooks_tooltip"}}"{{end}}> | |||
<input name="git_hooks" type="checkbox" tabindex="0" {{if .git_hooks}}checked{{end}}> | |||
<input name="git_hooks" type="checkbox" {{if .git_hooks}}checked{{end}}> | |||
<label>{{.locale.Tr "repo.template.git_hooks"}}</label> | |||
</div> | |||
</div> | |||
<div class="inline field"> | |||
<label></label> | |||
<div class="ui checkbox"> | |||
<input name="webhooks" type="checkbox" tabindex="0" {{if .webhooks}}checked{{end}}> | |||
<input name="webhooks" type="checkbox" {{if .webhooks}}checked{{end}}> | |||
<label>{{.locale.Tr "repo.template.webhooks"}}</label> | |||
</div> | |||
<div class="ui checkbox"> | |||
<input name="topics" type="checkbox" tabindex="0" {{if .topics}}checked{{end}}> | |||
<input name="topics" type="checkbox" {{if .topics}}checked{{end}}> | |||
<label>{{.locale.Tr "repo.template.topics"}}</label> | |||
</div> | |||
</div> | |||
<div class="inline field"> | |||
<label></label> | |||
<div class="ui checkbox"> | |||
<input name="avatar" type="checkbox" tabindex="0" {{if .avatar}}checked{{end}}> | |||
<input name="avatar" type="checkbox" {{if .avatar}}checked{{end}}> | |||
<label>{{.locale.Tr "repo.template.avatar"}}</label> | |||
</div> | |||
<div class="ui checkbox"> | |||
<input name="labels" type="checkbox" tabindex="0" {{if .labels}}checked{{end}}> | |||
<input name="labels" type="checkbox" {{if .labels}}checked{{end}}> | |||
<label>{{.locale.Tr "repo.template.issue_labels"}}</label> | |||
</div> | |||
</div> | |||
<div class="inline field"> | |||
<label></label> | |||
<div class="ui checkbox"> | |||
<input name="protected_branch" type="checkbox" tabindex="0" {{if .protected_branch}}checked{{end}}> | |||
<input name="protected_branch" type="checkbox" {{if .protected_branch}}checked{{end}}> | |||
<label>{{.locale.Tr "repo.settings.protected_branch"}}</label> | |||
</div> | |||
</div> | |||
@@ -176,7 +176,7 @@ | |||
</div> | |||
<div class="inline field"> | |||
<div class="ui checkbox" id="auto-init"> | |||
<input name="auto_init" type="checkbox" tabindex="0" {{if .auto_init}}checked{{end}}> | |||
<input name="auto_init" type="checkbox" {{if .auto_init}}checked{{end}}> | |||
<label>{{.locale.Tr "repo.auto_init"}}</label> | |||
</div> | |||
</div> | |||
@@ -211,7 +211,7 @@ | |||
<div class="inline field"> | |||
<label>{{.locale.Tr "repo.template"}}</label> | |||
<div class="ui checkbox"> | |||
<input name="template" type="checkbox" tabindex="0"> | |||
<input name="template" type="checkbox"> | |||
<label>{{.locale.Tr "repo.template_helper"}}</label> | |||
</div> | |||
</div> |
@@ -16,7 +16,7 @@ | |||
</div> | |||
<div class="inline field"> | |||
<div class="ui checkbox"> | |||
<input name="signoff" type="checkbox" tabindex="0"> | |||
<input name="signoff" type="checkbox"> | |||
<label>{{.locale.Tr "repo.editor.signoff_desc"}}</label> | |||
</div> | |||
</div> |
@@ -11,7 +11,7 @@ | |||
{{ctx.AvatarUtils.Avatar .SignedUser 40}} | |||
<div class="ui segment content gt-my-0"> | |||
<div class="field"> | |||
<input name="title" id="issue_title" placeholder="{{.locale.Tr "repo.milestones.title"}}" value="{{if .TitleQuery}}{{.TitleQuery}}{{else if .IssueTemplateTitle}}{{.IssueTemplateTitle}}{{else}}{{.title}}{{end}}" tabindex="3" autofocus required maxlength="255" autocomplete="off"> | |||
<input name="title" id="issue_title" placeholder="{{.locale.Tr "repo.milestones.title"}}" value="{{if .TitleQuery}}{{.TitleQuery}}{{else if .IssueTemplateTitle}}{{.IssueTemplateTitle}}{{else}}{{.title}}{{end}}" autofocus required maxlength="255" autocomplete="off"> | |||
{{if .PageIsComparePull}} | |||
<div class="title_wip_desc" data-wip-prefixes="{{JsonUtils.EncodeToString .PullRequestWorkInProgressPrefixes}}">{{.locale.Tr "repo.pulls.title_wip_desc" (index .PullRequestWorkInProgressPrefixes 0| Escape) | Safe}}</div> | |||
{{end}} | |||
@@ -35,7 +35,7 @@ | |||
{{template "repo/issue/comment_tab" .}} | |||
{{end}} | |||
<div class="text right"> | |||
<button class="ui green button" tabindex="6"> | |||
<button class="ui green button"> | |||
{{if .PageIsComparePull}} | |||
{{.locale.Tr "repo.pulls.create"}} | |||
{{else}} |
@@ -621,7 +621,7 @@ | |||
</div> | |||
<div class="field"> | |||
<div class="ui fluid dropdown selection" tabindex="0"> | |||
<div class="ui fluid dropdown selection"> | |||
<select name="reason"> | |||
<option value=""> </option> |
@@ -315,13 +315,13 @@ | |||
<div class="field{{if not $isWikiEnabled}} disabled{{end}}" id="wiki_box"> | |||
<div class="field"> | |||
<div class="ui radio checkbox{{if $isWikiGlobalDisabled}} disabled{{end}}"{{if $isWikiGlobalDisabled}} data-tooltip-content="{{.locale.Tr "repo.unit_disabled"}}"{{end}}> | |||
<input class="enable-system-radio" tabindex="0" name="enable_external_wiki" type="radio" value="false" data-target="#external_wiki_box" {{if not (.Repository.UnitEnabled $.Context $.UnitTypeExternalWiki)}}checked{{end}}> | |||
<input class="enable-system-radio" name="enable_external_wiki" type="radio" value="false" data-target="#external_wiki_box" {{if not (.Repository.UnitEnabled $.Context $.UnitTypeExternalWiki)}}checked{{end}}> | |||
<label>{{.locale.Tr "repo.settings.use_internal_wiki"}}</label> | |||
</div> | |||
</div> | |||
<div class="field"> | |||
<div class="ui radio checkbox{{if $isExternalWikiGlobalDisabled}} disabled{{end}}"{{if $isExternalWikiGlobalDisabled}} data-tooltip-content="{{.locale.Tr "repo.unit_disabled"}}"{{end}}> | |||
<input class="enable-system-radio" tabindex="0" name="enable_external_wiki" type="radio" value="true" data-target="#external_wiki_box" {{if .Repository.UnitEnabled $.Context $.UnitTypeExternalWiki}}checked{{end}}> | |||
<input class="enable-system-radio" name="enable_external_wiki" type="radio" value="true" data-target="#external_wiki_box" {{if .Repository.UnitEnabled $.Context $.UnitTypeExternalWiki}}checked{{end}}> | |||
<label>{{.locale.Tr "repo.settings.use_external_wiki"}}</label> | |||
</div> | |||
</div> | |||
@@ -348,7 +348,7 @@ | |||
<div class="field {{if not $isIssuesEnabled}}disabled{{end}}" id="issue_box"> | |||
<div class="field"> | |||
<div class="ui radio checkbox{{if $isIssuesGlobalDisabled}} disabled{{end}}"{{if $isIssuesGlobalDisabled}} data-tooltip-content="{{.locale.Tr "repo.unit_disabled"}}"{{end}}> | |||
<input class="enable-system-radio" tabindex="0" name="enable_external_tracker" type="radio" value="false" data-context="#internal_issue_box" data-target="#external_issue_box" {{if not (.Repository.UnitEnabled $.Context $.UnitTypeExternalTracker)}}checked{{end}}> | |||
<input class="enable-system-radio" name="enable_external_tracker" type="radio" value="false" data-context="#internal_issue_box" data-target="#external_issue_box" {{if not (.Repository.UnitEnabled $.Context $.UnitTypeExternalTracker)}}checked{{end}}> | |||
<label>{{.locale.Tr "repo.settings.use_internal_issue_tracker"}}</label> | |||
</div> | |||
</div> | |||
@@ -380,7 +380,7 @@ | |||
</div> | |||
<div class="field"> | |||
<div class="ui radio checkbox{{if $isExternalTrackerGlobalDisabled}} disabled{{end}}"{{if $isExternalTrackerGlobalDisabled}} data-tooltip-content="{{.locale.Tr "repo.unit_disabled"}}"{{end}}> | |||
<input class="enable-system-radio" tabindex="0" name="enable_external_tracker" type="radio" value="true" data-context="#internal_issue_box" data-target="#external_issue_box" {{if .Repository.UnitEnabled $.Context $.UnitTypeExternalTracker}}checked{{end}}> | |||
<input class="enable-system-radio" name="enable_external_tracker" type="radio" value="true" data-context="#internal_issue_box" data-target="#external_issue_box" {{if .Repository.UnitEnabled $.Context $.UnitTypeExternalTracker}}checked{{end}}> | |||
<label>{{.locale.Tr "repo.settings.use_external_issue_tracker"}}</label> | |||
</div> | |||
</div> | |||
@@ -523,7 +523,7 @@ | |||
<p> | |||
{{.locale.Tr "repo.settings.default_merge_style_desc"}} | |||
</p> | |||
<div class="ui dropdown selection" tabindex="0"> | |||
<div class="ui dropdown selection"> | |||
<select name="pulls_default_merge_style"> | |||
<option value="merge" {{if or (not $pullRequestEnabled) (eq $prUnit.PullRequestsConfig.DefaultMergeStyle "merge")}}selected{{end}}>{{.locale.Tr "repo.pulls.merge_pull_request"}}</option> | |||
<option value="rebase" {{if or (not $pullRequestEnabled) (eq $prUnit.PullRequestsConfig.DefaultMergeStyle "rebase")}}selected{{end}}>{{.locale.Tr "repo.pulls.rebase_merge_pull_request"}}</option> |
@@ -31,7 +31,7 @@ | |||
<div class="seven wide column"> | |||
<div class="field"> | |||
<div class="ui checkbox"> | |||
<input name="create" type="checkbox" tabindex="0" {{if .Webhook.Create}}checked{{end}}> | |||
<input name="create" type="checkbox" {{if .Webhook.Create}}checked{{end}}> | |||
<label>{{.locale.Tr "repo.settings.event_create"}}</label> | |||
<span class="help">{{.locale.Tr "repo.settings.event_create_desc"}}</span> | |||
</div> | |||
@@ -41,7 +41,7 @@ | |||
<div class="seven wide column"> | |||
<div class="field"> | |||
<div class="ui checkbox"> | |||
<input name="delete" type="checkbox" tabindex="0" {{if .Webhook.Delete}}checked{{end}}> | |||
<input name="delete" type="checkbox" {{if .Webhook.Delete}}checked{{end}}> | |||
<label>{{.locale.Tr "repo.settings.event_delete"}}</label> | |||
<span class="help">{{.locale.Tr "repo.settings.event_delete_desc"}}</span> | |||
</div> | |||
@@ -51,7 +51,7 @@ | |||
<div class="seven wide column"> | |||
<div class="field"> | |||
<div class="ui checkbox"> | |||
<input name="fork" type="checkbox" tabindex="0" {{if .Webhook.Fork}}checked{{end}}> | |||
<input name="fork" type="checkbox" {{if .Webhook.Fork}}checked{{end}}> | |||
<label>{{.locale.Tr "repo.settings.event_fork"}}</label> | |||
<span class="help">{{.locale.Tr "repo.settings.event_fork_desc"}}</span> | |||
</div> | |||
@@ -61,7 +61,7 @@ | |||
<div class="seven wide column"> | |||
<div class="field"> | |||
<div class="ui checkbox"> | |||
<input name="push" type="checkbox" tabindex="0" {{if .Webhook.Push}}checked{{end}}> | |||
<input name="push" type="checkbox" {{if .Webhook.Push}}checked{{end}}> | |||
<label>{{.locale.Tr "repo.settings.event_push"}}</label> | |||
<span class="help">{{.locale.Tr "repo.settings.event_push_desc"}}</span> | |||
</div> | |||
@@ -71,7 +71,7 @@ | |||
<div class="seven wide column"> | |||
<div class="field"> | |||
<div class="ui checkbox"> | |||
<input name="repository" type="checkbox" tabindex="0" {{if .Webhook.Repository}}checked{{end}}> | |||
<input name="repository" type="checkbox" {{if .Webhook.Repository}}checked{{end}}> | |||
<label>{{.locale.Tr "repo.settings.event_repository"}}</label> | |||
<span class="help">{{.locale.Tr "repo.settings.event_repository_desc"}}</span> | |||
</div> | |||
@@ -81,7 +81,7 @@ | |||
<div class="seven wide column"> | |||
<div class="field"> | |||
<div class="ui checkbox"> | |||
<input name="release" type="checkbox" tabindex="0" {{if .Webhook.Release}}checked{{end}}> | |||
<input name="release" type="checkbox" {{if .Webhook.Release}}checked{{end}}> | |||
<label>{{.locale.Tr "repo.settings.event_release"}}</label> | |||
<span class="help">{{.locale.Tr "repo.settings.event_release_desc"}}</span> | |||
</div> | |||
@@ -91,7 +91,7 @@ | |||
<div class="seven wide column"> | |||
<div class="field"> | |||
<div class="ui checkbox"> | |||
<input name="package" type="checkbox" tabindex="0" {{if .Webhook.Package}}checked{{end}}> | |||
<input name="package" type="checkbox" {{if .Webhook.Package}}checked{{end}}> | |||
<label>{{.locale.Tr "repo.settings.event_package"}}</label> | |||
<span class="help">{{.locale.Tr "repo.settings.event_package_desc"}}</span> | |||
</div> | |||
@@ -102,7 +102,7 @@ | |||
<div class="seven wide column"> | |||
<div class="field"> | |||
<div class="ui checkbox"> | |||
<input name="wiki" type="checkbox" tabindex="0" {{if .Webhook.Wiki}}checked{{end}}> | |||
<input name="wiki" type="checkbox" {{if .Webhook.Wiki}}checked{{end}}> | |||
<label>{{.locale.Tr "repo.settings.event_wiki"}}</label> | |||
<span class="help">{{.locale.Tr "repo.settings.event_wiki_desc"}}</span> | |||
</div> | |||
@@ -117,7 +117,7 @@ | |||
<div class="seven wide column"> | |||
<div class="field"> | |||
<div class="ui checkbox"> | |||
<input name="issues" type="checkbox" tabindex="0" {{if .Webhook.Issues}}checked{{end}}> | |||
<input name="issues" type="checkbox" {{if .Webhook.Issues}}checked{{end}}> | |||
<label>{{.locale.Tr "repo.settings.event_issues"}}</label> | |||
<span class="help">{{.locale.Tr "repo.settings.event_issues_desc"}}</span> | |||
</div> | |||
@@ -127,7 +127,7 @@ | |||
<div class="seven wide column"> | |||
<div class="field"> | |||
<div class="ui checkbox"> | |||
<input name="issue_assign" type="checkbox" tabindex="0" {{if .Webhook.IssueAssign}}checked{{end}}> | |||
<input name="issue_assign" type="checkbox" {{if .Webhook.IssueAssign}}checked{{end}}> | |||
<label>{{.locale.Tr "repo.settings.event_issue_assign"}}</label> | |||
<span class="help">{{.locale.Tr "repo.settings.event_issue_assign_desc"}}</span> | |||
</div> | |||
@@ -137,7 +137,7 @@ | |||
<div class="seven wide column"> | |||
<div class="field"> | |||
<div class="ui checkbox"> | |||
<input name="issue_label" type="checkbox" tabindex="0" {{if .Webhook.IssueLabel}}checked{{end}}> | |||
<input name="issue_label" type="checkbox" {{if .Webhook.IssueLabel}}checked{{end}}> | |||
<label>{{.locale.Tr "repo.settings.event_issue_label"}}</label> | |||
<span class="help">{{.locale.Tr "repo.settings.event_issue_label_desc"}}</span> | |||
</div> | |||
@@ -147,7 +147,7 @@ | |||
<div class="seven wide column"> | |||
<div class="field"> | |||
<div class="ui checkbox"> | |||
<input name="issue_milestone" type="checkbox" tabindex="0" {{if .Webhook.IssueMilestone}}checked{{end}}> | |||
<input name="issue_milestone" type="checkbox" {{if .Webhook.IssueMilestone}}checked{{end}}> | |||
<label>{{.locale.Tr "repo.settings.event_issue_milestone"}}</label> | |||
<span class="help">{{.locale.Tr "repo.settings.event_issue_milestone_desc"}}</span> | |||
</div> | |||
@@ -157,7 +157,7 @@ | |||
<div class="seven wide column"> | |||
<div class="field"> | |||
<div class="ui checkbox"> | |||
<input name="issue_comment" type="checkbox" tabindex="0" {{if .Webhook.IssueComment}}checked{{end}}> | |||
<input name="issue_comment" type="checkbox" {{if .Webhook.IssueComment}}checked{{end}}> | |||
<label>{{.locale.Tr "repo.settings.event_issue_comment"}}</label> | |||
<span class="help">{{.locale.Tr "repo.settings.event_issue_comment_desc"}}</span> | |||
</div> | |||
@@ -172,7 +172,7 @@ | |||
<div class="seven wide column"> | |||
<div class="field"> | |||
<div class="ui checkbox"> | |||
<input name="pull_request" type="checkbox" tabindex="0" {{if .Webhook.PullRequest}}checked{{end}}> | |||
<input name="pull_request" type="checkbox" {{if .Webhook.PullRequest}}checked{{end}}> | |||
<label>{{.locale.Tr "repo.settings.event_pull_request"}}</label> | |||
<span class="help">{{.locale.Tr "repo.settings.event_pull_request_desc"}}</span> | |||
</div> | |||
@@ -182,7 +182,7 @@ | |||
<div class="seven wide column"> | |||
<div class="field"> | |||
<div class="ui checkbox"> | |||
<input name="pull_request_assign" type="checkbox" tabindex="0" {{if .Webhook.PullRequestAssign}}checked{{end}}> | |||
<input name="pull_request_assign" type="checkbox" {{if .Webhook.PullRequestAssign}}checked{{end}}> | |||
<label>{{.locale.Tr "repo.settings.event_pull_request_assign"}}</label> | |||
<span class="help">{{.locale.Tr "repo.settings.event_pull_request_assign_desc"}}</span> | |||
</div> | |||
@@ -192,7 +192,7 @@ | |||
<div class="seven wide column"> | |||
<div class="field"> | |||
<div class="ui checkbox"> | |||
<input name="pull_request_label" type="checkbox" tabindex="0" {{if .Webhook.PullRequestLabel}}checked{{end}}> | |||
<input name="pull_request_label" type="checkbox" {{if .Webhook.PullRequestLabel}}checked{{end}}> | |||
<label>{{.locale.Tr "repo.settings.event_pull_request_label"}}</label> | |||
<span class="help">{{.locale.Tr "repo.settings.event_pull_request_label_desc"}}</span> | |||
</div> | |||
@@ -202,7 +202,7 @@ | |||
<div class="seven wide column"> | |||
<div class="field"> | |||
<div class="ui checkbox"> | |||
<input name="pull_request_milestone" type="checkbox" tabindex="0" {{if .Webhook.PullRequestMilestone}}checked{{end}}> | |||
<input name="pull_request_milestone" type="checkbox" {{if .Webhook.PullRequestMilestone}}checked{{end}}> | |||
<label>{{.locale.Tr "repo.settings.event_pull_request_milestone"}}</label> | |||
<span class="help">{{.locale.Tr "repo.settings.event_pull_request_milestone_desc"}}</span> | |||
</div> | |||
@@ -212,7 +212,7 @@ | |||
<div class="seven wide column"> | |||
<div class="field"> | |||
<div class="ui checkbox"> | |||
<input name="pull_request_comment" type="checkbox" tabindex="0" {{if .Webhook.PullRequestComment}}checked{{end}}> | |||
<input name="pull_request_comment" type="checkbox" {{if .Webhook.PullRequestComment}}checked{{end}}> | |||
<label>{{.locale.Tr "repo.settings.event_pull_request_comment"}}</label> | |||
<span class="help">{{.locale.Tr "repo.settings.event_pull_request_comment_desc"}}</span> | |||
</div> | |||
@@ -222,7 +222,7 @@ | |||
<div class="seven wide column"> | |||
<div class="field"> | |||
<div class="ui checkbox"> | |||
<input name="pull_request_review" type="checkbox" tabindex="0" {{if .Webhook.PullRequestReview}}checked{{end}}> | |||
<input name="pull_request_review" type="checkbox" {{if .Webhook.PullRequestReview}}checked{{end}}> | |||
<label>{{.locale.Tr "repo.settings.event_pull_request_review"}}</label> | |||
<span class="help">{{.locale.Tr "repo.settings.event_pull_request_review_desc"}}</span> | |||
</div> | |||
@@ -232,7 +232,7 @@ | |||
<div class="seven wide column"> | |||
<div class="field"> | |||
<div class="ui checkbox"> | |||
<input name="pull_request_sync" type="checkbox" tabindex="0" {{if .Webhook.PullRequestSync}}checked{{end}}> | |||
<input name="pull_request_sync" type="checkbox" {{if .Webhook.PullRequestSync}}checked{{end}}> | |||
<label>{{.locale.Tr "repo.settings.event_pull_request_sync"}}</label> | |||
<span class="help">{{.locale.Tr "repo.settings.event_pull_request_sync_desc"}}</span> | |||
</div> | |||
@@ -242,7 +242,7 @@ | |||
<div class="seven wide column"> | |||
<div class="field"> | |||
<div class="ui checkbox"> | |||
<input name="pull_request_review_request" type="checkbox" tabindex="0" {{if .Webhook.PullRequestReviewRequest}}checked{{end}}> | |||
<input name="pull_request_review_request" type="checkbox" {{if .Webhook.PullRequestReviewRequest}}checked{{end}}> | |||
<label>{{.locale.Tr "repo.settings.event_pull_request_review_request"}}</label> | |||
<span class="help">{{.locale.Tr "repo.settings.event_pull_request_review_request_desc"}}</span> | |||
</div> | |||
@@ -254,7 +254,7 @@ | |||
<!-- Branch filter --> | |||
<div class="field"> | |||
<label for="branch_filter">{{.locale.Tr "repo.settings.branch_filter"}}</label> | |||
<input name="branch_filter" type="text" tabindex="0" value="{{or .Webhook.BranchFilter "*"}}"> | |||
<input name="branch_filter" type="text" value="{{or .Webhook.BranchFilter "*"}}"> | |||
<span class="help">{{.locale.Tr "repo.settings.branch_filter_desc" | Str2html}}</span> | |||
</div> | |||
@@ -271,7 +271,7 @@ | |||
<div class="inline field"> | |||
<div class="ui checkbox"> | |||
<input name="active" type="checkbox" tabindex="0" {{if or $isNew .Webhook.IsActive}}checked{{end}}> | |||
<input name="active" type="checkbox" {{if or $isNew .Webhook.IsActive}}checked{{end}}> | |||
<label>{{.locale.Tr "repo.settings.active"}}</label> | |||
<span class="help">{{.locale.Tr "repo.settings.active_helper"}}</span> | |||
</div> |
@@ -11,7 +11,7 @@ | |||
</span> | |||
{{svg "octicon-triangle-down" 14 "dropdown icon"}} | |||
</span> | |||
<div class="context user overflow menu" tabindex="-1"> | |||
<div class="context user overflow menu"> | |||
<div class="ui header"> | |||
{{.locale.Tr "home.switch_dashboard_context"}} | |||
</div> | |||
@@ -55,7 +55,7 @@ | |||
{{end}} | |||
{{svg "octicon-triangle-down" 14 "dropdown icon"}} | |||
</span> | |||
<div class="context user overflow menu" tabindex="-1"> | |||
<div class="context user overflow menu"> | |||
<div class="ui header"> | |||
{{.locale.Tr "home.filter_by_team_repositories"}} | |||
</div> |
@@ -6,7 +6,6 @@ | |||
@click.stop="toggleMenu()" | |||
:data-tooltip-content="locale.filter_changes_by_commit" | |||
aria-haspopup="true" | |||
tabindex="0" | |||
aria-controls="diff-commit-selector-menu" | |||
:aria-label="locale.filter_changes_by_commit" | |||
aria-activedescendant="diff-commit-list-show-all" | |||
@@ -15,7 +14,7 @@ | |||
</button> | |||
<div class="menu left transition" id="diff-commit-selector-menu" :class="{visible: menuVisible}" v-show="menuVisible" v-cloak :aria-expanded="menuVisible ? 'true': 'false'"> | |||
<div class="loading-indicator is-loading" v-if="isLoading"/> | |||
<div v-if="!isLoading" class="vertical item gt-df gt-fc gt-gap-2" id="diff-commit-list-show-all" role="menuitem" tabindex="-1" @keydown.enter="showAllChanges()" @click="showAllChanges()"> | |||
<div v-if="!isLoading" class="vertical item gt-df gt-fc gt-gap-2" id="diff-commit-list-show-all" role="menuitem" @keydown.enter="showAllChanges()" @click="showAllChanges()"> | |||
<div class="gt-ellipsis"> | |||
{{ locale.show_all_commits }} | |||
</div> | |||
@@ -25,7 +24,7 @@ | |||
</div> | |||
<!-- only show the show changes since last review if there is a review AND we are commits ahead of the last review --> | |||
<div | |||
v-if="lastReviewCommitSha != null" role="menuitem" tabindex="-1" | |||
v-if="lastReviewCommitSha != null" role="menuitem" | |||
class="vertical item gt-df gt-fc gt-gap-2 gt-border-secondary-top" | |||
:class="{disabled: commitsSinceLastReview === 0}" | |||
@keydown.enter="changesSinceLastReviewClick()" | |||
@@ -41,7 +40,7 @@ | |||
<span v-if="!isLoading" class="info gt-border-secondary-top text light-2">{{ locale.select_commit_hold_shift_for_range }}</span> | |||
<template v-for="commit in commits" :key="commit.id"> | |||
<div | |||
class="vertical item gt-df gt-gap-2 gt-border-secondary-top" role="menuitem" tabindex="-1" | |||
class="vertical item gt-df gt-gap-2 gt-border-secondary-top" role="menuitem" | |||
:class="{selection: commit.selected, hovered: commit.hovered}" | |||
@keydown.enter.exact="commitClicked(commit.id)" | |||
@keydown.enter.shift.exact="commitClickedShift(commit)" |