Browse Source

Fix setting version table in dump (#15753) (#15759)

Backport #15753

* Fix setting version table in dump

As noted on Discord there is a problem with gitea dump where the version table
is not being dumped correctly.

This is due to a missing pointer in the TableInfo.

This PR fixes this.

Signed-off-by: Andrew Thornton <art27@cantab.net>

* Update models_test.go
tags/v1.14.2
zeripath 3 years ago
parent
commit
52ca7b9b65
No account linked to committer's email address
2 changed files with 2 additions and 2 deletions
  1. 1
    1
      models/models.go
  2. 1
    1
      models/models_test.go

+ 1
- 1
models/models.go View File

@@ -319,7 +319,7 @@ func DumpDatabase(filePath, dbType string) error {
ID int64 `xorm:"pk autoincr"`
Version int64
}
t, err := x.TableInfo(Version{})
t, err := x.TableInfo(&Version{})
if err != nil {
return err
}

+ 1
- 1
models/models_test.go View File

@@ -25,7 +25,7 @@ func TestDumpDatabase(t *testing.T) {
ID int64 `xorm:"pk autoincr"`
Version int64
}
assert.NoError(t, x.Sync2(Version{}))
assert.NoError(t, x.Sync2(new(Version)))

for _, dbName := range setting.SupportedDatabases {
dbType := setting.GetDBTypeByName(dbName)

Loading…
Cancel
Save