Przeglądaj źródła

Strip trailing newline in markdown code copy (#29019) (#29022)

Behaviour now matches GH. Safeguard added in the for loop because
`textContent` may be null in which case it does not make sense to render
the copy button.

Co-authored-by: silverwind <me@silverwind.io>
tags/v1.21.6
Giteabot 4 miesięcy temu
rodzic
commit
5d1abdce3e
No account linked to committer's email address
1 zmienionych plików z 3 dodań i 1 usunięć
  1. 3
    1
      web_src/js/markup/codecopy.js

+ 3
- 1
web_src/js/markup/codecopy.js Wyświetl plik

@@ -12,8 +12,10 @@ export function renderCodeCopy() {
if (!els.length) return;

for (const el of els) {
if (!el.textContent) continue;
const btn = makeCodeCopyButton();
btn.setAttribute('data-clipboard-text', el.textContent);
// remove final trailing newline introduced during HTML rendering
btn.setAttribute('data-clipboard-text', el.textContent.replace(/\r?\n$/, ''));
el.after(btn);
}
}

Ładowanie…
Anuluj
Zapisz