Selaa lähdekoodia

Fix 500 when getting user as unauthenticated user (#8662)

When doing GET /api/v1/users/{user} as an unauthenticated user,
gitea throws a 500 because it's trying to dereference elements
from the context user. It wants to do this to see whether to
show the primary email and will do that if the logged in user
is admin or the user in question. However, if ctx.User is nil,
go gets really unhappy.
tags/v1.9.5
Monty Taylor 4 vuotta sitten
vanhempi
commit
66ceee08dc
1 muutettua tiedostoa jossa 1 lisäystä ja 1 poistoa
  1. 1
    1
      routers/api/v1/user/user.go

+ 1
- 1
routers/api/v1/user/user.go Näytä tiedosto

@@ -104,7 +104,7 @@ func GetInfo(ctx *context.APIContext) {
return
}

ctx.JSON(200, convert.ToUser(u, ctx.IsSigned, ctx.User.ID == u.ID || ctx.User.IsAdmin))
ctx.JSON(200, convert.ToUser(u, ctx.IsSigned, ctx.User != nil && (ctx.User.ID == u.ID || ctx.User.IsAdmin)))
}

// GetAuthenticatedUser get current user's information

Loading…
Peruuta
Tallenna