Browse Source

Fix incorrect link-action event target (#25306)

A regression of #25210

The `e.target` is not "this", eg: `<button link-action><svg></button>`,
then `this` should be `button` but `e.target` is `svg`.

I will propose a clearer and complete solution for these "link-action"
"show-modal" elements after #24724

Co-authored-by: Giteabot <teabot@gitea.io>
tags/v1.21.0-rc0
wxiaoguang 1 year ago
parent
commit
695f5d170b
No account linked to committer's email address
1 changed files with 3 additions and 3 deletions
  1. 3
    3
      web_src/js/features/common-global.js

+ 3
- 3
web_src/js/features/common-global.js View File

@@ -268,10 +268,10 @@ function linkAction(e) {
e.preventDefault();

// A "link-action" can post AJAX request to its "data-url"
// Then the browser is redirect to: the "redirect" in response, or "data-redirect" attribute, or current URL by reloading.
// If the "link-action" has "data-modal-confirm(-html)" attribute, a confirm modal dialog will be shown before taking action.
// Then the browser is redirected to: the "redirect" in response, or "data-redirect" attribute, or current URL by reloading.
// If the "link-action" has "data-modal-confirm" attribute, a confirm modal dialog will be shown before taking action.

const $this = $(e.target);
const $this = $(this);
const redirect = $this.attr('data-redirect');

const doRequest = () => {

Loading…
Cancel
Save