浏览代码

Store read access in access for team repo's (#20275)

- Currently when a Team has read access to a organization's non-private
repository, their access won't be stored in the database. This caused
issue for code that rely on read access being stored. So from now-on if
we see that the repository is owned by a organization don't increase the
minMode to write permission.
- Resolves #20083
tags/v1.18.0-rc0
Gusted 1年前
父节点
当前提交
8a7d1a3516
没有帐户链接到提交者的电子邮件
共有 1 个文件被更改,包括 7 次插入1 次删除
  1. 7
    1
      models/perm/access/access.go

+ 7
- 1
models/perm/access/access.go 查看文件

@@ -86,7 +86,13 @@ func updateUserAccess(accessMap map[int64]*userAccess, user *user_model.User, mo
// FIXME: do cross-comparison so reduce deletions and additions to the minimum?
func refreshAccesses(ctx context.Context, repo *repo_model.Repository, accessMap map[int64]*userAccess) (err error) {
minMode := perm.AccessModeRead
if !repo.IsPrivate {
if err := repo.GetOwner(ctx); err != nil {
return fmt.Errorf("GetOwner: %v", err)
}

// If the repo isn't private and isn't owned by a organization,
// increase the minMode to Write.
if !repo.IsPrivate && !repo.Owner.IsOrganization() {
minMode = perm.AccessModeWrite
}


正在加载...
取消
保存