Browse Source

Fix missing stylesheets on installation page (#13736)

When running gitea for the first time, the stylesheets for the
installation page are broken since the middleware that statically serves
stylesheets does not get executed by chi. This is because if no handlers
are registered in chi, it will drop all middleware.

This commit introduces a "dummy" handler to deal with that quirk.

Closes #13725

Thanks: Lunny Xiao <xiaolunwen@gmail.com> for finding the quirk

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
tags/v1.15.0-dev
Simon 3 years ago
parent
commit
8c996c6505
No account linked to committer's email address
1 changed files with 6 additions and 0 deletions
  1. 6
    0
      routers/routes/chi.go

+ 6
- 0
routers/routes/chi.go View File

@@ -230,6 +230,12 @@ func RegisterInstallRoute(c chi.Router) {
m := NewMacaron()
RegisterMacaronInstallRoute(m)

// We need at least one handler in chi so that it does not drop
// our middleware: https://github.com/go-gitea/gitea/issues/13725#issuecomment-735244395
c.Get("/", func(w http.ResponseWriter, req *http.Request) {
m.ServeHTTP(w, req)
})

c.NotFound(func(w http.ResponseWriter, req *http.Request) {
m.ServeHTTP(w, req)
})

Loading…
Cancel
Save