Browse Source

Fix admin notice view-detail (#30450)

Fix https://github.com/go-gitea/gitea/issues/30434, regression from
https://github.com/go-gitea/gitea/pull/30115.

I also removed the date insertion into the modal which was also broken
since that date was switched to `absolute-date` because I see no real
purpose to putting that date into the modal.

Result:

<img width="1038" alt="image"
src="https://github.com/go-gitea/gitea/assets/115237/aa2eb8b4-73dc-4d98-9b80-3f276f89d9e5">
tags/v1.22.0-rc1
silverwind 1 month ago
parent
commit
8fd8978b49
No account linked to committer's email address
2 changed files with 5 additions and 8 deletions
  1. 1
    4
      templates/admin/notice.tmpl
  2. 4
    4
      web_src/js/features/admin/common.js

+ 1
- 4
templates/admin/notice.tmpl View File

@@ -62,10 +62,7 @@

<div class="ui modal admin" id="detail-modal">
<div class="header">{{ctx.Locale.Tr "admin.notices.view_detail_header"}}</div>
<div class="content">
<div class="sub header"></div>
<pre></pre>
</div>
<div class="content"><pre></pre></div>
</div>

{{template "admin/layout_footer" .}}

+ 4
- 4
web_src/js/features/admin/common.js View File

@@ -207,13 +207,13 @@ export function initAdminCommon() {

// Notice
if (document.querySelector('.admin.notice')) {
const $detailModal = document.getElementById('detail-modal');
const detailModal = document.getElementById('detail-modal');

// Attach view detail modals
$('.view-detail').on('click', function () {
$detailModal.find('.content pre').text($(this).parents('tr').find('.notice-description').text());
$detailModal.find('.sub.header').text(this.closest('tr')?.querySelector('relative-time')?.getAttribute('title'));
$detailModal.modal('show');
const description = this.closest('tr').querySelector('.notice-description').textContent;
detailModal.querySelector('.content pre').textContent = description;
$(detailModal).modal('show');
return false;
});


Loading…
Cancel
Save