Browse Source

Add comment for ContainsRedirectURI about the exact match (#30457)

Close #26897
Replace #30336
tags/v1.22.0-rc1
wxiaoguang 1 month ago
parent
commit
92e27e15c3
No account linked to committer's email address
1 changed files with 5 additions and 0 deletions
  1. 5
    0
      models/auth/oauth2.go

+ 5
- 0
models/auth/oauth2.go View File

@@ -137,6 +137,11 @@ func (app *OAuth2Application) TableName() string {

// ContainsRedirectURI checks if redirectURI is allowed for app
func (app *OAuth2Application) ContainsRedirectURI(redirectURI string) bool {
// OAuth2 requires the redirect URI to be an exact match, no dynamic parts are allowed.
// https://stackoverflow.com/questions/55524480/should-dynamic-query-parameters-be-present-in-the-redirection-uri-for-an-oauth2
// https://www.rfc-editor.org/rfc/rfc6819#section-5.2.3.3
// https://openid.net/specs/openid-connect-core-1_0.html#AuthRequest
// https://datatracker.ietf.org/doc/html/draft-ietf-oauth-security-topics-12#section-3.1
contains := func(s string) bool {
s = strings.TrimSuffix(strings.ToLower(s), "/")
for _, u := range app.RedirectURIs {

Loading…
Cancel
Save