Browse Source

Use Get/Set instead of Rename when Regenerate session id (#23975)

Do not use Rename here, because the old sid and new sid may be in
different redis cluster slot.

Fix #23869
tags/v1.20.0-rc0
wxiaoguang 1 year ago
parent
commit
97d5ec2aeb
No account linked to committer's email address
1 changed files with 9 additions and 4 deletions
  1. 9
    4
      modules/session/redis.go

+ 9
- 4
modules/session/redis.go View File

@@ -183,16 +183,21 @@ func (p *RedisProvider) Regenerate(oldsid, sid string) (_ session.RawStore, err
}
}

if err = p.c.Rename(graceful.GetManager().HammerContext(), poldsid, psid).Err(); err != nil {
// do not use Rename here, because the old sid and new sid may be in different redis cluster slot.
kvs, err := p.c.Get(graceful.GetManager().HammerContext(), poldsid).Result()
if err != nil {
return nil, err
}

var kv map[interface{}]interface{}
kvs, err := p.c.Get(graceful.GetManager().HammerContext(), psid).Result()
if err != nil {
if err = p.c.Del(graceful.GetManager().HammerContext(), poldsid).Err(); err != nil {
return nil, err
}

if err = p.c.Set(graceful.GetManager().HammerContext(), psid, kvs, p.duration).Err(); err != nil {
return nil, err
}

var kv map[interface{}]interface{}
if len(kvs) == 0 {
kv = make(map[interface{}]interface{})
} else {

Loading…
Cancel
Save