Browse Source
Fix incorrect `HookEventType` of pull request review comments (#23650)
`HookEventType` of pull request review comments should be `HookEventPullRequestReviewComment` but some event types are `HookEventPullRequestComment` now.tags/v1.20.0-rc0
Zettat123
1 year ago
4 changed files with 5 additions and 5 deletions
+ 1
- 1
services/actions/notifier.go
View File
| case issues_model.ReviewTypeApprove: | case issues_model.ReviewTypeApprove: | ||||
| reviewHookType = webhook_module.HookEventPullRequestReviewApproved | reviewHookType = webhook_module.HookEventPullRequestReviewApproved | ||||
| case issues_model.ReviewTypeComment: | case issues_model.ReviewTypeComment: | ||||
| reviewHookType = webhook_module.HookEventPullRequestComment | |||||
| reviewHookType = webhook_module.HookEventPullRequestReviewComment | |||||
| case issues_model.ReviewTypeReject: | case issues_model.ReviewTypeReject: | ||||
| reviewHookType = webhook_module.HookEventPullRequestReviewRejected | reviewHookType = webhook_module.HookEventPullRequestReviewRejected | ||||
| default: | default: |
+ 2
- 2
services/webhook/discord.go
View File
| color = greenColor | color = greenColor | ||||
| case webhook_module.HookEventPullRequestReviewRejected: | case webhook_module.HookEventPullRequestReviewRejected: | ||||
| color = redColor | color = redColor | ||||
| case webhook_module.HookEventPullRequestComment: | |||||
| case webhook_module.HookEventPullRequestReviewComment: | |||||
| color = greyColor | color = greyColor | ||||
| default: | default: | ||||
| color = yellowColor | color = yellowColor | ||||
| return "approved", nil | return "approved", nil | ||||
| case webhook_module.HookEventPullRequestReviewRejected: | case webhook_module.HookEventPullRequestReviewRejected: | ||||
| return "rejected", nil | return "rejected", nil | ||||
| case webhook_module.HookEventPullRequestComment: | |||||
| case webhook_module.HookEventPullRequestReviewComment: | |||||
| return "comment", nil | return "comment", nil | ||||
| default: | default: |
+ 1
- 1
services/webhook/msteams.go
View File
| color = greenColor | color = greenColor | ||||
| case webhook_module.HookEventPullRequestReviewRejected: | case webhook_module.HookEventPullRequestReviewRejected: | ||||
| color = redColor | color = redColor | ||||
| case webhook_module.HookEventPullRequestComment: | |||||
| case webhook_module.HookEventPullRequestReviewComment: | |||||
| color = greyColor | color = greyColor | ||||
| default: | default: | ||||
| color = yellowColor | color = yellowColor |
+ 1
- 1
services/webhook/notifier.go
View File
| case issues_model.ReviewTypeApprove: | case issues_model.ReviewTypeApprove: | ||||
| reviewHookType = webhook_module.HookEventPullRequestReviewApproved | reviewHookType = webhook_module.HookEventPullRequestReviewApproved | ||||
| case issues_model.ReviewTypeComment: | case issues_model.ReviewTypeComment: | ||||
| reviewHookType = webhook_module.HookEventPullRequestComment | |||||
| reviewHookType = webhook_module.HookEventPullRequestReviewComment | |||||
| case issues_model.ReviewTypeReject: | case issues_model.ReviewTypeReject: | ||||
| reviewHookType = webhook_module.HookEventPullRequestReviewRejected | reviewHookType = webhook_module.HookEventPullRequestReviewRejected | ||||
| default: | default: |
Loading…