Enable linter [rule.modifies-value-receiver] and refactor RoleDescriptor (#18093)

.revive.toml

@@ -24,3 +24,4 @@ warningCode = 1
 [rule.indent-error-flow]
 [rule.errorf]
 [rule.duplicated-imports]
+[rule.modifies-value-receiver]

models/issue_comment.go

@@ -123,8 +123,7 @@ const (
 
 // WithRole enable a specific tag on the RoleDescriptor.
 func (rd RoleDescriptor) WithRole(role RoleDescriptor) RoleDescriptor {
-	rd |= (1 << role)
-	return rd
+	return rd | (1 << role)
 }
 
 func stringToRoleDescriptor(role string) RoleDescriptor {