Browse Source

Add sensitive headers (#3429)

* Add HeaderWithSensitiveCase methods to respect casing

* Update webhook.go
tags/v1.4.0-rc1
Antoine GIRARD 6 years ago
parent
commit
b3fd94c13d
2 changed files with 8 additions and 2 deletions
  1. 2
    2
      models/webhook.go
  2. 6
    0
      modules/httplib/httplib.go

+ 2
- 2
models/webhook.go View File

@@ -588,8 +588,8 @@ func (t *HookTask) deliver() {
Header("X-Gitea-Event", string(t.EventType)).
Header("X-Gogs-Delivery", t.UUID).
Header("X-Gogs-Event", string(t.EventType)).
Header("X-GitHub-Delivery", t.UUID).
Header("X-GitHub-Event", string(t.EventType)).
HeaderWithSensitiveCase("X-GitHub-Delivery", t.UUID).
HeaderWithSensitiveCase("X-GitHub-Event", string(t.EventType)).
SetTLSClientConfig(&tls.Config{InsecureSkipVerify: setting.Webhook.SkipTLSVerify})

switch t.ContentType {

+ 6
- 0
modules/httplib/httplib.go View File

@@ -164,6 +164,12 @@ func (r *Request) Header(key, value string) *Request {
return r
}

// HeaderWithSensitiveCase add header item in request and keep the case of the header key.
func (r *Request) HeaderWithSensitiveCase(key, value string) *Request {
r.req.Header[key] = []string{value}
return r
}

// Headers returns headers in request.
func (r *Request) Headers() http.Header {
return r.req.Header

Loading…
Cancel
Save