replace lesshint with stylelint (#7305)

New CSS linter which is much more powerfull than the previous one.
Configuration is default but I had to remove a few rules that were
throwing too many or weird errors.

More importantly, the linter will exit with code 1 on errors so now our
build will fail if the CSS linter fails which should eliminate linter
errors being introduced without notice.

.lesshintrc.json

-{
-  "idSelector": false,
-  "importPath": false,
-  "importantRule": false,
-  "maxCharPerLine": false,
-  "propertyOrdering": false,
-  "qualifyingElement": false,
-  "spaceAroundComma": false,
-  "stringQuotes": "double",
-  "universalSelector": false,
-  "zeroUnit": "no_unit"
-}

.stylelintrc

+extends: stylelint-config-standard
+
+rules:
+  block-closing-brace-empty-line-before: null
+  color-hex-length: null
+  comment-empty-line-before: null
+  declaration-empty-line-before: null
+  indentation: 4
+  no-descending-specificity: null
+  rule-empty-line-before: null
+  selector-pseudo-element-colon-notation: null

Makefile

 
 .PHONY: css
 css: npm
-	npx lesshint public/less/
+	npx stylelint public/less
 	npx lessc --clean-css="--s0 -b" public/less/index.less public/css/index.css
 	$(foreach file, $(filter-out public/less/themes/_base.less, $(wildcard public/less/themes/*)),npx lessc --clean-css="--s0 -b" public/less/themes/$(notdir $(file)) > public/css/theme-$(notdir $(call strip-suffix,$(file))).css;)
 	npx postcss --use autoprefixer --no-map --replace public/css/*

package.json

     "eslint": "5.16.0",
     "less": "3.9.0",
     "less-plugin-clean-css": "1.5.1",
-    "lesshint": "6.3.6",
     "postcss-cli": "6.1.2",
+    "stylelint": "10.1.0",
+    "stylelint-config-standard": "18.3.0",
     "updates": "8.1.0"
   },
   "browserslist": [

public/css/index.css

 .markdown:not(code) h6{font-size:1em;color:#777}
 .markdown:not(code) h6 .anchor{line-height:1.1}
 .markdown:not(code) blockquote,.markdown:not(code) dl,.markdown:not(code) ol,.markdown:not(code) p,.markdown:not(code) pre,.markdown:not(code) table,.markdown:not(code) ul{margin-top:0;margin-bottom:16px}
-.markdown:not(code) blockquote{margin-left:0}
 .markdown:not(code) hr{height:4px;padding:0;margin:16px 0;background-color:#e7e7e7;border:0}
 .markdown:not(code) ol,.markdown:not(code) ul{padding-left:2em}
 .markdown:not(code) ol.no-list,.markdown:not(code) ul.no-list{padding:0;list-style-type:none}
 .markdown:not(code) dl{padding:0}
 .markdown:not(code) dl dt{padding:0;margin-top:16px;font-size:1em;font-style:italic;font-weight:700}
 .markdown:not(code) dl dd{padding:0 16px;margin-bottom:16px}
-.markdown:not(code) blockquote{padding:0 15px;color:#777;border-left:4px solid #ddd}
+.markdown:not(code) blockquote{margin-left:0;padding:0 15px;color:#777;border-left:4px solid #ddd}
 .markdown:not(code) blockquote>:first-child{margin-top:0}
 .markdown:not(code) blockquote>:last-child{margin-bottom:0}
 .markdown:not(code) table{width:auto;overflow:auto;word-break:keep-all;display:block}
 .user.followers .header.name{font-size:20px;line-height:24px;vertical-align:middle}
 .user.followers .follow .ui.button{padding:8px 15px}
 .user.notification .octicon{float:left;font-size:2em}
-.user.notification .content{float:left;margin-left:7px}
-.user.notification table form{display:inline-block}
-.user.notification table button{padding:3px 3px 3px 5px}
-.user.notification table tr{cursor:pointer}
 .user.notification .octicon.green{color:#21ba45}
 .user.notification .octicon.red{color:#d01919}
 .user.notification .octicon.purple{color:#a333c8}
 .user.notification .octicon.blue{color:#2185d0}
+.user.notification .content{float:left;margin-left:7px}
+.user.notification table form{display:inline-block}
+.user.notification table button{padding:3px 3px 3px 5px}
+.user.notification table tr{cursor:pointer}
 .user.link-account:not(.icon){padding-top:15px;padding-bottom:5px}
 .user.settings .iconFloat{float:left}
 .user-orgs{display:flex;flex-flow:row wrap;padding:0;margin:-3px!important}

public/css/theme-arc-green.css

 .repository .milestone.list>.item .operate>a:hover{color:#a0cc75}
 .ui.green.progress .bar{background-color:#684}
 .ui.progress.success .bar{background-color:#7b9e57!important}
-.following.bar.light{background:#2e323e}
+.following.bar.light{background:#2e323e;border-bottom:1px solid #313131}
 .ui.secondary.menu .active.item{color:#dbdbdb}
 .ui.secondary.menu .item{color:#9e9e9e}
 .following.bar .top.menu a.item:hover{color:#fff}
 .repository.view.issue .comment-list .comment .content>.bottom.segment a{border:solid 1px #353945;background-color:#353945}
-.following.bar.light{border-bottom:1px solid #313131}
 .ui.attached.header{background:#404552;border:1px solid #404552;color:#dbdbdb}
 .ui.attached.table{border:1px solid #304251;background:#304251}
 .feeds .list ul li:not(:last-child){border-bottom:1px solid #333640}
 .ui.attached.segment{border:1px solid #404552}
 .repository.view.issue .comment-list .comment .content>.bottom.segment{background:#353945}
 .repository.view.issue .comment-list .comment .content .header{color:#dbdbdb;background-color:#404552;border-bottom:1px solid #353944}
-.ui .text.grey a{color:#b3b3b3!important}
+.ui .text.grey a{color:#dbdbdb!important}
 .ui.comments .comment .actions a{color:#dbdbdb}
 .repository.view.issue .comment-list .comment .content .header:after{border-right-color:#404552}
 .repository.new.issue .comment.form .content:after{border-right-color:#353945}
 .repository.view.issue .comment-list:before{background-color:#313c47}
 .repository .comment.form .content .form:after{border-right-color:#313c47}
 .repository .comment.form .content .form:before{border-right-color:#313c47}
-.ui .text.grey a{color:#dbdbdb!important}
 .ui .text.grey a:hover{color:#dbdbdb!important}
 .ui.basic.green.active.button,.ui.basic.green.buttons .active.button{color:#13ae38!important}
-.ui.form textarea,.ui.form textarea:focus{background:#1a2632;border:1px solid #313c47;color:#dbdbdb}
+.ui.form textarea,.ui.form textarea:focus{color:#dbdbdb;background:#404552;border:2px solid #353945}
 .ui.form textarea:focus{border:1px solid #456580}
 .ui .info.segment.top{background-color:#404552!important}
 .repository .diff-file-box .code-diff-unified tbody tr.del-code td{background-color:#3c2626!important;border-color:#634343!important}
 .repository .diff-file-box .file-body.file-code .lines-num{color:#9e9e9e;background:#2e323e}
 .repository .diff-file-box .file-body.file-code .lines-num-old{border-right:1px solid #2d2d2d}
 .hljs-section,.hljs-selector-id,.hljs-title{color:#986c88}
-.hljs-doctag,.hljs-string{color:#949494}
+.hljs-doctag,.hljs-string{color:#8ab398}
 .repository .diff-file-box .code-diff tbody tr .removed-code{background-color:#5f3737}
 .repository .diff-file-box .code-diff tbody tr td.tag-code,.repository .diff-file-box .code-diff tbody tr.tag-code td{background-color:#292727!important}
 .ui.vertical.menu .active.item{background:#4b5162}
 .ui .text.black{color:#9e9e9e}
 .ui .text.black:hover{color:#dbdbdb}
 .ui.secondary.segment{background:#353945}
-.ui.secondary.pointing.menu .active.item{border-color:#87ab63;color:#dbdbdb;background:#404552}
+.ui.secondary.pointing.menu .active.item{color:#dbdbdb;border:0;background:#383c4a}
 .ui.user.list .item:not(:first-child){border-top:1px solid #4c505c}
 .ui.secondary.pointing.menu .active.item:hover{border-color:#af8b4c;color:#dbdbdb;background:#4b5162}
 .ui.secondary.pointing.menu .dropdown.item:hover,.ui.secondary.pointing.menu .link.item:hover,.ui.secondary.pointing.menu a.item:hover{color:#dbdbdb}
 @media only screen and (max-width:1200px){.ui.menu.new-menu:after{background-image:linear-gradient(to right,rgba(42,46,42,0),#2a2e2a 100%)}
 }
 input{background:#2e323e}
-.ui.secondary.pointing.menu .active.item{border:0;background:#383c4a}
 .settings .key.list .item:not(:first-child){border-top:1px solid #404552}
 .ui.attached.info.message,.ui.info.message{box-shadow:0 0 0 1px #4b5e71 inset,0 0 0 0 transparent}
 .ui.bottom.attached.message{background-color:#2c662d;color:#87ab63}
 .ui.red.button:hover,.ui.red.buttons .button:hover{background-color:#984646}
 .ui.checkbox label:hover,.ui.checkbox+label:hover{color:#dbdbdb!important}
 .ui.checkbox input:checked~.box:after,.ui.checkbox input:checked~label:after{color:#7f98ad}
-.ui.checkbox input:checked~.box:before,.ui.checkbox input:checked~label:before{background:#304251}
+.ui.checkbox input:checked~.box:before,.ui.checkbox input:checked~label:before{background:#304251;opacity:1;color:#7f98ad;border-color:#304251}
 .ui.checkbox .box:hover::before,.ui.checkbox label:hover::before{background:#304251}
 .ui.checkbox .box:before,.ui.checkbox label:before{background:#304251;border:1px solid #304251}
 .ui.checkbox .box:active::before,.ui.checkbox label:active::before{background:#304251;border-color:rgba(34,36,38,.35)}
-.ui.checkbox input:checked~.box:before,.ui.checkbox input:checked~label:before{border-color:#304251;background:#304251}
 .ui.checkbox input:focus~.box:before,.ui.checkbox input:focus~label:before{border-color:#304251;background:#304251}
 .ui.checkbox input:checked:focus~.box:before,.ui.checkbox input:checked:focus~label:before,.ui.checkbox input:not([type=radio]):indeterminate:focus~.box:before,.ui.checkbox input:not([type=radio]):indeterminate:focus~label:before{border-color:#304251;background:#304251}
-.ui.checkbox input:checked~.box:after,.ui.checkbox input:checked~label:after{opacity:1;color:#7f98ad}
 .ui.checkbox input:checked:focus~.box:after,.ui.checkbox input:checked:focus~label:after,.ui.checkbox input:not([type=radio]):indeterminate:focus~.box:after,.ui.checkbox input:not([type=radio]):indeterminate:focus~label:after{color:#7f98ad}
 .ui.checkbox input:focus~.box:after,.ui.checkbox input:focus~label,.ui.checkbox input:focus~label:after{color:#9a9a9a}
 .ui.selection.dropdown:hover{border:1px solid #456580}
 .ui.negative.message{background-color:rgba(80,23,17,.6);color:#f9cbcb;box-shadow:0 0 0 1px rgba(121,71,66,.5) inset,0 0 0 0 transparent}
 .hljs-attribute,.hljs-name,.hljs-tag{color:#ef5e77}
 .user.profile .ui.card .extra.content ul li:not(:last-child){border-bottom:1px solid #4c505c}
-.ui.form textarea,.ui.form textarea:focus{background:#404552;border:2px solid #353945}
 .hljs-literal,.hljs-number,.hljs-tag .hljs-attr,.hljs-template-variable,.hljs-variable{color:#bd84bf}
-.hljs-doctag,.hljs-string{color:#8ab398}
 .ui.form .dropzone{border:2px dashed #4c505c}
 .ui.basic.red.button,.ui.basic.red.buttons .button{box-shadow:0 0 0 1px #a04141 inset!important;color:#a04141!important}
 .ui.list .list>.item .header,.ui.list>.item .header{color:#dedede}
 .ui.user.list .item .description a{color:#668cb1}
 .repository.file.list #file-content .code-view .lines-num{background:#2e323e}
 .repository.file.list #repo-files-table tbody .octicon.octicon-file-directory,.repository.file.list #repo-files-table tbody .octicon.octicon-file-submodule{color:#7c9b5e}
-.ui.blue.button:focus,.ui.blue.buttons .button:focus{background-color:#87ab63}
+.ui.blue.button:focus,.ui.blue.buttons .button:focus{background-color:#a27558}
 .ui.basic.blue.button:hover,.ui.basic.blue.buttons .button:hover{box-shadow:0 0 0 1px #87ab63 inset!important;color:#87ab63!important}
 .ui.basic.blue.button:focus,.ui.basic.blue.buttons .button:focus{box-shadow:0 0 0 1px #87ab63 inset!important;color:#87ab63!important}
 .repository.file.list #file-content .code-view .lines-code .hljs,.repository.file.list #file-content .code-view .lines-code ol,.repository.file.list #file-content .code-view .lines-code pre,.repository.file.list #file-content .code-view .lines-num .hljs,.repository.file.list #file-content .code-view .lines-num ol,.repository.file.list #file-content .code-view .lines-num pre{background-color:#2a2e3a}
 a.ui.label:hover,a.ui.labels .label:hover{background-color:#505667;color:#dbdbdb}
 .repository .label.list .item{border-bottom:1px dashed #4c505c}
-.repository.file.list #file-content .code-view .lines-num{background:#2e323e}
-.repository.file.list #repo-files-table tbody .octicon.octicon-file-directory,.repository.file.list #repo-files-table tbody .octicon.octicon-file-submodule{color:#7c9b5e}
-.ui.basic.blue.button,.ui.basic.blue.buttons .button{box-shadow:0 0 0 1px #a27558 inset!important;color:#a27558!important}
+.ui.basic.blue.button,.ui.basic.blue.buttons .button{box-shadow:0 0 0 1px #87ab63 inset!important;color:#87ab63!important}
 .repository.file.list #file-content .code-view .hljs,.repository.file.list #file-content .code-view .lines-code ol,.repository.file.list #file-content .code-view .lines-code pre,.repository.file.list #file-content .code-view .lines-num .hljs,.repository.file.list #file-content .code-view .lines-num ol,.repository.file.list #file-content .code-view .lines-num pre{background-color:#2a2e3a}
-a.ui.label:hover,a.ui.labels .label:hover{background-color:#505667;color:#dbdbdb}
 .repository .diff-file-box .code-diff-split tbody tr.add-code td:nth-child(1),.repository .diff-file-box .code-diff-split tbody tr.add-code td:nth-child(2),.repository .diff-file-box .code-diff-split tbody tr.del-code td:nth-child(3),.repository .diff-file-box .code-diff-split tbody tr.del-code td:nth-child(4),.repository .diff-file-box .code-diff-split tbody tr.del-code td:nth-child(5),.repository .diff-file-box .code-diff-split tbody tr.del-code td:nth-child(6){background-color:#2a2e3a}
 .repository .diff-file-box .code-diff-split tbody tr td.add-code,.repository .diff-file-box .code-diff-split tbody tr.add-code td:nth-child(4),.repository .diff-file-box .code-diff-split tbody tr.add-code td:nth-child(5),.repository .diff-file-box .code-diff-split tbody tr.add-code td:nth-child(6){background-color:#283e2d!important;border-color:#314a37!important}
 .repository .diff-file-box .code-diff-split tbody tr td.del-code,.repository .diff-file-box .code-diff-split tbody tr.del-code td:nth-child(1),.repository .diff-file-box .code-diff-split tbody tr.del-code td:nth-child(2),.repository .diff-file-box .code-diff-split tbody tr.del-code td:nth-child(3){background-color:#3c2626!important;border-color:#634343!important}
-.ui.blue.button:focus,.ui.blue.buttons .button:focus{background-color:#a27558}
 .ui.blue.button:active,.ui.blue.buttons .button:active{background-color:#a27558}
 #git-graph-container li a{color:#c79575}
 #git-graph-container li .author{color:#c79575}
 .ui.modal>.header{background:#404552;color:#dbdbdb}
 .ui.modal>.actions{background:#404552;border-top:1px solid #404552}
 .ui.modal>.content{background:#383c4a}
-.ui.basic.blue.button,.ui.basic.blue.buttons .button{box-shadow:0 0 0 1px #87ab63 inset!important;color:#87ab63!important}
 .editor-toolbar{background-color:#404552}
 .editor-toolbar a{color:#87ab63!important}
 .CodeMirror{color:#9daccc;background-color:#2b2b2b;border-top:0}

public/less/_form.less

             margin-left: 25px;
         }
     }
-}
 
-.new.webhook {
     .events.fields {
         .column {
             padding-left: 40px;

public/less/_markdown.less

         margin-bottom: 16px;
     }
 
-    blockquote {
-        margin-left: 0;
-    }
-
     hr {
         height: 4px;
         padding: 0;
     }
 
     blockquote {
+        margin-left: 0;
         padding: 0 15px;
         color: #777777;
         border-left: 4px solid #dddddd;

public/less/_repository.less

 
             .detail.icon {
                 background: #fafafa;
-                margin: -6px -10px -4px 0px;
+                margin: -6px -10px -4px 0;
                 padding: 5px 3px 5px 6px;
                 border-left: 1px solid #bbbbbb;
                 border-top-left-radius: 0;

public/less/_user.less

                             border-bottom: 1px solid #eaeaea;
                         }
 
-                        .octicon, .fa {
+                        .octicon,
+                        .fa {
                             margin-left: 1px;
                             margin-right: 5px;
                         }
         .octicon {
             float: left;
             font-size: 2em;
+
+            &.green {
+                color: #21ba45;
+            }
+
+            &.red {
+                color: #d01919;
+            }
+
+            &.purple {
+                color: #a333c8;
+            }
+
+            &.blue {
+                color: #2185d0;
+            }
         }
 
         .content {
                 cursor: pointer;
             }
         }
-
-        .octicon {
-            &.green {
-                color: #21ba45;
-            }
-
-            &.red {
-                color: #d01919;
-            }
-
-            &.purple {
-                color: #a333c8;
-            }
-
-            &.blue {
-                color: #2185d0;
-            }
-        }
     }
 
     &.link-account:not(.icon) {

public/less/themes/arc-green.less

 
 .following.bar.light {
     background: #2e323e;
+    border-bottom: 1px solid #313131;
 }
 
 .ui.secondary.menu .active.item {
     background-color: #353945;
 }
 
-.following.bar.light {
-    border-bottom: 1px solid #313131;
-}
-
 .ui.attached.header {
     background: #404552;
     border: 1px solid #404552;
 
 .repository.file.editor.edit,
 .repository.wiki.new .CodeMirror {
-    border-right: 1px solid rgba(187,187,187, 0.6);
-    border-left: 1px solid rgba(187,187,187, 0.6);
-    border-bottom: 1px solid rgba(187,187,187, 0.6);
+    border-right: 1px solid rgba(187, 187, 187, 0.6);
+    border-left: 1px solid rgba(187, 187, 187, 0.6);
+    border-bottom: 1px solid rgba(187, 187, 187, 0.6);
 
     .editor-preview,
     .editor-preview-side {
 }
 
 .ui .text.grey a {
-    color: #b3b3b3 !important;
+    color: #dbdbdb !important;
 }
 
 .ui.comments .comment .actions a {
     border-right-color: #313c47;
 }
 
-.ui .text.grey a {
-    color: #dbdbdb !important;
-}
-
 .ui .text.grey a:hover {
     color: #dbdbdb !important;
 }
 
 .ui.form textarea,
 .ui.form textarea:focus {
-    background: #1a2632;
-    border: 1px solid #313c47;
     color: #dbdbdb;
+    background: #404552;
+    border: 2px solid #353945;
 }
 
 .ui.form textarea:focus {
 
 .hljs-string,
 .hljs-doctag {
-    color: #949494;
+    color: #8ab398;
 }
 
 .repository .diff-file-box .code-diff tbody tr .removed-code {
 }
 
 .ui.secondary.pointing.menu .active.item {
-    border-color: #87ab63;
     color: #dbdbdb;
-    background: #404552;
+    border: 0;
+    background: #383c4a;
 }
 
 .ui.user.list .item:not(:first-child) {
 
 .ui.menu.new-menu {
     background-color: #2a2e3a !important;
+
     @media only screen and (max-width: 1200px) {
         &:after {
             background-image: linear-gradient(to right, rgba(42, 46, 42, 0), rgba(42, 46, 42, 1) 100%);
     background: #2e323e;
 }
 
-.ui.secondary.pointing.menu .active.item {
-    border: 0;
-    background: #383c4a;
-}
-
 .settings .key.list .item:not(:first-child) {
     border-top: 1px solid #404552;
 }
 .ui.checkbox input:checked ~ .box:before,
 .ui.checkbox input:checked ~ label:before {
     background: #304251;
+    opacity: 1;
+    color: #7f98ad;
+    border-color: #304251;
 }
 
 .ui.checkbox .box:hover::before,
     border-color: rgba(34, 36, 38, 0.35);
 }
 
-.ui.checkbox input:checked ~ .box:before,
-.ui.checkbox input:checked ~ label:before {
-    border-color: #304251;
-    background: #304251;
-}
-
 .ui.checkbox input:focus ~ .box:before,
 .ui.checkbox input:focus ~ label:before {
     border-color: #304251;
     background: #304251;
 }
 
-.ui.checkbox input:checked ~ .box:after,
-.ui.checkbox input:checked ~ label:after {
-    opacity: 1;
-    color: #7f98ad;
-}
-
 .ui.checkbox input:checked:focus ~ .box:after,
 .ui.checkbox input:checked:focus ~ label:after,
 .ui.checkbox input:not([type="radio"]):indeterminate:focus ~ .box:after,
     border-bottom: 1px solid #4c505c;
 }
 
-.ui.form textarea,
-.ui.form textarea:focus {
-    background: #404552;
-    border: 2px solid #353945;
-}
-
 .hljs-number,
 .hljs-literal,
 .hljs-variable,
     color: #bd84bf;
 }
 
-.hljs-string,
-.hljs-doctag {
-    color: #8ab398;
-}
-
 .ui.form .dropzone {
     border: 2px dashed #4c505c;
 }
 
 .ui.blue.button:focus,
 .ui.blue.buttons .button:focus {
-    background-color: #87ab63;
+    background-color: #a27558;
 }
 
 .ui.basic.blue.button:hover,
     border-bottom: 1px dashed #4c505c;
 }
 
-.repository.file.list #file-content .code-view .lines-num {
-    background: #2e323e;
-}
-
-.repository.file.list #repo-files-table tbody .octicon.octicon-file-directory,
-.repository.file.list #repo-files-table tbody .octicon.octicon-file-submodule {
-    color: #7c9b5e;
-}
-
 .ui.basic.blue.button,
 .ui.basic.blue.buttons .button {
-    box-shadow: 0 0 0 1px #a27558 inset !important;
-    color: #a27558 !important;
+    box-shadow: 0 0 0 1px #87ab63 inset !important;
+    color: #87ab63 !important;
 }
 
 .repository.file.list #file-content .code-view {
     }
 }
 
-a.ui.label:hover,
-a.ui.labels .label:hover {
-    background-color: #505667;
-    color: #dbdbdb;
-}
-
 .repository .diff-file-box .code-diff-split tbody tr.add-code td:nth-child(1),
 .repository .diff-file-box .code-diff-split tbody tr.add-code td:nth-child(2),
 .repository .diff-file-box .code-diff-split tbody tr.del-code td:nth-child(3),
     border-color: #634343 !important;
 }
 
-.ui.blue.button:focus,
-.ui.blue.buttons .button:focus {
-    background-color: #a27558;
-}
-
 .ui.blue.button:active,
 .ui.blue.buttons .button:active {
     background-color: #a27558;
     background: #383c4a;
 }
 
-.ui.basic.blue.button,
-.ui.basic.blue.buttons .button {
-    box-shadow: 0 0 0 1px #87ab63 inset !important;
-    color: #87ab63 !important;
-}
-
 .editor-toolbar {
     background-color: #404552;