Quellcode durchsuchen

Prevent primary key update on migration (#26192) (#26199)

Backport #26192 by @KN4CK3R

Fixes #25918

The migration fails on MSSQL because xorm tries to update the primary
key column. xorm prevents this if the column is marked as auto
increment:

c622cdaf89/internal/statements/update.go (L38-L40)

I think it would be better if xorm would check for primary key columns
here because updating such columns is bad practice. It looks like if
that auto increment check should do the same.

fyi @lunny

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
tags/v1.20.2
Giteabot vor 10 Monaten
Ursprung
Commit
ecfbcced46
Es ist kein Account mit der E-Mail-Adresse des Committers verbunden
1 geänderte Dateien mit 1 neuen und 1 gelöschten Zeilen
  1. 1
    1
      models/migrations/v1_20/v250.go

+ 1
- 1
models/migrations/v1_20/v250.go Datei anzeigen

@@ -20,7 +20,7 @@ func ChangeContainerMetadataMultiArch(x *xorm.Engine) error {
}

type PackageVersion struct {
ID int64 `xorm:"pk"`
ID int64 `xorm:"pk autoincr"`
MetadataJSON string `xorm:"metadata_json"`
}


Laden…
Abbrechen
Speichern