Partial backport of #11853 Add doctor check to set IsArchived false if it is null. (Migration change unfortunately not possible to be backported.) Fix #11824 Signed-off-by: Andrew Thornton <art27@cantab.net>tags/v1.12.0
@@ -574,6 +574,22 @@ func runDoctorCheckDBConsistency(ctx *cli.Context) ([]string, error) { | |||
} | |||
} | |||
count, err = models.CountNullArchivedRepository() | |||
if err != nil { | |||
return nil, err | |||
} | |||
if count > 0 { | |||
if ctx.Bool("fix") { | |||
updatedCount, err := models.FixNullArchivedRepository() | |||
if err != nil { | |||
return nil, err | |||
} | |||
results = append(results, fmt.Sprintf("%d repositories with null is_archived updated", updatedCount)) | |||
} else { | |||
results = append(results, fmt.Sprintf("%d repositories with null is_archived", count)) | |||
} | |||
} | |||
//ToDo: function to recalc all counters | |||
return results, nil |
@@ -283,3 +283,15 @@ func DeleteOrphanedObjects(subject, refobject, joinCond string) error { | |||
Delete("`" + subject + "`") | |||
return err | |||
} | |||
// CountNullArchivedRepository counts the number of repositories with is_archived is null | |||
func CountNullArchivedRepository() (int64, error) { | |||
return x.Where(builder.IsNull{"is_archived"}).Count(new(Repository)) | |||
} | |||
// FixNullArchivedRepository sets is_archived to false where it is null | |||
func FixNullArchivedRepository() (int64, error) { | |||
return x.Where(builder.IsNull{"is_archived"}).Cols("is_archived").Update(&Repository{ | |||
IsArchived: false, | |||
}) | |||
} |