123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865866867868869870871872873874875876877878879880881882883884885886887888889890891892893894895896897898899900901902903904905906907908909910911912913914915916917918919920921922923924925926927928929930931932933934935936937938939940941942943944945946947948949950951952953954955956957958959960961962963964965966967968969970971972973974975976 |
- // Copyright 2018 The Gitea Authors. All rights reserved.
- // Use of this source code is governed by a MIT-style
- // license that can be found in the LICENSE file.
-
- package models
-
- import (
- "fmt"
- "strings"
-
- "code.gitea.io/gitea/modules/base"
- "code.gitea.io/gitea/modules/timeutil"
-
- "xorm.io/builder"
- )
-
- // ReviewType defines the sort of feedback a review gives
- type ReviewType int
-
- // ReviewTypeUnknown unknown review type
- const ReviewTypeUnknown ReviewType = -1
-
- const (
- // ReviewTypePending is a review which is not published yet
- ReviewTypePending ReviewType = iota
- // ReviewTypeApprove approves changes
- ReviewTypeApprove
- // ReviewTypeComment gives general feedback
- ReviewTypeComment
- // ReviewTypeReject gives feedback blocking merge
- ReviewTypeReject
- // ReviewTypeRequest request review from others
- ReviewTypeRequest
- )
-
- // Icon returns the corresponding icon for the review type
- func (rt ReviewType) Icon() string {
- switch rt {
- case ReviewTypeApprove:
- return "check"
- case ReviewTypeReject:
- return "diff"
- case ReviewTypeComment:
- return "comment"
- case ReviewTypeRequest:
- return "dot-fill"
- default:
- return "comment"
- }
- }
-
- // Review represents collection of code comments giving feedback for a PR
- type Review struct {
- ID int64 `xorm:"pk autoincr"`
- Type ReviewType
- Reviewer *User `xorm:"-"`
- ReviewerID int64 `xorm:"index"`
- ReviewerTeamID int64 `xorm:"NOT NULL DEFAULT 0"`
- ReviewerTeam *Team `xorm:"-"`
- OriginalAuthor string
- OriginalAuthorID int64
- Issue *Issue `xorm:"-"`
- IssueID int64 `xorm:"index"`
- Content string `xorm:"TEXT"`
- // Official is a review made by an assigned approver (counts towards approval)
- Official bool `xorm:"NOT NULL DEFAULT false"`
- CommitID string `xorm:"VARCHAR(40)"`
- Stale bool `xorm:"NOT NULL DEFAULT false"`
- Dismissed bool `xorm:"NOT NULL DEFAULT false"`
-
- CreatedUnix timeutil.TimeStamp `xorm:"INDEX created"`
- UpdatedUnix timeutil.TimeStamp `xorm:"INDEX updated"`
-
- // CodeComments are the initial code comments of the review
- CodeComments CodeComments `xorm:"-"`
-
- Comments []*Comment `xorm:"-"`
- }
-
- func (r *Review) loadCodeComments(e Engine) (err error) {
- if r.CodeComments != nil {
- return
- }
- if err = r.loadIssue(e); err != nil {
- return
- }
- r.CodeComments, err = fetchCodeCommentsByReview(e, r.Issue, nil, r)
- return
- }
-
- // LoadCodeComments loads CodeComments
- func (r *Review) LoadCodeComments() error {
- return r.loadCodeComments(x)
- }
-
- func (r *Review) loadIssue(e Engine) (err error) {
- if r.Issue != nil {
- return
- }
- r.Issue, err = getIssueByID(e, r.IssueID)
- return
- }
-
- func (r *Review) loadReviewer(e Engine) (err error) {
- if r.ReviewerID == 0 || r.Reviewer != nil {
- return
- }
- r.Reviewer, err = getUserByID(e, r.ReviewerID)
- return
- }
-
- func (r *Review) loadReviewerTeam(e Engine) (err error) {
- if r.ReviewerTeamID == 0 || r.ReviewerTeam != nil {
- return
- }
-
- r.ReviewerTeam, err = getTeamByID(e, r.ReviewerTeamID)
- return
- }
-
- // LoadReviewer loads reviewer
- func (r *Review) LoadReviewer() error {
- return r.loadReviewer(x)
- }
-
- // LoadReviewerTeam loads reviewer team
- func (r *Review) LoadReviewerTeam() error {
- return r.loadReviewerTeam(x)
- }
-
- func (r *Review) loadAttributes(e Engine) (err error) {
- if err = r.loadIssue(e); err != nil {
- return
- }
- if err = r.loadCodeComments(e); err != nil {
- return
- }
- if err = r.loadReviewer(e); err != nil {
- return
- }
- if err = r.loadReviewerTeam(e); err != nil {
- return
- }
- return
- }
-
- // LoadAttributes loads all attributes except CodeComments
- func (r *Review) LoadAttributes() error {
- return r.loadAttributes(x)
- }
-
- func getReviewByID(e Engine, id int64) (*Review, error) {
- review := new(Review)
- if has, err := e.ID(id).Get(review); err != nil {
- return nil, err
- } else if !has {
- return nil, ErrReviewNotExist{ID: id}
- } else {
- return review, nil
- }
- }
-
- // GetReviewByID returns the review by the given ID
- func GetReviewByID(id int64) (*Review, error) {
- return getReviewByID(x, id)
- }
-
- // FindReviewOptions represent possible filters to find reviews
- type FindReviewOptions struct {
- ListOptions
- Type ReviewType
- IssueID int64
- ReviewerID int64
- OfficialOnly bool
- }
-
- func (opts *FindReviewOptions) toCond() builder.Cond {
- cond := builder.NewCond()
- if opts.IssueID > 0 {
- cond = cond.And(builder.Eq{"issue_id": opts.IssueID})
- }
- if opts.ReviewerID > 0 {
- cond = cond.And(builder.Eq{"reviewer_id": opts.ReviewerID})
- }
- if opts.Type != ReviewTypeUnknown {
- cond = cond.And(builder.Eq{"type": opts.Type})
- }
- if opts.OfficialOnly {
- cond = cond.And(builder.Eq{"official": true})
- }
- return cond
- }
-
- func findReviews(e Engine, opts FindReviewOptions) ([]*Review, error) {
- reviews := make([]*Review, 0, 10)
- sess := e.Where(opts.toCond())
- if opts.Page > 0 {
- sess = opts.ListOptions.setSessionPagination(sess)
- }
- return reviews, sess.
- Asc("created_unix").
- Asc("id").
- Find(&reviews)
- }
-
- // FindReviews returns reviews passing FindReviewOptions
- func FindReviews(opts FindReviewOptions) ([]*Review, error) {
- return findReviews(x, opts)
- }
-
- // CreateReviewOptions represent the options to create a review. Type, Issue and Reviewer are required.
- type CreateReviewOptions struct {
- Content string
- Type ReviewType
- Issue *Issue
- Reviewer *User
- ReviewerTeam *Team
- Official bool
- CommitID string
- Stale bool
- }
-
- // IsOfficialReviewer check if at least one of the provided reviewers can make official reviews in issue (counts towards required approvals)
- func IsOfficialReviewer(issue *Issue, reviewers ...*User) (bool, error) {
- return isOfficialReviewer(x, issue, reviewers...)
- }
-
- func isOfficialReviewer(e Engine, issue *Issue, reviewers ...*User) (bool, error) {
- pr, err := getPullRequestByIssueID(e, issue.ID)
- if err != nil {
- return false, err
- }
- if err = pr.loadProtectedBranch(e); err != nil {
- return false, err
- }
- if pr.ProtectedBranch == nil {
- return false, nil
- }
-
- for _, reviewer := range reviewers {
- official, err := pr.ProtectedBranch.isUserOfficialReviewer(e, reviewer)
- if official || err != nil {
- return official, err
- }
- }
-
- return false, nil
- }
-
- // IsOfficialReviewerTeam check if reviewer in this team can make official reviews in issue (counts towards required approvals)
- func IsOfficialReviewerTeam(issue *Issue, team *Team) (bool, error) {
- return isOfficialReviewerTeam(x, issue, team)
- }
-
- func isOfficialReviewerTeam(e Engine, issue *Issue, team *Team) (bool, error) {
- pr, err := getPullRequestByIssueID(e, issue.ID)
- if err != nil {
- return false, err
- }
- if err = pr.loadProtectedBranch(e); err != nil {
- return false, err
- }
- if pr.ProtectedBranch == nil {
- return false, nil
- }
-
- if !pr.ProtectedBranch.EnableApprovalsWhitelist {
- return team.Authorize >= AccessModeWrite, nil
- }
-
- return base.Int64sContains(pr.ProtectedBranch.ApprovalsWhitelistTeamIDs, team.ID), nil
- }
-
- func createReview(e Engine, opts CreateReviewOptions) (*Review, error) {
- review := &Review{
- Type: opts.Type,
- Issue: opts.Issue,
- IssueID: opts.Issue.ID,
- Reviewer: opts.Reviewer,
- ReviewerTeam: opts.ReviewerTeam,
- Content: opts.Content,
- Official: opts.Official,
- CommitID: opts.CommitID,
- Stale: opts.Stale,
- }
- if opts.Reviewer != nil {
- review.ReviewerID = opts.Reviewer.ID
- } else {
- if review.Type != ReviewTypeRequest {
- review.Type = ReviewTypeRequest
- }
- review.ReviewerTeamID = opts.ReviewerTeam.ID
- }
- if _, err := e.Insert(review); err != nil {
- return nil, err
- }
-
- return review, nil
- }
-
- // CreateReview creates a new review based on opts
- func CreateReview(opts CreateReviewOptions) (*Review, error) {
- return createReview(x, opts)
- }
-
- func getCurrentReview(e Engine, reviewer *User, issue *Issue) (*Review, error) {
- if reviewer == nil {
- return nil, nil
- }
- reviews, err := findReviews(e, FindReviewOptions{
- Type: ReviewTypePending,
- IssueID: issue.ID,
- ReviewerID: reviewer.ID,
- })
- if err != nil {
- return nil, err
- }
- if len(reviews) == 0 {
- return nil, ErrReviewNotExist{}
- }
- reviews[0].Reviewer = reviewer
- reviews[0].Issue = issue
- return reviews[0], nil
- }
-
- // ReviewExists returns whether a review exists for a particular line of code in the PR
- func ReviewExists(issue *Issue, treePath string, line int64) (bool, error) {
- return x.Cols("id").Exist(&Comment{IssueID: issue.ID, TreePath: treePath, Line: line, Type: CommentTypeCode})
- }
-
- // GetCurrentReview returns the current pending review of reviewer for given issue
- func GetCurrentReview(reviewer *User, issue *Issue) (*Review, error) {
- return getCurrentReview(x, reviewer, issue)
- }
-
- // ContentEmptyErr represents an content empty error
- type ContentEmptyErr struct{}
-
- func (ContentEmptyErr) Error() string {
- return "Review content is empty"
- }
-
- // IsContentEmptyErr returns true if err is a ContentEmptyErr
- func IsContentEmptyErr(err error) bool {
- _, ok := err.(ContentEmptyErr)
- return ok
- }
-
- // SubmitReview creates a review out of the existing pending review or creates a new one if no pending review exist
- func SubmitReview(doer *User, issue *Issue, reviewType ReviewType, content, commitID string, stale bool) (*Review, *Comment, error) {
- sess := x.NewSession()
- defer sess.Close()
- if err := sess.Begin(); err != nil {
- return nil, nil, err
- }
-
- official := false
-
- review, err := getCurrentReview(sess, doer, issue)
- if err != nil {
- if !IsErrReviewNotExist(err) {
- return nil, nil, err
- }
-
- if reviewType != ReviewTypeApprove && len(strings.TrimSpace(content)) == 0 {
- return nil, nil, ContentEmptyErr{}
- }
-
- if reviewType == ReviewTypeApprove || reviewType == ReviewTypeReject {
- // Only reviewers latest review of type approve and reject shall count as "official", so existing reviews needs to be cleared
- if _, err := sess.Exec("UPDATE `review` SET official=? WHERE issue_id=? AND reviewer_id=?", false, issue.ID, doer.ID); err != nil {
- return nil, nil, err
- }
- if official, err = isOfficialReviewer(sess, issue, doer); err != nil {
- return nil, nil, err
- }
- }
-
- // No current review. Create a new one!
- if review, err = createReview(sess, CreateReviewOptions{
- Type: reviewType,
- Issue: issue,
- Reviewer: doer,
- Content: content,
- Official: official,
- CommitID: commitID,
- Stale: stale,
- }); err != nil {
- return nil, nil, err
- }
- } else {
- if err := review.loadCodeComments(sess); err != nil {
- return nil, nil, err
- }
- if reviewType != ReviewTypeApprove && len(review.CodeComments) == 0 && len(strings.TrimSpace(content)) == 0 {
- return nil, nil, ContentEmptyErr{}
- }
-
- if reviewType == ReviewTypeApprove || reviewType == ReviewTypeReject {
- // Only reviewers latest review of type approve and reject shall count as "official", so existing reviews needs to be cleared
- if _, err := sess.Exec("UPDATE `review` SET official=? WHERE issue_id=? AND reviewer_id=?", false, issue.ID, doer.ID); err != nil {
- return nil, nil, err
- }
- if official, err = isOfficialReviewer(sess, issue, doer); err != nil {
- return nil, nil, err
- }
- }
-
- review.Official = official
- review.Issue = issue
- review.Content = content
- review.Type = reviewType
- review.CommitID = commitID
- review.Stale = stale
-
- if _, err := sess.ID(review.ID).Cols("content, type, official, commit_id, stale").Update(review); err != nil {
- return nil, nil, err
- }
- }
-
- comm, err := createComment(sess, &CreateCommentOptions{
- Type: CommentTypeReview,
- Doer: doer,
- Content: review.Content,
- Issue: issue,
- Repo: issue.Repo,
- ReviewID: review.ID,
- })
- if err != nil || comm == nil {
- return nil, nil, err
- }
-
- // try to remove team review request if need
- if issue.Repo.Owner.IsOrganization() && (reviewType == ReviewTypeApprove || reviewType == ReviewTypeReject) {
- teamReviewRequests := make([]*Review, 0, 10)
- if err := sess.SQL("SELECT * FROM review WHERE reviewer_team_id > 0 AND type = ?", ReviewTypeRequest).Find(&teamReviewRequests); err != nil {
- return nil, nil, err
- }
-
- for _, teamReviewRequest := range teamReviewRequests {
- ok, err := isTeamMember(sess, issue.Repo.OwnerID, teamReviewRequest.ReviewerTeamID, doer.ID)
- if err != nil {
- return nil, nil, err
- } else if !ok {
- continue
- }
-
- if _, err := sess.Delete(teamReviewRequest); err != nil {
- return nil, nil, err
- }
- }
- }
-
- comm.Review = review
- return review, comm, sess.Commit()
- }
-
- // GetReviewersByIssueID gets the latest review of each reviewer for a pull request
- func GetReviewersByIssueID(issueID int64) ([]*Review, error) {
- reviews := make([]*Review, 0, 10)
-
- sess := x.NewSession()
- defer sess.Close()
- if err := sess.Begin(); err != nil {
- return nil, err
- }
-
- // Get latest review of each reviwer, sorted in order they were made
- if err := sess.SQL("SELECT * FROM review WHERE id IN (SELECT max(id) as id FROM review WHERE issue_id = ? AND reviewer_team_id = 0 AND type in (?, ?, ?) AND dismissed = ? AND original_author_id = 0 GROUP BY issue_id, reviewer_id) ORDER BY review.updated_unix ASC",
- issueID, ReviewTypeApprove, ReviewTypeReject, ReviewTypeRequest, false).
- Find(&reviews); err != nil {
- return nil, err
- }
-
- teamReviewRequests := make([]*Review, 0, 5)
- if err := sess.SQL("SELECT * FROM review WHERE id IN (SELECT max(id) as id FROM review WHERE issue_id = ? AND reviewer_team_id <> 0 AND original_author_id = 0 GROUP BY issue_id, reviewer_team_id) ORDER BY review.updated_unix ASC",
- issueID).
- Find(&teamReviewRequests); err != nil {
- return nil, err
- }
-
- if len(teamReviewRequests) > 0 {
- reviews = append(reviews, teamReviewRequests...)
- }
-
- return reviews, nil
- }
-
- // GetReviewersFromOriginalAuthorsByIssueID gets the latest review of each original authors for a pull request
- func GetReviewersFromOriginalAuthorsByIssueID(issueID int64) ([]*Review, error) {
- reviews := make([]*Review, 0, 10)
-
- // Get latest review of each reviwer, sorted in order they were made
- if err := x.SQL("SELECT * FROM review WHERE id IN (SELECT max(id) as id FROM review WHERE issue_id = ? AND reviewer_team_id = 0 AND type in (?, ?, ?) AND original_author_id <> 0 GROUP BY issue_id, original_author_id) ORDER BY review.updated_unix ASC",
- issueID, ReviewTypeApprove, ReviewTypeReject, ReviewTypeRequest).
- Find(&reviews); err != nil {
- return nil, err
- }
-
- return reviews, nil
- }
-
- // GetReviewByIssueIDAndUserID get the latest review of reviewer for a pull request
- func GetReviewByIssueIDAndUserID(issueID, userID int64) (*Review, error) {
- return getReviewByIssueIDAndUserID(x, issueID, userID)
- }
-
- func getReviewByIssueIDAndUserID(e Engine, issueID, userID int64) (*Review, error) {
- review := new(Review)
-
- has, err := e.SQL("SELECT * FROM review WHERE id IN (SELECT max(id) as id FROM review WHERE issue_id = ? AND reviewer_id = ? AND original_author_id = 0 AND type in (?, ?, ?))",
- issueID, userID, ReviewTypeApprove, ReviewTypeReject, ReviewTypeRequest).
- Get(review)
- if err != nil {
- return nil, err
- }
-
- if !has {
- return nil, ErrReviewNotExist{}
- }
-
- return review, nil
- }
-
- // GetTeamReviewerByIssueIDAndTeamID get the latest review requst of reviewer team for a pull request
- func GetTeamReviewerByIssueIDAndTeamID(issueID, teamID int64) (review *Review, err error) {
- return getTeamReviewerByIssueIDAndTeamID(x, issueID, teamID)
- }
-
- func getTeamReviewerByIssueIDAndTeamID(e Engine, issueID, teamID int64) (review *Review, err error) {
- review = new(Review)
-
- has := false
- if has, err = e.SQL("SELECT * FROM review WHERE id IN (SELECT max(id) as id FROM review WHERE issue_id = ? AND reviewer_team_id = ?)",
- issueID, teamID).
- Get(review); err != nil {
- return nil, err
- }
-
- if !has {
- return nil, ErrReviewNotExist{0}
- }
-
- return
- }
-
- // MarkReviewsAsStale marks existing reviews as stale
- func MarkReviewsAsStale(issueID int64) (err error) {
- _, err = x.Exec("UPDATE `review` SET stale=? WHERE issue_id=?", true, issueID)
-
- return
- }
-
- // MarkReviewsAsNotStale marks existing reviews as not stale for a giving commit SHA
- func MarkReviewsAsNotStale(issueID int64, commitID string) (err error) {
- _, err = x.Exec("UPDATE `review` SET stale=? WHERE issue_id=? AND commit_id=?", false, issueID, commitID)
-
- return
- }
-
- // DismissReview change the dismiss status of a review
- func DismissReview(review *Review, isDismiss bool) (err error) {
- if review.Dismissed == isDismiss || (review.Type != ReviewTypeApprove && review.Type != ReviewTypeReject) {
- return nil
- }
-
- review.Dismissed = isDismiss
-
- _, err = x.Cols("dismissed").Update(review)
-
- return
- }
-
- // InsertReviews inserts review and review comments
- func InsertReviews(reviews []*Review) error {
- sess := x.NewSession()
- defer sess.Close()
-
- if err := sess.Begin(); err != nil {
- return err
- }
-
- for _, review := range reviews {
- if _, err := sess.NoAutoTime().Insert(review); err != nil {
- return err
- }
-
- if _, err := sess.NoAutoTime().Insert(&Comment{
- Type: CommentTypeReview,
- Content: review.Content,
- PosterID: review.ReviewerID,
- OriginalAuthor: review.OriginalAuthor,
- OriginalAuthorID: review.OriginalAuthorID,
- IssueID: review.IssueID,
- ReviewID: review.ID,
- CreatedUnix: review.CreatedUnix,
- UpdatedUnix: review.UpdatedUnix,
- }); err != nil {
- return err
- }
-
- for _, c := range review.Comments {
- c.ReviewID = review.ID
- }
-
- if len(review.Comments) > 0 {
- if _, err := sess.NoAutoTime().Insert(review.Comments); err != nil {
- return err
- }
- }
- }
-
- return sess.Commit()
- }
-
- // AddReviewRequest add a review request from one reviewer
- func AddReviewRequest(issue *Issue, reviewer, doer *User) (*Comment, error) {
- sess := x.NewSession()
- defer sess.Close()
- if err := sess.Begin(); err != nil {
- return nil, err
- }
-
- review, err := getReviewByIssueIDAndUserID(sess, issue.ID, reviewer.ID)
- if err != nil && !IsErrReviewNotExist(err) {
- return nil, err
- }
-
- // skip it when reviewer hase been request to review
- if review != nil && review.Type == ReviewTypeRequest {
- return nil, nil
- }
-
- official, err := isOfficialReviewer(sess, issue, reviewer, doer)
- if err != nil {
- return nil, err
- } else if official {
- if _, err := sess.Exec("UPDATE `review` SET official=? WHERE issue_id=? AND reviewer_id=?", false, issue.ID, reviewer.ID); err != nil {
- return nil, err
- }
- }
-
- review, err = createReview(sess, CreateReviewOptions{
- Type: ReviewTypeRequest,
- Issue: issue,
- Reviewer: reviewer,
- Official: official,
- Stale: false,
- })
- if err != nil {
- return nil, err
- }
-
- comment, err := createComment(sess, &CreateCommentOptions{
- Type: CommentTypeReviewRequest,
- Doer: doer,
- Repo: issue.Repo,
- Issue: issue,
- RemovedAssignee: false, // Use RemovedAssignee as !isRequest
- AssigneeID: reviewer.ID, // Use AssigneeID as reviewer ID
- ReviewID: review.ID,
- })
- if err != nil {
- return nil, err
- }
-
- return comment, sess.Commit()
- }
-
- // RemoveReviewRequest remove a review request from one reviewer
- func RemoveReviewRequest(issue *Issue, reviewer, doer *User) (*Comment, error) {
- sess := x.NewSession()
- defer sess.Close()
- if err := sess.Begin(); err != nil {
- return nil, err
- }
-
- review, err := getReviewByIssueIDAndUserID(sess, issue.ID, reviewer.ID)
- if err != nil && !IsErrReviewNotExist(err) {
- return nil, err
- }
-
- if review == nil || review.Type != ReviewTypeRequest {
- return nil, nil
- }
-
- if _, err = sess.Delete(review); err != nil {
- return nil, err
- }
-
- official, err := isOfficialReviewer(sess, issue, reviewer)
- if err != nil {
- return nil, err
- } else if official {
- // recalculate the latest official review for reviewer
- review, err := getReviewByIssueIDAndUserID(sess, issue.ID, reviewer.ID)
- if err != nil && !IsErrReviewNotExist(err) {
- return nil, err
- }
-
- if review != nil {
- if _, err := sess.Exec("UPDATE `review` SET official=? WHERE id=?", true, review.ID); err != nil {
- return nil, err
- }
- }
- }
-
- comment, err := createComment(sess, &CreateCommentOptions{
- Type: CommentTypeReviewRequest,
- Doer: doer,
- Repo: issue.Repo,
- Issue: issue,
- RemovedAssignee: true, // Use RemovedAssignee as !isRequest
- AssigneeID: reviewer.ID, // Use AssigneeID as reviewer ID
- })
- if err != nil {
- return nil, err
- }
-
- return comment, sess.Commit()
- }
-
- // AddTeamReviewRequest add a review request from one team
- func AddTeamReviewRequest(issue *Issue, reviewer *Team, doer *User) (*Comment, error) {
- sess := x.NewSession()
- defer sess.Close()
- if err := sess.Begin(); err != nil {
- return nil, err
- }
-
- review, err := getTeamReviewerByIssueIDAndTeamID(sess, issue.ID, reviewer.ID)
- if err != nil && !IsErrReviewNotExist(err) {
- return nil, err
- }
-
- // This team already has been requested to review - therefore skip this.
- if review != nil {
- return nil, nil
- }
-
- official, err := isOfficialReviewerTeam(sess, issue, reviewer)
- if err != nil {
- return nil, fmt.Errorf("isOfficialReviewerTeam(): %v", err)
- } else if !official {
- if official, err = isOfficialReviewer(sess, issue, doer); err != nil {
- return nil, fmt.Errorf("isOfficialReviewer(): %v", err)
- }
- }
-
- if review, err = createReview(sess, CreateReviewOptions{
- Type: ReviewTypeRequest,
- Issue: issue,
- ReviewerTeam: reviewer,
- Official: official,
- Stale: false,
- }); err != nil {
- return nil, err
- }
-
- if official {
- if _, err := sess.Exec("UPDATE `review` SET official=? WHERE issue_id=? AND reviewer_team_id=?", false, issue.ID, reviewer.ID); err != nil {
- return nil, err
- }
- }
-
- comment, err := createComment(sess, &CreateCommentOptions{
- Type: CommentTypeReviewRequest,
- Doer: doer,
- Repo: issue.Repo,
- Issue: issue,
- RemovedAssignee: false, // Use RemovedAssignee as !isRequest
- AssigneeTeamID: reviewer.ID, // Use AssigneeTeamID as reviewer team ID
- ReviewID: review.ID,
- })
- if err != nil {
- return nil, fmt.Errorf("createComment(): %v", err)
- }
-
- return comment, sess.Commit()
- }
-
- // RemoveTeamReviewRequest remove a review request from one team
- func RemoveTeamReviewRequest(issue *Issue, reviewer *Team, doer *User) (*Comment, error) {
- sess := x.NewSession()
- defer sess.Close()
- if err := sess.Begin(); err != nil {
- return nil, err
- }
-
- review, err := getTeamReviewerByIssueIDAndTeamID(sess, issue.ID, reviewer.ID)
- if err != nil && !IsErrReviewNotExist(err) {
- return nil, err
- }
-
- if review == nil {
- return nil, nil
- }
-
- if _, err = sess.Delete(review); err != nil {
- return nil, err
- }
-
- official, err := isOfficialReviewerTeam(sess, issue, reviewer)
- if err != nil {
- return nil, fmt.Errorf("isOfficialReviewerTeam(): %v", err)
- }
-
- if official {
- // recalculate which is the latest official review from that team
- review, err := getReviewByIssueIDAndUserID(sess, issue.ID, -reviewer.ID)
- if err != nil && !IsErrReviewNotExist(err) {
- return nil, err
- }
-
- if review != nil {
- if _, err := sess.Exec("UPDATE `review` SET official=? WHERE id=?", true, review.ID); err != nil {
- return nil, err
- }
- }
- }
-
- if doer == nil {
- return nil, sess.Commit()
- }
-
- comment, err := createComment(sess, &CreateCommentOptions{
- Type: CommentTypeReviewRequest,
- Doer: doer,
- Repo: issue.Repo,
- Issue: issue,
- RemovedAssignee: true, // Use RemovedAssignee as !isRequest
- AssigneeTeamID: reviewer.ID, // Use AssigneeTeamID as reviewer team ID
- })
- if err != nil {
- return nil, fmt.Errorf("createComment(): %v", err)
- }
-
- return comment, sess.Commit()
- }
-
- // MarkConversation Add or remove Conversation mark for a code comment
- func MarkConversation(comment *Comment, doer *User, isResolve bool) (err error) {
- if comment.Type != CommentTypeCode {
- return nil
- }
-
- if isResolve {
- if comment.ResolveDoerID != 0 {
- return nil
- }
-
- if _, err = x.Exec("UPDATE `comment` SET resolve_doer_id=? WHERE id=?", doer.ID, comment.ID); err != nil {
- return err
- }
- } else {
- if comment.ResolveDoerID == 0 {
- return nil
- }
-
- if _, err = x.Exec("UPDATE `comment` SET resolve_doer_id=? WHERE id=?", 0, comment.ID); err != nil {
- return err
- }
- }
-
- return nil
- }
-
- // CanMarkConversation Add or remove Conversation mark for a code comment permission check
- // the PR writer , offfcial reviewer and poster can do it
- func CanMarkConversation(issue *Issue, doer *User) (permResult bool, err error) {
- if doer == nil || issue == nil {
- return false, fmt.Errorf("issue or doer is nil")
- }
-
- if doer.ID != issue.PosterID {
- if err = issue.LoadRepo(); err != nil {
- return false, err
- }
-
- perm, err := GetUserRepoPermission(issue.Repo, doer)
- if err != nil {
- return false, err
- }
-
- permResult = perm.CanAccess(AccessModeWrite, UnitTypePullRequests)
- if !permResult {
- if permResult, err = IsOfficialReviewer(issue, doer); err != nil {
- return false, err
- }
- }
-
- if !permResult {
- return false, nil
- }
- }
-
- return true, nil
- }
-
- // DeleteReview delete a review and it's code comments
- func DeleteReview(r *Review) error {
- sess := x.NewSession()
- defer sess.Close()
-
- if err := sess.Begin(); err != nil {
- return err
- }
-
- if r.ID == 0 {
- return fmt.Errorf("review is not allowed to be 0")
- }
-
- if r.Type == ReviewTypeRequest {
- return fmt.Errorf("review request can not be deleted using this method")
- }
-
- opts := FindCommentsOptions{
- Type: CommentTypeCode,
- IssueID: r.IssueID,
- ReviewID: r.ID,
- }
-
- if _, err := sess.Where(opts.toConds()).Delete(new(Comment)); err != nil {
- return err
- }
-
- opts = FindCommentsOptions{
- Type: CommentTypeReview,
- IssueID: r.IssueID,
- ReviewID: r.ID,
- }
-
- if _, err := sess.Where(opts.toConds()).Delete(new(Comment)); err != nil {
- return err
- }
-
- if _, err := sess.ID(r.ID).Delete(new(Review)); err != nil {
- return err
- }
-
- return sess.Commit()
- }
-
- // GetCodeCommentsCount return count of CodeComments a Review has
- func (r *Review) GetCodeCommentsCount() int {
- opts := FindCommentsOptions{
- Type: CommentTypeCode,
- IssueID: r.IssueID,
- ReviewID: r.ID,
- }
- conds := opts.toConds()
- if r.ID == 0 {
- conds = conds.And(builder.Eq{"invalidated": false})
- }
-
- count, err := x.Where(conds).Count(new(Comment))
- if err != nil {
- return 0
- }
- return int(count)
- }
-
- // HTMLURL formats a URL-string to the related review issue-comment
- func (r *Review) HTMLURL() string {
- opts := FindCommentsOptions{
- Type: CommentTypeReview,
- IssueID: r.IssueID,
- ReviewID: r.ID,
- }
- comment := new(Comment)
- has, err := x.Where(opts.toConds()).Get(comment)
- if err != nil || !has {
- return ""
- }
- return comment.HTMLURL()
- }
|