gitea

History

Jason Song 77c89572e9 Fix isAllowed of escapeStreamer (#22814) (#22837) Backport #22814. The use of `sort.Search` is wrong: The slice should be sorted, and `return >= 0` doen't mean it exists, see the [manual](https://pkg.go.dev/sort#Search). Could be fixed like this if we really need it: ```diff diff --git a/modules/charset/escape_stream.go b/modules/charset/escape_stream.go index 823b63513..fcf1ffbc1 100644 --- a/modules/charset/escape_stream.go +++ b/modules/charset/escape_stream.go @@ -20,6 +20,9 @@ import ( var defaultWordRegexp = regexp.MustCompile(`(-?\d\.\d\w)\|([^\` + "`" + `\~\!\@\#\$\%\^\&\\-\=\+\[\{\]\}\\\\|\;\:\'\"\,\.\<\>\/\?\s\x00-\x1f]+)`) func NewEscapeStreamer(locale translation.Locale, next HTMLStreamer, allowed ...rune) HTMLStreamer { + sort.Slice(allowed, func(i, j int) bool { + return allowed[i] < allowed[j] + }) return &escapeStreamer{ escaped: &EscapeStatus{}, PassthroughHTMLStreamer: NewPassthroughStreamer(next), @@ -284,14 +287,8 @@ func (e escapeStreamer) runeTypes(runes ...rune) (types []runeType, confusables } func (e escapeStreamer) isAllowed(r rune) bool { - if len(e.allowed) == 0 { - return false - } - if len(e.allowed) == 1 { - return e.allowed[0] == r - } - - return sort.Search(len(e.allowed), func(i int) bool { + i := sort.Search(len(e.allowed), func(i int) bool { return e.allowed[i] >= r - }) >= 0 + }) + return i < len(e.allowed) && e.allowed[i] == r } ``` But I don't think so, a map is better to do it.		1 year ago
..
ambiguous	Move go-licenses to generate and separate generate into a frontend and backend component (#21061)	1 year ago
invisible	Move go-licenses to generate and separate generate into a frontend and backend component (#21061)	1 year ago
ambiguous.go	Ensure that Chinese punctuation is not ambiguous when locale is Chinese (#22019) (#22030)	1 year ago
ambiguous_gen.go	Switch Unicode Escaping to a VSCode-like system (#19990)	1 year ago
ambiguous_gen_test.go	Switch Unicode Escaping to a VSCode-like system (#19990)	1 year ago
breakwriter.go	Switch Unicode Escaping to a VSCode-like system (#19990)	1 year ago
breakwriter_test.go	Switch Unicode Escaping to a VSCode-like system (#19990)	1 year ago
charset.go	Fix various typos (#20338)	1 year ago
charset_test.go	Add more linters to improve code readability (#19989)	2 years ago
escape.go	Fix line spacing for plaintext previews (#22699) (#22701)	1 year ago
escape_status.go	Switch Unicode Escaping to a VSCode-like system (#19990)	1 year ago
escape_stream.go	Fix isAllowed of escapeStreamer (#22814) (#22837)	1 year ago
escape_test.go	Share HTML template renderers and create a watcher framework (#20218)	1 year ago
htmlstream.go	Switch Unicode Escaping to a VSCode-like system (#19990)	1 year ago
invisible_gen.go	Switch Unicode Escaping to a VSCode-like system (#19990)	1 year ago