123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176 |
- // Copyright 2019 The Gitea Authors. All rights reserved.
- // SPDX-License-Identifier: MIT
-
- package integration
-
- import (
- "net/http"
- "net/url"
- "strings"
- "testing"
-
- "code.gitea.io/gitea/models/db"
- issues_model "code.gitea.io/gitea/models/issues"
- "code.gitea.io/gitea/models/unittest"
- user_model "code.gitea.io/gitea/models/user"
- "code.gitea.io/gitea/modules/test"
- issue_service "code.gitea.io/gitea/services/issue"
- repo_service "code.gitea.io/gitea/services/repository"
- files_service "code.gitea.io/gitea/services/repository/files"
- "code.gitea.io/gitea/tests"
-
- "github.com/stretchr/testify/assert"
- )
-
- func TestPullView_ReviewerMissed(t *testing.T) {
- defer tests.PrepareTestEnv(t)()
- session := loginUser(t, "user1")
-
- req := NewRequest(t, "GET", "/pulls")
- resp := session.MakeRequest(t, req, http.StatusOK)
- assert.True(t, test.IsNormalPageCompleted(resp.Body.String()))
-
- req = NewRequest(t, "GET", "/user2/repo1/pulls/3")
- resp = session.MakeRequest(t, req, http.StatusOK)
- assert.True(t, test.IsNormalPageCompleted(resp.Body.String()))
-
- // if some reviews are missing, the page shouldn't fail
- err := db.TruncateBeans(db.DefaultContext, &issues_model.Review{})
- assert.NoError(t, err)
- req = NewRequest(t, "GET", "/user2/repo1/pulls/2")
- resp = session.MakeRequest(t, req, http.StatusOK)
- assert.True(t, test.IsNormalPageCompleted(resp.Body.String()))
- }
-
- func TestPullView_CodeOwner(t *testing.T) {
- onGiteaRun(t, func(t *testing.T, u *url.URL) {
- user2 := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 2})
-
- // Create the repo.
- repo, err := repo_service.CreateRepositoryDirectly(db.DefaultContext, user2, user2, repo_service.CreateRepoOptions{
- Name: "test_codeowner",
- Readme: "Default",
- AutoInit: true,
- DefaultBranch: "master",
- })
- assert.NoError(t, err)
-
- // add CODEOWNERS to default branch
- _, err = files_service.ChangeRepoFiles(db.DefaultContext, repo, user2, &files_service.ChangeRepoFilesOptions{
- OldBranch: repo.DefaultBranch,
- Files: []*files_service.ChangeRepoFile{
- {
- Operation: "create",
- TreePath: "CODEOWNERS",
- ContentReader: strings.NewReader("README.md @user5\n"),
- },
- },
- })
- assert.NoError(t, err)
-
- t.Run("First Pull Request", func(t *testing.T) {
- // create a new branch to prepare for pull request
- _, err = files_service.ChangeRepoFiles(db.DefaultContext, repo, user2, &files_service.ChangeRepoFilesOptions{
- NewBranch: "codeowner-basebranch",
- Files: []*files_service.ChangeRepoFile{
- {
- Operation: "update",
- TreePath: "README.md",
- ContentReader: strings.NewReader("# This is a new project\n"),
- },
- },
- })
- assert.NoError(t, err)
-
- // Create a pull request.
- session := loginUser(t, "user2")
- createPullRequest(t, session, "user2", "test_codeowner", repo.DefaultBranch, "codeowner-basebranch", "Test Pull Request")
-
- pr := unittest.AssertExistsAndLoadBean(t, &issues_model.PullRequest{BaseRepoID: repo.ID, HeadRepoID: repo.ID, HeadBranch: "codeowner-basebranch"})
- unittest.AssertExistsIf(t, true, &issues_model.Review{IssueID: pr.IssueID, Type: issues_model.ReviewTypeRequest, ReviewerID: 5})
- assert.NoError(t, pr.LoadIssue(db.DefaultContext))
-
- err := issue_service.ChangeTitle(db.DefaultContext, pr.Issue, user2, "[WIP] Test Pull Request")
- assert.NoError(t, err)
- prUpdated1 := unittest.AssertExistsAndLoadBean(t, &issues_model.PullRequest{ID: pr.ID})
- assert.NoError(t, prUpdated1.LoadIssue(db.DefaultContext))
- assert.EqualValues(t, "[WIP] Test Pull Request", prUpdated1.Issue.Title)
-
- err = issue_service.ChangeTitle(db.DefaultContext, prUpdated1.Issue, user2, "Test Pull Request2")
- assert.NoError(t, err)
- prUpdated2 := unittest.AssertExistsAndLoadBean(t, &issues_model.PullRequest{ID: pr.ID})
- assert.NoError(t, prUpdated2.LoadIssue(db.DefaultContext))
- assert.EqualValues(t, "Test Pull Request2", prUpdated2.Issue.Title)
- })
-
- // change the default branch CODEOWNERS file to change README.md's codeowner
- _, err = files_service.ChangeRepoFiles(db.DefaultContext, repo, user2, &files_service.ChangeRepoFilesOptions{
- Files: []*files_service.ChangeRepoFile{
- {
- Operation: "update",
- TreePath: "CODEOWNERS",
- ContentReader: strings.NewReader("README.md @user8\n"),
- },
- },
- })
- assert.NoError(t, err)
-
- t.Run("Second Pull Request", func(t *testing.T) {
- // create a new branch to prepare for pull request
- _, err = files_service.ChangeRepoFiles(db.DefaultContext, repo, user2, &files_service.ChangeRepoFilesOptions{
- NewBranch: "codeowner-basebranch2",
- Files: []*files_service.ChangeRepoFile{
- {
- Operation: "update",
- TreePath: "README.md",
- ContentReader: strings.NewReader("# This is a new project2\n"),
- },
- },
- })
- assert.NoError(t, err)
-
- // Create a pull request.
- session := loginUser(t, "user2")
- createPullRequest(t, session, "user2", "test_codeowner", repo.DefaultBranch, "codeowner-basebranch2", "Test Pull Request2")
-
- pr := unittest.AssertExistsAndLoadBean(t, &issues_model.PullRequest{BaseRepoID: repo.ID, HeadBranch: "codeowner-basebranch2"})
- unittest.AssertExistsIf(t, true, &issues_model.Review{IssueID: pr.IssueID, Type: issues_model.ReviewTypeRequest, ReviewerID: 8})
- })
-
- t.Run("Forked Repo Pull Request", func(t *testing.T) {
- user5 := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 5})
- forkedRepo, err := repo_service.ForkRepository(db.DefaultContext, user2, user5, repo_service.ForkRepoOptions{
- BaseRepo: repo,
- Name: "test_codeowner",
- })
- assert.NoError(t, err)
-
- // create a new branch to prepare for pull request
- _, err = files_service.ChangeRepoFiles(db.DefaultContext, forkedRepo, user5, &files_service.ChangeRepoFilesOptions{
- NewBranch: "codeowner-basebranch-forked",
- Files: []*files_service.ChangeRepoFile{
- {
- Operation: "update",
- TreePath: "README.md",
- ContentReader: strings.NewReader("# This is a new forked project\n"),
- },
- },
- })
- assert.NoError(t, err)
-
- session := loginUser(t, "user5")
-
- // create a pull request on the forked repository, code reviewers should not be mentioned
- testPullCreateDirectly(t, session, "user5", "test_codeowner", forkedRepo.DefaultBranch, "", "", "codeowner-basebranch-forked", "Test Pull Request on Forked Repository")
-
- pr := unittest.AssertExistsAndLoadBean(t, &issues_model.PullRequest{BaseRepoID: forkedRepo.ID, HeadBranch: "codeowner-basebranch-forked"})
- unittest.AssertExistsIf(t, false, &issues_model.Review{IssueID: pr.IssueID, Type: issues_model.ReviewTypeRequest, ReviewerID: 8})
-
- // create a pull request to base repository, code reviewers should be mentioned
- testPullCreateDirectly(t, session, repo.OwnerName, repo.Name, repo.DefaultBranch, forkedRepo.OwnerName, forkedRepo.Name, "codeowner-basebranch-forked", "Test Pull Request3")
-
- pr = unittest.AssertExistsAndLoadBean(t, &issues_model.PullRequest{BaseRepoID: repo.ID, HeadRepoID: forkedRepo.ID, HeadBranch: "codeowner-basebranch-forked"})
- unittest.AssertExistsIf(t, true, &issues_model.Review{IssueID: pr.IssueID, Type: issues_model.ReviewTypeRequest, ReviewerID: 8})
- })
- })
- }
|