You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

pull_review_test.go 3.6KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293
  1. // Copyright 2024 The Gitea Authors. All rights reserved.
  2. // SPDX-License-Identifier: MIT
  3. package repo
  4. import (
  5. "net/http"
  6. "net/http/httptest"
  7. "testing"
  8. "code.gitea.io/gitea/models/db"
  9. issues_model "code.gitea.io/gitea/models/issues"
  10. "code.gitea.io/gitea/models/unittest"
  11. "code.gitea.io/gitea/modules/templates"
  12. "code.gitea.io/gitea/services/context"
  13. "code.gitea.io/gitea/services/contexttest"
  14. "code.gitea.io/gitea/services/pull"
  15. "github.com/stretchr/testify/assert"
  16. )
  17. func TestRenderConversation(t *testing.T) {
  18. unittest.PrepareTestEnv(t)
  19. pr, _ := issues_model.GetPullRequestByID(db.DefaultContext, 2)
  20. _ = pr.LoadIssue(db.DefaultContext)
  21. _ = pr.Issue.LoadPoster(db.DefaultContext)
  22. _ = pr.Issue.LoadRepo(db.DefaultContext)
  23. run := func(name string, cb func(t *testing.T, ctx *context.Context, resp *httptest.ResponseRecorder)) {
  24. t.Run(name, func(t *testing.T) {
  25. ctx, resp := contexttest.MockContext(t, "/", contexttest.MockContextOption{Render: templates.HTMLRenderer()})
  26. contexttest.LoadUser(t, ctx, pr.Issue.PosterID)
  27. contexttest.LoadRepo(t, ctx, pr.BaseRepoID)
  28. contexttest.LoadGitRepo(t, ctx)
  29. defer ctx.Repo.GitRepo.Close()
  30. cb(t, ctx, resp)
  31. })
  32. }
  33. var preparedComment *issues_model.Comment
  34. run("prepare", func(t *testing.T, ctx *context.Context, resp *httptest.ResponseRecorder) {
  35. comment, err := pull.CreateCodeComment(ctx, pr.Issue.Poster, ctx.Repo.GitRepo, pr.Issue, 1, "content", "", false, 0, pr.HeadCommitID, nil)
  36. if !assert.NoError(t, err) {
  37. return
  38. }
  39. comment.Invalidated = true
  40. err = issues_model.UpdateCommentInvalidate(ctx, comment)
  41. if !assert.NoError(t, err) {
  42. return
  43. }
  44. preparedComment = comment
  45. })
  46. if !assert.NotNil(t, preparedComment) {
  47. return
  48. }
  49. run("diff with outdated", func(t *testing.T, ctx *context.Context, resp *httptest.ResponseRecorder) {
  50. ctx.Data["ShowOutdatedComments"] = true
  51. renderConversation(ctx, preparedComment, "diff")
  52. assert.Contains(t, resp.Body.String(), `<div class="content comment-container"`)
  53. })
  54. run("diff without outdated", func(t *testing.T, ctx *context.Context, resp *httptest.ResponseRecorder) {
  55. ctx.Data["ShowOutdatedComments"] = false
  56. renderConversation(ctx, preparedComment, "diff")
  57. assert.Contains(t, resp.Body.String(), `conversation-not-existing`)
  58. })
  59. run("timeline with outdated", func(t *testing.T, ctx *context.Context, resp *httptest.ResponseRecorder) {
  60. ctx.Data["ShowOutdatedComments"] = true
  61. renderConversation(ctx, preparedComment, "timeline")
  62. assert.Contains(t, resp.Body.String(), `<div id="code-comments-`)
  63. })
  64. run("timeline is not affected by ShowOutdatedComments=false", func(t *testing.T, ctx *context.Context, resp *httptest.ResponseRecorder) {
  65. ctx.Data["ShowOutdatedComments"] = false
  66. renderConversation(ctx, preparedComment, "timeline")
  67. assert.Contains(t, resp.Body.String(), `<div id="code-comments-`)
  68. })
  69. run("diff non-existing review", func(t *testing.T, ctx *context.Context, resp *httptest.ResponseRecorder) {
  70. err := db.TruncateBeans(db.DefaultContext, &issues_model.Review{})
  71. assert.NoError(t, err)
  72. ctx.Data["ShowOutdatedComments"] = true
  73. renderConversation(ctx, preparedComment, "diff")
  74. assert.Equal(t, http.StatusOK, resp.Code)
  75. assert.NotContains(t, resp.Body.String(), `status-page-500`)
  76. })
  77. run("timeline non-existing review", func(t *testing.T, ctx *context.Context, resp *httptest.ResponseRecorder) {
  78. err := db.TruncateBeans(db.DefaultContext, &issues_model.Review{})
  79. assert.NoError(t, err)
  80. ctx.Data["ShowOutdatedComments"] = true
  81. renderConversation(ctx, preparedComment, "timeline")
  82. assert.Equal(t, http.StatusOK, resp.Code)
  83. assert.NotContains(t, resp.Body.String(), `status-page-500`)
  84. })
  85. }