You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

modifies-param.go 1.6KB

1234567891011121314151617181920212223242526272829303132333435363738394041424344454647484950515253545556575859606162636465666768697071727374757677787980
  1. package rule
  2. import (
  3. "fmt"
  4. "go/ast"
  5. "github.com/mgechev/revive/lint"
  6. )
  7. // ModifiesParamRule lints given else constructs.
  8. type ModifiesParamRule struct{}
  9. // Apply applies the rule to given file.
  10. func (r *ModifiesParamRule) Apply(file *lint.File, _ lint.Arguments) []lint.Failure {
  11. var failures []lint.Failure
  12. onFailure := func(failure lint.Failure) {
  13. failures = append(failures, failure)
  14. }
  15. w := lintModifiesParamRule{onFailure: onFailure}
  16. ast.Walk(w, file.AST)
  17. return failures
  18. }
  19. // Name returns the rule name.
  20. func (r *ModifiesParamRule) Name() string {
  21. return "modifies-parameter"
  22. }
  23. type lintModifiesParamRule struct {
  24. params map[string]bool
  25. onFailure func(lint.Failure)
  26. }
  27. func retrieveParamNames(pl []*ast.Field) map[string]bool {
  28. result := make(map[string]bool, len(pl))
  29. for _, p := range pl {
  30. for _, n := range p.Names {
  31. if n.Name == "_" {
  32. continue
  33. }
  34. result[n.Name] = true
  35. }
  36. }
  37. return result
  38. }
  39. func (w lintModifiesParamRule) Visit(node ast.Node) ast.Visitor {
  40. switch v := node.(type) {
  41. case *ast.FuncDecl:
  42. w.params = retrieveParamNames(v.Type.Params.List)
  43. case *ast.IncDecStmt:
  44. if id, ok := v.X.(*ast.Ident); ok {
  45. checkParam(id, &w)
  46. }
  47. case *ast.AssignStmt:
  48. lhs := v.Lhs
  49. for _, e := range lhs {
  50. id, ok := e.(*ast.Ident)
  51. if ok {
  52. checkParam(id, &w)
  53. }
  54. }
  55. }
  56. return w
  57. }
  58. func checkParam(id *ast.Ident, w *lintModifiesParamRule) {
  59. if w.params[id.Name] {
  60. w.onFailure(lint.Failure{
  61. Confidence: 0.5, // confidence is low because of shadow variables
  62. Node: id,
  63. Category: "bad practice",
  64. Failure: fmt.Sprintf("parameter '%s' seems to be modified", id),
  65. })
  66. }
  67. }